RFR: Updated Code Owners for JDK 20 [v2]
Sean Mullan
mullan at openjdk.org
Wed May 17 21:00:15 UTC 2023
On Wed, 17 May 2023 17:03:33 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:
>> This should be done after each release to make sure the list is kept up to date.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>
> Fixed comments
src/guide/code-owners.md line 70:
> 68: * `java.base`
> 69: * Core Libs should almost always be included but Java Language, HotSpot, Security and/or I18n may also be involved.
> 70: * `classes`
Why isn't the `share` directory included here as in `hotspot`? Are these supposed to be full path names? It seems we should be consistent.
src/guide/code-owners.md line 72:
> 70: * `classes`
> 71: * `crypto` – Security
> 72: * `internal`
Should this be `jdk/internal`?
src/guide/code-owners.md line 99:
> 97: * `invoke` – Core Libs
> 98: * `io` – NIO
> 99: * `java`
Missing `security` and several other directories under `java`.
src/guide/code-owners.md line 108:
> 106: * `nio` – NIO
> 107: * `reflect` – Java Language
> 108: * `security` – Security
Should be under `java`.
src/guide/code-owners.md line 109:
> 107: * `reflect` – Java Language
> 108: * `security` – Security
> 109: * `sun/crypto` – Security
There is no such directory named `sun/crypto` - you probably mean `com/sun/crypto` and `com/sun/security`.
src/guide/code-owners.md line 185:
> 183: * `jdk.internal.vm.compiler` – Compiler
> 184: * `jdk.internal.vm.compiler.management` – Compiler
> 185: * `jdk.jartool` – JDK Tools
and Security because this includes `jarsigner`.
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197039265
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197040362
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197042709
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197043059
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197043528
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197046002
More information about the guide-dev
mailing list