RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
calnan
duke at openjdk.org
Wed May 17 21:00:53 UTC 2023
On Wed, 17 May 2023 16:05:20 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed a couple of typos, made sure bullets start with a capital and end with a full stop - except for non-sentence bullets. Clarified how to close a duplicate
>
> src/guide/jbs-jdk-bug-system.md line 101:
>
>> 99:
>> 100: ### Implementing a JEP
>> 101: It recommended that for [JEP]{.jbs-field}s that the implementation is spread across one or more [Enhancement]{.jbs-field}s as above.
>
> It => It is?
fixed
> src/guide/jbs-jdk-bug-system.md line 238:
>
>> 236: <td class="dictionary">If a change is required in a repo to address an issue then the [Fixed]{.jbs-field} status should be used - for the JDK project in almost all cases the bots will transition the issue to [Fixed]{.jbs-field} when the changeset is pushed to the repo.<br />
>> 237: <ul>
>> 238: <li>Once a bug is marked as fixed there is now the option of someone, other than the person that fixed it, marking it as [Verified]{.jbs-field} to confirm that the issue is fix after testing; marking it as [Fix Failed]{.jbs-field} if it did not solve the issue; or, [Not Verified]{.jbs-field} to indicate that it wasn't explicitly tested. Note that the UI does not highlight when [Fix Failed]{.jbs-field} has been set, you need to look for the [Verification]{.jbs-label} Field at the bottom of the left-hand colum in the Details section.</li>
>
> issue is fix => issue is fixed?
fixed (!)
> src/guide/jbs-jdk-bug-system.md line 668:
>
>> 666: <td class="dictionary">[[regression]{.jbs-label}]{#regression}</td>
>> 667: <td class="dictionary">
>> 668: Used to identify regressions. A regression is where behavior has _incorrectly_ changed from a previous build or release. Ideally all regressions must be fixed in the following release. All regressions must have the [Affects Version/s]{.jbs-field} set.
>
>> Ideally all regressions must be fixed in the following release
>
> This sounds weird. Ideally we identify and fix the regressions before they are released. We don't wait until the following release to fix them.
agreed, adjusted it to:
Ideally all regressions are identified and fixed before they are released, if not they must be fixed at latest in the following release after they are identified.
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1197045004
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1197045115
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1197045207
More information about the guide-dev
mailing list