RFR: Updated Code Owners for JDK 20 [v2]
Jesper Wilhelmsson
jwilhelm at openjdk.org
Tue May 23 21:56:18 UTC 2023
On Wed, 17 May 2023 20:49:18 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed comments
>
> src/guide/code-owners.md line 70:
>
>> 68: * `java.base`
>> 69: * Core Libs should almost always be included but Java Language, HotSpot, Security and/or I18n may also be involved.
>> 70: * `classes`
>
> Why isn't the `share` directory included here as in `hotspot`? Are these supposed to be full path names? It seems we should be consistent.
The `share` directory was excluded in `java.base` because the other directories next to `share` (`linux`, `aix` etc) all have the same directory structure in them as `share`, and all those directories with the same names are owned by the same area. We could perhaps add a `*` to show this more clearly?
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1203062119
More information about the guide-dev
mailing list