From jwilhelm at openjdk.org  Thu Oct  5 22:40:29 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 5 Oct 2023 22:40:29 GMT
Subject: RFR: Clarified that for enhancements the affects version should
 normally be empty [v2]
In-Reply-To: <t4FB7RCfPUvkPUG5zOcydzBImU6QN62bX1TH7fj21cM=.a61201db-30b3-4c9d-a395-6f7dfb2f69dc@github.com>
References: <4O2y2syF50lXarNEJIysGQDG-4bPiKUSK_Yv15FGyyM=.883c2e4c-1d72-431f-aca8-2d76e1ccea18@github.com>
 <t4FB7RCfPUvkPUG5zOcydzBImU6QN62bX1TH7fj21cM=.a61201db-30b3-4c9d-a395-6f7dfb2f69dc@github.com>
Message-ID: <GBAyCrDX0JV-guEJkSz_bGWyz79v1k8vBPLVDbCu608=.944307b7-d884-4629-ad1c-82c799f1ba31@github.com>

On Mon, 4 Sep 2023 22:24:18 GMT, calnan <duke at openjdk.org> wrote:

>> Unlike for bugs, for enhancements the affectsversion is less relevant as vast majority will be fixed in a future release and will not be backported. There are situations where it is relevant, if the code is only in an LTS release for example.
>
> calnan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjusted the language about see if the issue is also related to the mainline, and also removed referenced to LTS releases.

Changes requested by jwilhelm (Lead).

src/guide/jbs-jdk-bug-system.md line 167:

> 165: 1. Ensure the [Affects Version/s]{.jbs-field} field is correct (within reason).
> 166:    * This may involve reproducing the bug, if doing so is fast and easy.
> 167:    * In addition to the version where the bug was found, take special care to also investigate if the bug affects the mainline.

I see "mainline" as a name rater than a thing, so I wouldn't have "the" in front of it in this sentence.

-------------

PR Review: https://git.openjdk.org/guide/pull/115#pullrequestreview-1660870751
PR Review Comment: https://git.openjdk.org/guide/pull/115#discussion_r1348071662

From duke at openjdk.org  Thu Oct  5 23:25:57 2023
From: duke at openjdk.org (calnan)
Date: Thu, 5 Oct 2023 23:25:57 GMT
Subject: RFR: Clarified that for enhancements the affects version should
 normally be empty [v3]
In-Reply-To: <4O2y2syF50lXarNEJIysGQDG-4bPiKUSK_Yv15FGyyM=.883c2e4c-1d72-431f-aca8-2d76e1ccea18@github.com>
References: <4O2y2syF50lXarNEJIysGQDG-4bPiKUSK_Yv15FGyyM=.883c2e4c-1d72-431f-aca8-2d76e1ccea18@github.com>
Message-ID: <jnSiqRDJkTNsU71dbcWXOzWJ6QjXOG44qfs-psl7Rkg=.57b33657-1b2c-4cca-a389-da8718d2da67@github.com>

> Unlike for bugs, for enhancements the affectsversion is less relevant as vast majority will be fixed in a future release and will not be backported. There are situations where it is relevant, if the code is only in an LTS release for example.

calnan has updated the pull request incrementally with one additional commit since the last revision:

  Adjusted reference to mainline

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/115/files
  - new: https://git.openjdk.org/guide/pull/115/files/e6de7069..197fd6a4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=115&range=02
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=115&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/115.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/115/head:pull/115

PR: https://git.openjdk.org/guide/pull/115

From duke at openjdk.org  Thu Oct  5 23:26:00 2023
From: duke at openjdk.org (calnan)
Date: Thu, 5 Oct 2023 23:26:00 GMT
Subject: RFR: Clarified that for enhancements the affects version should
 normally be empty [v2]
In-Reply-To: <GBAyCrDX0JV-guEJkSz_bGWyz79v1k8vBPLVDbCu608=.944307b7-d884-4629-ad1c-82c799f1ba31@github.com>
References: <4O2y2syF50lXarNEJIysGQDG-4bPiKUSK_Yv15FGyyM=.883c2e4c-1d72-431f-aca8-2d76e1ccea18@github.com>
 <t4FB7RCfPUvkPUG5zOcydzBImU6QN62bX1TH7fj21cM=.a61201db-30b3-4c9d-a395-6f7dfb2f69dc@github.com>
 <GBAyCrDX0JV-guEJkSz_bGWyz79v1k8vBPLVDbCu608=.944307b7-d884-4629-ad1c-82c799f1ba31@github.com>
Message-ID: <WPvK851MKhm26TDs71rTdTofYJXqss2QPztyocVI6Ek=.ffa492c9-295a-44f0-bab7-c36430338f53@github.com>

On Thu, 5 Oct 2023 22:37:13 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjusted the language about see if the issue is also related to the mainline, and also removed referenced to LTS releases.
>
> src/guide/jbs-jdk-bug-system.md line 167:
> 
>> 165: 1. Ensure the [Affects Version/s]{.jbs-field} field is correct (within reason).
>> 166:    * This may involve reproducing the bug, if doing so is fast and easy.
>> 167:    * In addition to the version where the bug was found, take special care to also investigate if the bug affects the mainline.
> 
> I see "mainline" as a name rater than a thing, so I wouldn't have "the" in front of it in this sentence.

yes good point, makes sense - have removed the offending "the"

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/115#discussion_r1348093467

From jwilhelm at openjdk.org  Mon Oct  9 16:52:26 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Mon, 9 Oct 2023 16:52:26 GMT
Subject: RFR: Clarified that for enhancements the affects version should
 normally be empty [v3]
In-Reply-To: <jnSiqRDJkTNsU71dbcWXOzWJ6QjXOG44qfs-psl7Rkg=.57b33657-1b2c-4cca-a389-da8718d2da67@github.com>
References: <4O2y2syF50lXarNEJIysGQDG-4bPiKUSK_Yv15FGyyM=.883c2e4c-1d72-431f-aca8-2d76e1ccea18@github.com>
 <jnSiqRDJkTNsU71dbcWXOzWJ6QjXOG44qfs-psl7Rkg=.57b33657-1b2c-4cca-a389-da8718d2da67@github.com>
Message-ID: <eWMS5OoN1UeEUcD3zlxb66nqGUXBZXzt7k9tsCty_Y8=.7dc14918-cdbc-45c9-be58-0cebea878a74@github.com>

On Thu, 5 Oct 2023 23:25:57 GMT, calnan <duke at openjdk.org> wrote:

>> Unlike for bugs, for enhancements the affectsversion is less relevant as vast majority will be fixed in a future release and will not be backported. There are situations where it is relevant, if the code is only in an LTS release for example.
>
> calnan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjusted reference to mainline

Marked as reviewed by jwilhelm (Lead).

-------------

PR Review: https://git.openjdk.org/guide/pull/115#pullrequestreview-1664936413

From iris at openjdk.org  Mon Oct  9 17:30:26 2023
From: iris at openjdk.org (Iris Clark)
Date: Mon, 9 Oct 2023 17:30:26 GMT
Subject: RFR: Clarified that for enhancements the affects version should
 normally be empty [v3]
In-Reply-To: <jnSiqRDJkTNsU71dbcWXOzWJ6QjXOG44qfs-psl7Rkg=.57b33657-1b2c-4cca-a389-da8718d2da67@github.com>
References: <4O2y2syF50lXarNEJIysGQDG-4bPiKUSK_Yv15FGyyM=.883c2e4c-1d72-431f-aca8-2d76e1ccea18@github.com>
 <jnSiqRDJkTNsU71dbcWXOzWJ6QjXOG44qfs-psl7Rkg=.57b33657-1b2c-4cca-a389-da8718d2da67@github.com>
Message-ID: <_FMb5vUcNEu1VOSjzm7bKZyV7Wah8RLnmz1GLhwVc90=.ef315f40-7546-451d-b2ab-64e30ff1f11c@github.com>

On Thu, 5 Oct 2023 23:25:57 GMT, calnan <duke at openjdk.org> wrote:

>> Unlike for bugs, for enhancements the affectsversion is less relevant as vast majority will be fixed in a future release and will not be backported. There are situations where it is relevant, if the code is only in an LTS release for example.
>
> calnan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjusted reference to mainline

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/guide/pull/115#pullrequestreview-1664982992

From duke at openjdk.org  Sat Oct 14 22:59:53 2023
From: duke at openjdk.org (calnan)
Date: Sat, 14 Oct 2023 22:59:53 GMT
Subject: Integrated: Clarified that for enhancements the affects version should
 normally be empty
In-Reply-To: <4O2y2syF50lXarNEJIysGQDG-4bPiKUSK_Yv15FGyyM=.883c2e4c-1d72-431f-aca8-2d76e1ccea18@github.com>
References: <4O2y2syF50lXarNEJIysGQDG-4bPiKUSK_Yv15FGyyM=.883c2e4c-1d72-431f-aca8-2d76e1ccea18@github.com>
Message-ID: <OAlVcaMc8IA2pGta17NSdPNaWGw0bU20Xdb11U5TTwo=.2a6b8dce-a8f9-41d3-a3b0-bd6d9eef19ed@github.com>

On Fri, 1 Sep 2023 03:40:05 GMT, calnan <duke at openjdk.org> wrote:

> Unlike for bugs, for enhancements the affectsversion is less relevant as vast majority will be fixed in a future release and will not be backported. There are situations where it is relevant, if the code is only in an LTS release for example.

This pull request has now been integrated.

Changeset: 1d84930f
Author:    roger_calnan <roger.calnan at oracle.com>
Committer: Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/1d84930fe4d3bdf0e6e4ad2892bf11814ac2df51
Stats:     4 lines in 1 file changed: 2 ins; 0 del; 2 mod

Clarified that for enhancements the affects version should normally be empty

Reviewed-by: jwilhelm, iris

-------------

PR: https://git.openjdk.org/guide/pull/115

From jwilhelm at openjdk.org  Tue Oct 17 21:48:48 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 17 Oct 2023 21:48:48 GMT
Subject: RFR: Minor bugfixes
Message-ID: <fz3QI5EZKZufNzptCIQZ7WtAvZW1hL0Y_gU9inRJKNE=.9a508cad-1871-4684-8443-85778890d851@github.com>

Fixes and a clarification.

-------------

Commit messages:
 - RN-MultipleLinks
 - Bug in code owners link
 - Missing top-link
 - Clarifications and bugfixes

Changes: https://git.openjdk.org/guide/pull/117/files
 Webrev: https://webrevs.openjdk.org/?repo=guide&pr=117&range=00
  Stats: 18 lines in 6 files changed: 9 ins; 3 del; 6 mod
  Patch: https://git.openjdk.org/guide/pull/117.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/117/head:pull/117

PR: https://git.openjdk.org/guide/pull/117

From iris at openjdk.org  Tue Oct 17 23:16:14 2023
From: iris at openjdk.org (Iris Clark)
Date: Tue, 17 Oct 2023 23:16:14 GMT
Subject: RFR: Minor bugfixes
In-Reply-To: <fz3QI5EZKZufNzptCIQZ7WtAvZW1hL0Y_gU9inRJKNE=.9a508cad-1871-4684-8443-85778890d851@github.com>
References: <fz3QI5EZKZufNzptCIQZ7WtAvZW1hL0Y_gU9inRJKNE=.9a508cad-1871-4684-8443-85778890d851@github.com>
Message-ID: <0002a6yaGpA8-ofKqlPigvl4cG17aqPgqOzsUkmv03E=.96e18fe9-91e4-4574-9563-2122a8c20b85@github.com>

On Tue, 17 Oct 2023 21:39:56 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Fixes and a clarification.

Nice tidy.

-------------

Marked as reviewed by iris (Reviewer).

PR Review: https://git.openjdk.org/guide/pull/117#pullrequestreview-1683620474

From jwilhelm at openjdk.org  Thu Oct 19 07:24:31 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 19 Oct 2023 07:24:31 GMT
Subject: Integrated: Minor bugfixes
In-Reply-To: <fz3QI5EZKZufNzptCIQZ7WtAvZW1hL0Y_gU9inRJKNE=.9a508cad-1871-4684-8443-85778890d851@github.com>
References: <fz3QI5EZKZufNzptCIQZ7WtAvZW1hL0Y_gU9inRJKNE=.9a508cad-1871-4684-8443-85778890d851@github.com>
Message-ID: <Y0XL7OfQGI2S5j15ortVF2boUpbmrShz6FewOmaDOOE=.b26c4469-ef83-440c-8576-5a1d95d96bb7@github.com>

On Tue, 17 Oct 2023 21:39:56 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Fixes and a clarification.

This pull request has now been integrated.

Changeset: 0eebc913
Author:    Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/0eebc913f3ba3d181faa7f5538d8f127d5e3e514
Stats:     18 lines in 6 files changed: 9 ins; 3 del; 6 mod

Minor bugfixes

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/guide/pull/117