RFR: Clarified that for enhancements the affects version should normally be empty [v2]
Jesper Wilhelmsson
jwilhelm at openjdk.org
Thu Oct 5 22:40:29 UTC 2023
On Mon, 4 Sep 2023 22:24:18 GMT, calnan <duke at openjdk.org> wrote:
>> Unlike for bugs, for enhancements the affectsversion is less relevant as vast majority will be fixed in a future release and will not be backported. There are situations where it is relevant, if the code is only in an LTS release for example.
>
> calnan has updated the pull request incrementally with one additional commit since the last revision:
>
> Adjusted the language about see if the issue is also related to the mainline, and also removed referenced to LTS releases.
Changes requested by jwilhelm (Lead).
src/guide/jbs-jdk-bug-system.md line 167:
> 165: 1. Ensure the [Affects Version/s]{.jbs-field} field is correct (within reason).
> 166: * This may involve reproducing the bug, if doing so is fast and easy.
> 167: * In addition to the version where the bug was found, take special care to also investigate if the bug affects the mainline.
I see "mainline" as a name rater than a thing, so I wouldn't have "the" in front of it in this sentence.
-------------
PR Review: https://git.openjdk.org/guide/pull/115#pullrequestreview-1660870751
PR Review Comment: https://git.openjdk.org/guide/pull/115#discussion_r1348071662
More information about the guide-dev
mailing list