RFR: Clarifications and X-wnf label [v4]
Jesper Wilhelmsson
jwilhelm at openjdk.org
Tue Feb 20 14:52:07 UTC 2024
On Mon, 29 Jan 2024 05:56:59 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed typos
>
> src/guide/jbs-jdk-bug-system.md line 352:
>
>> 350: The [Affects Version/s]{.jbs-field} field is used to indicate the releases where an issue has been seen - it's implied that the issue is also applicable to newer releases. Where this isn't the case - for instance a bug in code that was removed in *(Rel)* - then use *(Rel)*[-na]{.jbs-label} to indicate this. Note that there should only be **one** *(Rel)*[-na]{.jbs-label} label on any JBS issue. The label indicates the first known release where the issue is not present. If it's found that the issue is not present in an earlier release, change the label to indicate this.
>> 351:
>> 352: It's not recommended to specify update releases like 17u4 or 21u in the label. Please stick to labels like [17-na]{.jbs-label} and [21-na]{.jbs-label}.
>
> Again this can get a bit grey. Suppose an issue is present in 17 but not in 21+, and the change in 21 is then backported to 17uN. In that case putting 17-na would be very misleading as the bug is present in 17 (and 17uM M<N)
Not recommended doesn't mean it's forbidden. There will always be edge cases where what makes the most sense isn't necessarily the recommended way.
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/118#discussion_r1495953767
More information about the guide-dev
mailing list