RFR: clarify how to set the affects versions [v3]

Alexey Ivanov aivanov at openjdk.org
Tue Feb 27 14:24:59 UTC 2024


On Tue, 20 Feb 2024 17:47:14 GMT, calnan <duke at openjdk.org> wrote:

>> src/guide/jbs-jdk-bug-system.md line 213:
>> 
>>> 211:   * In addition to the version where the bug was found, take special care to also investigate if the bug affects mainline.
>>> 212:    * See [Indicating what releases an issue is applicable to](#indicating-what-releases-an-issue-is-applicable-to) for more details
>>> 213:   * For enhancements the [Affects Version]{.jbs-field} should be empty unless you feel that it is only relevant to a particular release family, and should not go into a future mainline release.
>> 
>> Suggestion:
>> 
>>   * For enhancements the [Affects Version]{.jbs-field} should be empty unless you feel that it is only relevant to a particular release family and should not go into a future mainline release.
>> 
>> I think the comma is not needed here: “…the Affects Version should be empty … and should not go …” — the verbs have the same subject.
>
> agreed

But the comma is still there.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/119#discussion_r1504314371


More information about the guide-dev mailing list