RFR: Changes due to stabilization branches [v2]
Kevin Rushforth
kcr at openjdk.org
Wed Jun 5 12:44:10 UTC 2024
On Wed, 5 Jun 2024 01:26:18 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Updates after reviews
>
> src/guide/cloning-the-jdk.md line 56:
>
>> 54: If you intend to work on a backport to a feature release stabilization branch, your new local branch should of course be based on the stabilization branch instead of `master`.
>> 55:
>> 56: $ git switch -c JDK-8272373 origin/jdk23u
>
> As a follow-up, that should be `jdk23` not `jdk23u` -- there is no `jdk23u` branch (that's still a separate repo and for update releases).
Also, by basing it on `origin/jdk23` it will set the newly create branch to track that branch, such that `git push` with no additional args will push to `origin/jdk23`. I think the example should remove the `origin/` and just be:
$ git switch -c JDK-8272373 jdk23
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/123#discussion_r1627686748
More information about the guide-dev
mailing list