RFR: Section on sponsoring [v12]

Kevin Rushforth kcr at openjdk.org
Wed Jun 5 19:56:09 UTC 2024


On Wed, 21 Feb 2024 09:43:16 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Copied and updated the text from the old sponsoring page: https://openjdk.org/sponsor/
>> The purpose is to have the sponsor link on the OpenJDK page lead here instead.
>> 
>> Also updated the contributing section with some parts taken from the old contributing page: https://openjdk.org/contribute/
>> Again, the intention is to change the link on the OpenJDK page to lead here.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Separate email thread

src/guide/reviewing-and-sponsoring-a-change.md line 13:

> 11: If you are new to an area, reviewing changes is also a great way to learn the code and see what general styles and types of changes that are relevant in the area. Be mindful though, if you don't know the area well you should state this in your review comments. As a **R**eviewer you have a responsibility to make sure changes are sound and aline with the general direction of the area. If you, as a **R**eviever, review a change in an area that you don't know well you probably shouldn't be the one to approve the change.
> 12: 
> 13: New developers in the OpenJDK community don't have the permissions needed to push changes to the repositories. This is a feature that ensures that all developers get familiar with the code, processes, and community before being allowed to actually make changes. To get their first changes in, the new Contributor needs the help of a Sponsor. The Sponsor's role is to offer constructive advice and eventually integrate the sponsored contribution into the repository.

Suggestion: "push changes" --> "integrate changes" (not even experienced Reviewers can directly push changes)

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/97#discussion_r1627675176


More information about the guide-dev mailing list