RFR: More information on fix version usage [v3]

Jesper Wilhelmsson jwilhelm at openjdk.org
Tue Jun 18 21:57:36 UTC 2024


On Tue, 18 Jun 2024 19:43:41 GMT, Roger Calnan <duke at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixes after review
>
> src/guide/jbs-jdk-bug-system.md line 265:
> 
>> 263: Once the work on an issue has been completed the issues [Status]{.jbs-field} should be in a "completed" state. There are two "completed" states: [Resolved]{.jbs-value} and [Closed]{.jbs-value}. These are accompanied by a [Resolution]{.jbs-field} and a [Fix Version/s]{.jbs-value}. Which combination of [Status]{.jbs-field}, [Resolution]{.jbs-field}, and [Fix Version/s]{.jbs-value} you should use depends on how the issue is completed.
>> 264: 
>> 265: Most resolutions are used to close an issue so that it ends up being [Closed]{.jbs-value} directly, but resolutions that indicates that a change has been integrated into a Project repository must go through the [Resolved]{.jbs-value} state. An issue in [Resolved]{.jbs-value} state needs to go through [verification](#verifying-an-issue) to end up as [Closed]{.jbs-value}. For the JDK project in almost all cases the bots will transition the issue to [Resolved]{.jbs-value}/[Fixed]{.jbs-value} when the changeset is integrated to the repository.
> 
> "needs to go through"
> is it more "may go through"?

Well, it may to through verification, but it needs to go through verification to end up as Closed. I guess both works. I have no strong opinion.

> src/guide/jbs-jdk-bug-system.md line 267:
> 
>> 265: Most resolutions are used to close an issue so that it ends up being [Closed]{.jbs-value} directly, but resolutions that indicates that a change has been integrated into a Project repository must go through the [Resolved]{.jbs-value} state. An issue in [Resolved]{.jbs-value} state needs to go through [verification](#verifying-an-issue) to end up as [Closed]{.jbs-value}. For the JDK project in almost all cases the bots will transition the issue to [Resolved]{.jbs-value}/[Fixed]{.jbs-value} when the changeset is integrated to the repository.
>> 266: 
>> 267: The [Fix Version/s]{.jbs-field} field should indicate when an issue was fixed. The most common value for this field is a JDK version number. There are some special values available for this field in JBS, these should only be used is special cases as outlined in this Guide.
> 
> for special cases that are outlined in this Guide

Fixed.

> src/guide/jbs-jdk-bug-system.md line 312:
> 
>> 310: 
>> 311: ::: {.note}
>> 312: Be mindful of labels on issues closed as [Duplicate]{.jbs-value}. Some labels needs to be copied over to the duplicating issue, see for instance the [[tck-red-]{.jbs-label}*(Rel)*](#tck-red-rel) label.
> 
> Some labels need (no s)

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/128#discussion_r1645140400
PR Review Comment: https://git.openjdk.org/guide/pull/128#discussion_r1645141067
PR Review Comment: https://git.openjdk.org/guide/pull/128#discussion_r1645141007


More information about the guide-dev mailing list