RFR: More information on fix version usage [v3]

Kim Barrett kbarrett at openjdk.org
Tue Jun 25 01:13:21 UTC 2024


On Tue, 18 Jun 2024 21:57:35 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Added more information on how to set fix version when closing an issue.
>> Also fixed some broken links.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixes after review

Not a review, just a couple small grammar nits in passing.

src/guide/jbs-jdk-bug-system.md line 264:

> 262: ## Resolving or Closing an issue
> 263: 
> 264: Once the work on an issue has been completed the issues [Status]{.jbs-field} should be in a "completed" state. There are two "completed" states: [Resolved]{.jbs-value} and [Closed]{.jbs-value}. These are accompanied by a [Resolution]{.jbs-field} and a [Fix Version/s]{.jbs-value}. Which combination of [Status]{.jbs-field}, [Resolution]{.jbs-field}, and [Fix Version/s]{.jbs-value} you should use depends on how the issue is completed.

s/the issues/the issue's/

src/guide/jbs-jdk-bug-system.md line 297:

> 295: 
> 296: :::{.note}
> 297: The fix version [na]{.jbs-value} should only be used on backport issues that was created by mistake. See [How to fix an incorrect backport creation in JBS].

Inconsistent tense in "issues that was".

-------------

PR Review: https://git.openjdk.org/guide/pull/128#pullrequestreview-2137070736
PR Review Comment: https://git.openjdk.org/guide/pull/128#discussion_r1651821103
PR Review Comment: https://git.openjdk.org/guide/pull/128#discussion_r1651825850


More information about the guide-dev mailing list