RFR: Backporting related changes [v2]

Jesper Wilhelmsson jwilhelm at openjdk.org
Thu Jun 27 11:01:48 UTC 2024


On Thu, 27 Jun 2024 05:38:17 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed review comments
>
> src/guide/backporting.md line 32:
> 
>> 30: Testing each individual change is more likely to find issues than just testing the single merged change. It's also easier and less error prone to use the `/backport` command on each commit instead of manually cherrypick and deal with the merges etc.
>> 31: 
>> 32: And finally, if backporting each commit individually, the JBS records will clearly indicate that the followup changes has been backported as well. This is important as there is tooling that verifies that everything is done in the right way. That tooling will be confused if it can't deduct from JBS what has happened.
> 
> Suggestion:
> 
> And finally, if backporting each commit individually, the JBS records will clearly indicate that the followup changes have been backported as well. This is important as there is tooling that verifies that everything is done in the right way. That tooling will be confused if it can't deduct from JBS what has happened.

Good catch! Fixed.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/129#discussion_r1656933567


More information about the guide-dev mailing list