RFR: clarify how to set the affects versions [v5]
calnan
duke at openjdk.org
Fri Mar 1 13:57:54 UTC 2024
On Thu, 29 Feb 2024 10:03:23 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> updates from feedback
>
> src/guide/jbs-jdk-bug-system.md line 106:
>
>> 104:
>> 105: - use the label to indicate that a bug is not relevant to an earlier release, for example<br>[Affects Version]{.jbs-field}: [11.0.20]{.jbs-value}, [17]{.jbs-value}<br> the label [8-na]{.jbs-label} would not be needed - as it doesn't have a JDK 8 release, or earlier, value in the [Affects Versions]{.jbs-field}, it is not relevant to JDK 8.
>> 106: - add multiple [-na]{.jbs-label} labels: you only need one, for don't add both [9-na]{.jbs-label} and [11-na]{.jbs-label} — [9-na]{.jbs-label} implies all following releases therefore [11-na]{.jbs-label}, [17-na]{.jbs-label} etc. is not needed.
>
> Suggestion:
>
> - add multiple [-na]{.jbs-label} labels: you only need one, for example don't add both [9-na]{.jbs-label} and [11-na]{.jbs-label} — [9-na]{.jbs-label} implies all following releases therefore [11-na]{.jbs-label}, [17-na]{.jbs-label} etc. is not needed.
>
> The word “example” disappeared.
>
> I'd use “11-na, 17-na etc. _are_ not needed” to emphasise the fact there are two labels which serve as the subject of the sentence.
fixed
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/119#discussion_r1509046648
More information about the guide-dev
mailing list