RFR: Updated codeowners [v2]
Jesper Wilhelmsson
jwilhelm at openjdk.org
Thu Mar 21 17:56:50 UTC 2024
On Sat, 24 Feb 2024 07:38:37 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed review comments.
>
> src/guide/code-owners.md line 73:
>
>> 71: * [foreign](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/foreign) - Core Libs
>> 72: * [icu](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/icu) - Core Libs
>> 73: * [io](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/io) - NIO
>
> This should be Core Libs, not NIO.
Fixed.
> src/guide/code-owners.md line 75:
>
>> 73: * [io](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/io) - NIO
>> 74: * [javac](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/javac) - Java Language (javac)
>> 75: * [jimage](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/jimage) - Client Libs
>
> This should Core Libs, not Client Libs.
Fixed.
> src/guide/code-owners.md line 76:
>
>> 74: * [javac](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/javac) - Java Language (javac)
>> 75: * [jimage](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/jimage) - Client Libs
>> 76: * [jmod](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/jmod) - HotSpot
>
> This should be Core Libs.
Fixed.
> src/guide/code-owners.md line 94:
>
>> 92: * [vm](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/jdk/internal/vm) - HotSpot
>> 93: * [invoke](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/sun/invoke) - Core Libs
>> 94: * [[share](https://github.com/openjdk/jdk/tree/master/java.base/share/classes/java/io), [sun](https://github.com/openjdk/jdk/tree/master/java.base/windows/classes/sun/io), [unix](https://github.com/openjdk/jdk/tree/master/java.base/unix/classes/java/io)]/io - NIO
>
> This should be Core Libs.
Fixed.
> src/guide/code-owners.md line 99:
>
>> 97: * [math](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/java/math) - Core Libs
>> 98: * [time](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/java/time) - Core Libs
>> 99: * [launcher](https://github.com/openjdk/jdk/tree/master/src/java.base/share/classes/sun/launcher) - Tools
>
> That may be where the historical ownership was but any changes to the launcher tend to be discussed/reviews on core-libs so probably better to change this owner.
Added Core-Libs.
> src/guide/code-owners.md line 122:
>
>> 120: * [[aix](https://github.com/openjdk/jdk/tree/master/java.base/aix/native/libjava), [linux](https://github.com/openjdk/jdk/tree/master/java.base/linux/native/libjava), [macosx](https://github.com/openjdk/jdk/tree/master/java.base/macosx/native/libjava), [share](https://github.com/openjdk/jdk/tree/master/java.base/share/native/libjava), [unix](https://github.com/openjdk/jdk/tree/master/java.base/unix/native/libjava), [windows](https://github.com/openjdk/jdk/tree/master/java.base/windows/native/libjava)]/libjava - Core Libs
>> 121: * [[share](https://github.com/openjdk/jdk/tree/master/java.base/share/native/libjimage), [unix](https://github.com/openjdk/jdk/tree/master/java.base/unix/native/libjimage), [windows](https://github.com/openjdk/jdk/tree/master/java.base/windows/native/libjimage)]/libjimage - Core Libs
>> 122: * [[aix](https://github.com/openjdk/jdk/tree/master/java.base/aix/native/libjli), [macosx](https://github.com/openjdk/jdk/tree/master/java.base/macosx/native/libjli), [share](https://github.com/openjdk/jdk/tree/master/java.base/share/native/libjli), [unix](https://github.com/openjdk/jdk/tree/master/java.base/unix/native/libjli), [windows](https://github.com/openjdk/jdk/tree/master/java.base/windows/native/libjli)]/libjli - Tools
>
> "jli" = Java launcher infrastructure so should have same owner as java launcher.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/120#discussion_r1534367750
PR Review Comment: https://git.openjdk.org/guide/pull/120#discussion_r1534367891
PR Review Comment: https://git.openjdk.org/guide/pull/120#discussion_r1534368035
PR Review Comment: https://git.openjdk.org/guide/pull/120#discussion_r1534368142
PR Review Comment: https://git.openjdk.org/guide/pull/120#discussion_r1534368301
PR Review Comment: https://git.openjdk.org/guide/pull/120#discussion_r1534368434
More information about the guide-dev
mailing list