From jwilhelm at openjdk.org  Wed Apr  2 22:33:06 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 2 Apr 2025 22:33:06 GMT
Subject: RFR: Replace affects_versions.png with SVG [v3]
In-Reply-To: <GN8fTaIKCiP_8KrwC-PWdIAIiS8C9v8t-ZlVAA87Ws8=.676e48f9-88c0-4738-bf70-19acefc3191a@github.com>
References: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com>
 <GN8fTaIKCiP_8KrwC-PWdIAIiS8C9v8t-ZlVAA87Ws8=.676e48f9-88c0-4738-bf70-19acefc3191a@github.com>
Message-ID: <EDoQsIxxEhlv_S4u9oENpdUEqohP9DLp_jFl7e28NaQ=.8db23b95-81ed-44dd-a8bc-31f127c1491e@github.com>

On Thu, 20 Mar 2025 17:07:12 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Replace `affects_versions.png` with Scalable Vector Graphics (SVG) image.
>> 
>> <details>
>> <summary>PNG vs SVG</summary>
>> 
>> **PNG:**\
>> ![affects_versions.png](https://github.com/openjdk/guide/blob/be88a6debcb0dfb7f8fb0e8f3e95ff35950ca9c4/src/images/affects_versions.png?raw=true)
>> 
>> **SVG:**\
>> ![affects_versions.svg](https://raw.githubusercontent.com/aivanov-jdk/dev-guide/bc65ea67251cc68360fc746a77200d8c93fd78b5/src/images/affects_versions.svg)
>> </details>
>> 
>> SVG is crisper, especially on High DPI monitors, its size is much smaller (1.04&nbsp;KB vs 26.24&nbsp;KB), it's easier to edit and the edit history is preserved.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   End 12-na with circle

Marked as reviewed by jwilhelm (Lead).

-------------

PR Review: https://git.openjdk.org/guide/pull/147#pullrequestreview-2737739251

From iris at openjdk.org  Wed Apr  2 23:00:00 2025
From: iris at openjdk.org (Iris Clark)
Date: Wed, 2 Apr 2025 23:00:00 GMT
Subject: RFR: Replace affects_versions.png with SVG [v3]
In-Reply-To: <GN8fTaIKCiP_8KrwC-PWdIAIiS8C9v8t-ZlVAA87Ws8=.676e48f9-88c0-4738-bf70-19acefc3191a@github.com>
References: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com>
 <GN8fTaIKCiP_8KrwC-PWdIAIiS8C9v8t-ZlVAA87Ws8=.676e48f9-88c0-4738-bf70-19acefc3191a@github.com>
Message-ID: <60JjthnWHr75bzcgx0hREMQoHFIsPx9dJhsZ2BuJbp8=.17745d07-f4a7-4849-9540-866344fba221@github.com>

On Thu, 20 Mar 2025 17:07:12 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Replace `affects_versions.png` with Scalable Vector Graphics (SVG) image.
>> 
>> <details>
>> <summary>PNG vs SVG</summary>
>> 
>> **PNG:**\
>> ![affects_versions.png](https://github.com/openjdk/guide/blob/be88a6debcb0dfb7f8fb0e8f3e95ff35950ca9c4/src/images/affects_versions.png?raw=true)
>> 
>> **SVG:**\
>> ![affects_versions.svg](https://raw.githubusercontent.com/aivanov-jdk/dev-guide/bc65ea67251cc68360fc746a77200d8c93fd78b5/src/images/affects_versions.svg)
>> </details>
>> 
>> SVG is crisper, especially on High DPI monitors, its size is much smaller (1.04&nbsp;KB vs 26.24&nbsp;KB), it's easier to edit and the edit history is preserved.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   End 12-na with circle

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/guide/pull/147#pullrequestreview-2737775809

From duke at openjdk.org  Thu Apr  3 11:44:14 2025
From: duke at openjdk.org (duke)
Date: Thu, 3 Apr 2025 11:44:14 GMT
Subject: RFR: Replace affects_versions.png with SVG [v3]
In-Reply-To: <GN8fTaIKCiP_8KrwC-PWdIAIiS8C9v8t-ZlVAA87Ws8=.676e48f9-88c0-4738-bf70-19acefc3191a@github.com>
References: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com>
 <GN8fTaIKCiP_8KrwC-PWdIAIiS8C9v8t-ZlVAA87Ws8=.676e48f9-88c0-4738-bf70-19acefc3191a@github.com>
Message-ID: <-xQYz9RbpT66Rv8YcZik_CYdK5Ey9VGVHiKH3tVjq-0=.f6e3c363-0cc7-4bb7-8f69-588994565e8a@github.com>

On Thu, 20 Mar 2025 17:07:12 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Replace `affects_versions.png` with Scalable Vector Graphics (SVG) image.
>> 
>> <details>
>> <summary>PNG vs SVG</summary>
>> 
>> **PNG:**\
>> ![affects_versions.png](https://github.com/openjdk/guide/blob/be88a6debcb0dfb7f8fb0e8f3e95ff35950ca9c4/src/images/affects_versions.png?raw=true)
>> 
>> **SVG:**\
>> ![affects_versions.svg](https://raw.githubusercontent.com/aivanov-jdk/dev-guide/bc65ea67251cc68360fc746a77200d8c93fd78b5/src/images/affects_versions.svg)
>> </details>
>> 
>> SVG is crisper, especially on High DPI monitors, its size is much smaller (1.04&nbsp;KB vs 26.24&nbsp;KB), it's easier to edit and the edit history is preserved.
>
> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   End 12-na with circle

@aivanov-jdk 
Your change (at version c48bff06cc94e1b55b9db68257b2a2d9f85a9fef) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/guide/pull/147#issuecomment-2775484994

From smarks at openjdk.org  Wed Apr  9 21:32:53 2025
From: smarks at openjdk.org (Stuart Marks)
Date: Wed, 9 Apr 2025 21:32:53 GMT
Subject: RFR: Add material about updating the CSR when a backout occurs.
Message-ID: <vH16xaV_kZ9X0vn7o3mKR-SV2bYsmFJqc_fzmz1WD2E=.04fda4a4-998b-412e-9157-9636de533dc3@github.com>

Also, add a small fix to the Makefile.

-------------

Commit messages:
 - Add material about updating the CSR when a backout occurs.

Changes: https://git.openjdk.org/guide/pull/148/files
  Webrev: https://webrevs.openjdk.org/?repo=guide&pr=148&range=00
  Stats: 6 lines in 2 files changed: 5 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/148.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/148/head:pull/148

PR: https://git.openjdk.org/guide/pull/148

From jwilhelm at openjdk.org  Wed Apr  9 21:52:39 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 9 Apr 2025 21:52:39 GMT
Subject: RFR: Add material about updating the CSR when a backout occurs.
In-Reply-To: <vH16xaV_kZ9X0vn7o3mKR-SV2bYsmFJqc_fzmz1WD2E=.04fda4a4-998b-412e-9157-9636de533dc3@github.com>
References: <vH16xaV_kZ9X0vn7o3mKR-SV2bYsmFJqc_fzmz1WD2E=.04fda4a4-998b-412e-9157-9636de533dc3@github.com>
Message-ID: <bCEk51MR5BEfaWxBYy9vD8Np9cBm2JXX2rvUepXmreo=.eb1ba06e-4a7b-4b30-8b7e-dcf46d92fc3b@github.com>

On Wed, 9 Apr 2025 21:28:38 GMT, Stuart Marks <smarks at openjdk.org> wrote:

> Also, add a small fix to the Makefile.

Thank you for adding this! Looks good!

src/guide/testing-the-jdk.md line 339:

> 337: 
> 338: To backout a change with git, use `git revert`. This will apply (commit) the anti-delta of the change.
> 339: Then proceed as usual with creating a PR and getting it reviewed.

For consistency I'd prefer if this sentence was on the same line as the previous, since this is not a new paragraph. Not critical, but if you have the extra time :-)

-------------

Marked as reviewed by jwilhelm (Lead).

PR Review: https://git.openjdk.org/guide/pull/148#pullrequestreview-2754882687
PR Review Comment: https://git.openjdk.org/guide/pull/148#discussion_r2036187238

From aivanov at openjdk.org  Wed Apr  9 21:56:42 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 9 Apr 2025 21:56:42 GMT
Subject: Integrated: Replace affects_versions.png with SVG
In-Reply-To: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com>
References: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com>
Message-ID: <8jp4BQVcvBnyJ6s0J-A0vr16cinWh2ZAU3MjDYa7hi0=.213a87e8-c491-4e8f-a299-1da812614b49@github.com>

On Fri, 14 Mar 2025 16:04:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Replace `affects_versions.png` with Scalable Vector Graphics (SVG) image.
> 
> <details>
> <summary>PNG vs SVG</summary>
> 
> **PNG:**\
> ![affects_versions.png](https://github.com/openjdk/guide/blob/be88a6debcb0dfb7f8fb0e8f3e95ff35950ca9c4/src/images/affects_versions.png?raw=true)
> 
> **SVG:**\
> ![affects_versions.svg](https://raw.githubusercontent.com/aivanov-jdk/dev-guide/bc65ea67251cc68360fc746a77200d8c93fd78b5/src/images/affects_versions.svg)
> </details>
> 
> SVG is crisper, especially on High DPI monitors, its size is much smaller (1.04&nbsp;KB vs 26.24&nbsp;KB), it's easier to edit and the edit history is preserved.

This pull request has now been integrated.

Changeset: b10cd0da
Author:    Alexey Ivanov <aivanov at openjdk.org>
Committer: Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/b10cd0da8178361841861a24dee0711204883ef8
Stats:     164 lines in 3 files changed: 163 ins; 0 del; 1 mod

Replace affects_versions.png with SVG

Reviewed-by: ihse, jwilhelm, iris

-------------

PR: https://git.openjdk.org/guide/pull/147

From smarks at openjdk.org  Wed Apr  9 21:58:52 2025
From: smarks at openjdk.org (Stuart Marks)
Date: Wed, 9 Apr 2025 21:58:52 GMT
Subject: RFR: Add material about updating the CSR when a backout occurs.
 [v2]
In-Reply-To: <vH16xaV_kZ9X0vn7o3mKR-SV2bYsmFJqc_fzmz1WD2E=.04fda4a4-998b-412e-9157-9636de533dc3@github.com>
References: <vH16xaV_kZ9X0vn7o3mKR-SV2bYsmFJqc_fzmz1WD2E=.04fda4a4-998b-412e-9157-9636de533dc3@github.com>
Message-ID: <oKLVLYaopDJ4K5oV_fhP0NrLxMXGbduY-X-Y1aGE8vE=.5681c470-19b5-4082-ad85-85797a6217f1@github.com>

> Also, add a small fix to the Makefile.

Stuart Marks has updated the pull request incrementally with one additional commit since the last revision:

  Keep paragraph as a single line (per Jesper).

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/148/files
  - new: https://git.openjdk.org/guide/pull/148/files/a9f26da3..cfdad340

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=148&range=01
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=148&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/148.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/148/head:pull/148

PR: https://git.openjdk.org/guide/pull/148

From smarks at openjdk.org  Wed Apr  9 21:58:52 2025
From: smarks at openjdk.org (Stuart Marks)
Date: Wed, 9 Apr 2025 21:58:52 GMT
Subject: RFR: Add material about updating the CSR when a backout occurs.
 [v2]
In-Reply-To: <bCEk51MR5BEfaWxBYy9vD8Np9cBm2JXX2rvUepXmreo=.eb1ba06e-4a7b-4b30-8b7e-dcf46d92fc3b@github.com>
References: <vH16xaV_kZ9X0vn7o3mKR-SV2bYsmFJqc_fzmz1WD2E=.04fda4a4-998b-412e-9157-9636de533dc3@github.com>
 <bCEk51MR5BEfaWxBYy9vD8Np9cBm2JXX2rvUepXmreo=.eb1ba06e-4a7b-4b30-8b7e-dcf46d92fc3b@github.com>
Message-ID: <gttb60qh8aUNEjBU2sYuLfV_G93A7Vq-7bfjDJJtZZ4=.2ca88aff-7ea6-41aa-a1e3-fc540bacebcb@github.com>

On Wed, 9 Apr 2025 21:49:25 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Stuart Marks has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Keep paragraph as a single line (per Jesper).
>
> src/guide/testing-the-jdk.md line 339:
> 
>> 337: 
>> 338: To backout a change with git, use `git revert`. This will apply (commit) the anti-delta of the change.
>> 339: Then proceed as usual with creating a PR and getting it reviewed.
> 
> For consistency I'd prefer if this sentence was on the same line as the previous, since this is not a new paragraph. Not critical, but if you have the extra time :-)

Can do. I want to wait for a review from @jddarcy as well.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/148#discussion_r2036190058

From darcy at openjdk.org  Wed Apr  9 22:05:48 2025
From: darcy at openjdk.org (Joe Darcy)
Date: Wed, 9 Apr 2025 22:05:48 GMT
Subject: RFR: Add material about updating the CSR when a backout occurs.
 [v2]
In-Reply-To: <oKLVLYaopDJ4K5oV_fhP0NrLxMXGbduY-X-Y1aGE8vE=.5681c470-19b5-4082-ad85-85797a6217f1@github.com>
References: <vH16xaV_kZ9X0vn7o3mKR-SV2bYsmFJqc_fzmz1WD2E=.04fda4a4-998b-412e-9157-9636de533dc3@github.com>
 <oKLVLYaopDJ4K5oV_fhP0NrLxMXGbduY-X-Y1aGE8vE=.5681c470-19b5-4082-ad85-85797a6217f1@github.com>
Message-ID: <FdEDUBUtnAGRzjXOwqO7NRqLlTmSgxIruXFGhzUEFPE=.557a1ed3-8ccb-46ba-8922-7515342844a6@github.com>

On Wed, 9 Apr 2025 21:58:52 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> Also, add a small fix to the Makefile.
>
> Stuart Marks has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Keep paragraph as a single line (per Jesper).

Marked as reviewed by darcy (Committer).

-------------

PR Review: https://git.openjdk.org/guide/pull/148#pullrequestreview-2754900744

From liach at openjdk.org  Wed Apr  9 22:08:45 2025
From: liach at openjdk.org (Chen Liang)
Date: Wed, 9 Apr 2025 22:08:45 GMT
Subject: RFR: Add material about updating the CSR when a backout occurs.
 [v2]
In-Reply-To: <oKLVLYaopDJ4K5oV_fhP0NrLxMXGbduY-X-Y1aGE8vE=.5681c470-19b5-4082-ad85-85797a6217f1@github.com>
References: <vH16xaV_kZ9X0vn7o3mKR-SV2bYsmFJqc_fzmz1WD2E=.04fda4a4-998b-412e-9157-9636de533dc3@github.com>
 <oKLVLYaopDJ4K5oV_fhP0NrLxMXGbduY-X-Y1aGE8vE=.5681c470-19b5-4082-ad85-85797a6217f1@github.com>
Message-ID: <fOF3L6bwvjUS874007y8oYg4bIs13WiKKbE21ussFWY=.94bb7e69-203c-4f1f-906c-5be55df568a4@github.com>

On Wed, 9 Apr 2025 21:58:52 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> Also, add a small fix to the Makefile.
>
> Stuart Marks has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Keep paragraph as a single line (per Jesper).

Marked as reviewed by liach (no project role).

-------------

PR Review: https://git.openjdk.org/guide/pull/148#pullrequestreview-2754904425

From smarks at openjdk.org  Wed Apr  9 22:26:41 2025
From: smarks at openjdk.org (Stuart Marks)
Date: Wed, 9 Apr 2025 22:26:41 GMT
Subject: Integrated: Add material about updating the CSR when a backout occurs.
In-Reply-To: <vH16xaV_kZ9X0vn7o3mKR-SV2bYsmFJqc_fzmz1WD2E=.04fda4a4-998b-412e-9157-9636de533dc3@github.com>
References: <vH16xaV_kZ9X0vn7o3mKR-SV2bYsmFJqc_fzmz1WD2E=.04fda4a4-998b-412e-9157-9636de533dc3@github.com>
Message-ID: <jY2hka7evMM4dgA1zXofvUfPPZtM8Od7XUzH5SAB4pg=.1febf035-a48c-4f43-8079-aab4cc3f80d9@github.com>

On Wed, 9 Apr 2025 21:28:38 GMT, Stuart Marks <smarks at openjdk.org> wrote:

> Also, add a small fix to the Makefile.

This pull request has now been integrated.

Changeset: 71fbb94b
Author:    Stuart Marks <smarks at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/71fbb94b0b7b3ca75869bc158805971a3fe3d3df
Stats:     6 lines in 2 files changed: 4 ins; 0 del; 2 mod

Add material about updating the CSR when a backout occurs.

Reviewed-by: jwilhelm, darcy, liach

-------------

PR: https://git.openjdk.org/guide/pull/148