From jwilhelm at openjdk.org  Fri Aug  1 15:37:10 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 1 Aug 2025 15:37:10 GMT
Subject: RFR: Update affects_versions.svg [v2]
In-Reply-To: <_Tie0Qp0BAy1EdHCODFIRtIIXqAqJAsJTDG2oGCV_5M=.24310486-c4cc-4caf-bbdf-2aab7b0ea119@github.com>
References: <QGQ6vxljnyw1Lw85qNNm_PkHhFmRwJ0wuBq1clSUOZk=.90624cc3-ac51-449c-80fa-44bc0fb2e846@github.com>
 <_Tie0Qp0BAy1EdHCODFIRtIIXqAqJAsJTDG2oGCV_5M=.24310486-c4cc-4caf-bbdf-2aab7b0ea119@github.com>
Message-ID: <2nmPCnQh-bTCUrQc4qbftxmY87Xl5QnQ4xVPCpU9a78=.3c9ebe89-2262-4534-92c4-d9f410fe3de7@github.com>

On Thu, 31 Jul 2025 16:58:26 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Update `affects_versions.svg` as per discussion in #149.
>> 
>> 1. Make the arrows look better, narrower;
>> 2. Put red cross for version 8 in the case 5 to make it explicit the issue won't be backported to both 11u and 8u;
>> 3. Move all text a few pixels down, closer to the timeline;
>> 4. Left-align `12-na` and `11-wnf` in cases 4 and 5 and display closer to 11 LTS line;
>> 5. Reduce the circle radius for where an issue is fixed;
>> 6. Mark-up 8 as LTS (displayed in bold).
>
> Alexey Ivanov has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Move timeline version numbers even closer
>  - Move timeline version numbers close to timeline lines

Looks good!

-------------

Marked as reviewed by jwilhelm (Lead).

PR Review: https://git.openjdk.org/guide/pull/153#pullrequestreview-3079679211

From duke at openjdk.org  Fri Aug  1 16:17:17 2025
From: duke at openjdk.org (duke)
Date: Fri, 1 Aug 2025 16:17:17 GMT
Subject: RFR: Update affects_versions.svg [v2]
In-Reply-To: <_Tie0Qp0BAy1EdHCODFIRtIIXqAqJAsJTDG2oGCV_5M=.24310486-c4cc-4caf-bbdf-2aab7b0ea119@github.com>
References: <QGQ6vxljnyw1Lw85qNNm_PkHhFmRwJ0wuBq1clSUOZk=.90624cc3-ac51-449c-80fa-44bc0fb2e846@github.com>
 <_Tie0Qp0BAy1EdHCODFIRtIIXqAqJAsJTDG2oGCV_5M=.24310486-c4cc-4caf-bbdf-2aab7b0ea119@github.com>
Message-ID: <HY6Bq2G-moRGa6RICcWZHUM3QDGp8q7bd3ePIpAAtn0=.83307761-2f37-48b1-95ae-5fe1fff587c3@github.com>

On Thu, 31 Jul 2025 16:58:26 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Update `affects_versions.svg` as per discussion in #149.
>> 
>> 1. Make the arrows look better, narrower;
>> 2. Put red cross for version 8 in the case 5 to make it explicit the issue won't be backported to both 11u and 8u;
>> 3. Move all text a few pixels down, closer to the timeline;
>> 4. Left-align `12-na` and `11-wnf` in cases 4 and 5 and display closer to 11 LTS line;
>> 5. Reduce the circle radius for where an issue is fixed;
>> 6. Mark-up 8 as LTS (displayed in bold).
>
> Alexey Ivanov has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Move timeline version numbers even closer
>  - Move timeline version numbers close to timeline lines

@aivanov-jdk 
Your change (at version 4ef7b8176c62e801142a6832d6a8d354aac3cf33) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/guide/pull/153#issuecomment-3145093858

From aivanov at openjdk.org  Fri Aug  1 16:34:11 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 1 Aug 2025 16:34:11 GMT
Subject: Integrated: Update affects_versions.svg
In-Reply-To: <QGQ6vxljnyw1Lw85qNNm_PkHhFmRwJ0wuBq1clSUOZk=.90624cc3-ac51-449c-80fa-44bc0fb2e846@github.com>
References: <QGQ6vxljnyw1Lw85qNNm_PkHhFmRwJ0wuBq1clSUOZk=.90624cc3-ac51-449c-80fa-44bc0fb2e846@github.com>
Message-ID: <B9r5X02tM6hIw-WqXAYU0oMjTiqRYjMVlXdfXoPzzOU=.94b67145-90dd-4eb3-a51e-f30cdbb7ce36@github.com>

On Thu, 31 Jul 2025 16:46:00 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Update `affects_versions.svg` as per discussion in #149.
> 
> 1. Make the arrows look better, narrower;
> 2. Put red cross for version 8 in the case 5 to make it explicit the issue won't be backported to both 11u and 8u;
> 3. Move all text a few pixels down, closer to the timeline;
> 4. Left-align `12-na` and `11-wnf` in cases 4 and 5 and display closer to 11 LTS line;
> 5. Reduce the circle radius for where an issue is fixed;
> 6. Mark-up 8 as LTS (displayed in bold).

This pull request has now been integrated.

Changeset: 74b90e8e
Author:    Alexey Ivanov <aivanov at openjdk.org>
Committer: Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/74b90e8e49067aa1e35834c0dc63b9e7b341f5fe
Stats:     19 lines in 1 file changed: 5 ins; 0 del; 14 mod

Update affects_versions.svg

Reviewed-by: jwilhelm

-------------

PR: https://git.openjdk.org/guide/pull/153

From aivanov at openjdk.org  Fri Aug  1 16:54:20 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 1 Aug 2025 16:54:20 GMT
Subject: RFR: Update mailman address
Message-ID: <Bo15SeZ0Stk3x93-didZjdIBRdatbdyTP60PnbaxExo=.ed30ffc3-6888-4bbe-96ee-e0af1f45f3c5@github.com>

Recently, a person sent an email to `mailman-at-openjdk.org` to change the email address as mentioned in the Guide, yet the email was rejected. The rejection email contained another address `mailman-owner-at-openjdk.org` that worked well. Therefore, I suggest updating the mail-man address in the Guide.

I also replaced ?discussions _around_? with ?discussions _about_?. This is how mailing lists are described on the page that lists all available OpenJDK mailing lists.

-------------

Commit messages:
 - Update mailman address

Changes: https://git.openjdk.org/guide/pull/154/files
  Webrev: https://webrevs.openjdk.org/?repo=guide&pr=154&range=00
  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/guide/pull/154.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/154/head:pull/154

PR: https://git.openjdk.org/guide/pull/154

From jwilhelm at openjdk.org  Sat Aug  2 17:55:08 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Sat, 2 Aug 2025 17:55:08 GMT
Subject: RFR: Update mailman address
In-Reply-To: <Bo15SeZ0Stk3x93-didZjdIBRdatbdyTP60PnbaxExo=.ed30ffc3-6888-4bbe-96ee-e0af1f45f3c5@github.com>
References: <Bo15SeZ0Stk3x93-didZjdIBRdatbdyTP60PnbaxExo=.ed30ffc3-6888-4bbe-96ee-e0af1f45f3c5@github.com>
Message-ID: <dQGgKUCn6WWJIsGLiZm3Znz1pnSxkviY5CjRN17CHX4=.f8254203-2240-481e-a860-4b22de1ed2d5@github.com>

On Fri, 1 Aug 2025 16:50:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Recently, a person sent an email to `mailman-at-openjdk.org` to change the email address as mentioned in the Guide, yet the email was rejected. The rejection email contained another address `mailman-owner-at-openjdk.org` that worked well. Therefore, I suggest updating the mail-man address in the Guide.
> 
> I also replaced ?discussions _around_? with ?discussions _about_?. This is how mailing lists are described on the page that lists all available OpenJDK mailing lists.

Looks good to me. @irisclark, can you please verify the email address?

-------------

PR Comment: https://git.openjdk.org/guide/pull/154#issuecomment-3146641637

From jwilhelm at openjdk.org  Sat Aug  2 17:55:46 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Sat, 2 Aug 2025 17:55:46 GMT
Subject: RFR: Requesting a change
Message-ID: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>

Advice for people who would like to request an OpenJDK change to be implemented or backported.

-------------

Commit messages:
 - Requesting a change

Changes: https://git.openjdk.org/guide/pull/155/files
  Webrev: https://webrevs.openjdk.org/?repo=guide&pr=155&range=00
  Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/guide/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/155/head:pull/155

PR: https://git.openjdk.org/guide/pull/155

From jwilhelm at openjdk.org  Sat Aug  2 18:15:52 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Sat, 2 Aug 2025 18:15:52 GMT
Subject: RFR: Requesting a change [v2]
In-Reply-To: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
Message-ID: <dtOqopc1dqU8mEzQ0joaUBg1n7CU6LkjigMdx6bJ34A=.dd3b053b-92cd-45cd-8299-5e17889942dd@github.com>

> Advice for people who would like to request an OpenJDK change to be implemented or backported.
> Also added a note about having more than one noreg-label.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  Some noreg advice

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/155/files
  - new: https://git.openjdk.org/guide/pull/155/files/575da2a1..94193431

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=155&range=01
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=155&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/guide/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/155/head:pull/155

PR: https://git.openjdk.org/guide/pull/155

From jwilhelm at openjdk.org  Sat Aug  2 18:27:46 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Sat, 2 Aug 2025 18:27:46 GMT
Subject: RFR: Requesting a change [v3]
In-Reply-To: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
Message-ID: <7u9FRynkgv1LvIH1A45fGwRbbuIwou79gSijqfaxIbk=.639fdb07-e12a-4f87-9278-8242a0c4443b@github.com>

> Advice for people who would like to request an OpenJDK change to be implemented or backported.
> Also added a note about having more than one noreg-label.
> HotSpot issues in JBS must have a Subcomponent set.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  Require subcomponent in hotspot

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/155/files
  - new: https://git.openjdk.org/guide/pull/155/files/94193431..d22ebb0b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=155&range=02
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=155&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/guide/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/155/head:pull/155

PR: https://git.openjdk.org/guide/pull/155

From jwilhelm at openjdk.org  Sat Aug  2 18:50:20 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Sat, 2 Aug 2025 18:50:20 GMT
Subject: RFR: Requesting a change [v4]
In-Reply-To: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
Message-ID: <jcRLax3jIgPAcJ_EnMkcg7fGQRyvZQc4JusQJ62bkms=.ec5eab9d-4a21-4fc8-9972-ac0c2f701908@github.com>

> Advice for people who would like to request an OpenJDK change to be implemented or backported.
> Also added a note about having more than one noreg-label.
> HotSpot issues in JBS must have a Subcomponent set.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  Assign before work

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/155/files
  - new: https://git.openjdk.org/guide/pull/155/files/d22ebb0b..27a29491

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=155&range=03
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=155&range=02-03

  Stats: 21 lines in 1 file changed: 15 ins; 6 del; 0 mod
  Patch: https://git.openjdk.org/guide/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/155/head:pull/155

PR: https://git.openjdk.org/guide/pull/155

From mhaessig at openjdk.org  Mon Aug  4 12:03:24 2025
From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=)
Date: Mon, 4 Aug 2025 12:03:24 GMT
Subject: RFR: Fix links to #trivial-changes
Message-ID: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>

This simple PR fixes broken links to the "Trivial Changes" section.

-------------

Commit messages:
 - Fix links to trivial-changes

Changes: https://git.openjdk.org/guide/pull/156/files
  Webrev: https://webrevs.openjdk.org/?repo=guide&pr=156&range=00
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/guide/pull/156.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/156/head:pull/156

PR: https://git.openjdk.org/guide/pull/156

From rhalade at openjdk.org  Mon Aug  4 17:51:12 2025
From: rhalade at openjdk.org (Rajan Halade)
Date: Mon, 4 Aug 2025 17:51:12 GMT
Subject: RFR: Requesting a change [v4]
In-Reply-To: <jcRLax3jIgPAcJ_EnMkcg7fGQRyvZQc4JusQJ62bkms=.ec5eab9d-4a21-4fc8-9972-ac0c2f701908@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
 <jcRLax3jIgPAcJ_EnMkcg7fGQRyvZQc4JusQJ62bkms=.ec5eab9d-4a21-4fc8-9972-ac0c2f701908@github.com>
Message-ID: <udivgOitDs3874-QggGDfYrSAjD6HSpnakf80rzrCX8=.247a29df-aa2b-4f67-ab22-0a39942f720d@github.com>

On Sat, 2 Aug 2025 18:50:20 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Advice for people who would like to request an OpenJDK change to be implemented or backported.
>> Also added a note about having more than one noreg-label.
>> HotSpot issues in JBS must have a Subcomponent set.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Assign before work

src/guide/jbs-jdk-bug-system.md line 217:

> 215: 1. If the issue is a duplicate, close it as such.
> 216: 1. If the issue belongs to a different area (it was filed in libraries, but it's an HotSpot issue), transfer it to the correct component/subcomponent making sure that the state remains [New]{.jbs-value}.
> 217:    * Please note that issues in the [hotspot]{.jbs-value} component must have a [Subcomponent]{.jbs-field} set as well.

Per me, this is true for `security-libs` component also. Where unsure, we use `java.security` or` jdk.security` sub-components but a sub-component must be set. In addition, can we request to remove `Empty` sub-component from the list in JBS if it is possible to do so?

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2252210445

From iris at openjdk.org  Mon Aug  4 18:12:09 2025
From: iris at openjdk.org (Iris Clark)
Date: Mon, 4 Aug 2025 18:12:09 GMT
Subject: RFR: Update mailman address
In-Reply-To: <Bo15SeZ0Stk3x93-didZjdIBRdatbdyTP60PnbaxExo=.ed30ffc3-6888-4bbe-96ee-e0af1f45f3c5@github.com>
References: <Bo15SeZ0Stk3x93-didZjdIBRdatbdyTP60PnbaxExo=.ed30ffc3-6888-4bbe-96ee-e0af1f45f3c5@github.com>
Message-ID: <_nElkjw6t2-rqvOw7xUU1XFs8mnq3GEhOUhDgIRXUzQ=.891333e0-4a8d-45e0-9fc0-5611689db918@github.com>

On Fri, 1 Aug 2025 16:50:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Recently, a person sent an email to `mailman-at-openjdk.org` to change the email address as mentioned in the Guide, yet the email was rejected. The rejection email contained another address `mailman-owner-at-openjdk.org` that worked well. Therefore, I suggest updating the mail-man address in the Guide.
> 
> I also replaced ?discussions _around_? with ?discussions _about_?. This is how mailing lists are described on the page that lists all available OpenJDK mailing lists.

Updated e-mail address confirmed.

-------------

Marked as reviewed by iris (Reviewer).

PR Review: https://git.openjdk.org/guide/pull/154#pullrequestreview-3085281534

From iris at openjdk.org  Mon Aug  4 18:38:42 2025
From: iris at openjdk.org (Iris Clark)
Date: Mon, 4 Aug 2025 18:38:42 GMT
Subject: RFR: Requesting a change [v4]
In-Reply-To: <jcRLax3jIgPAcJ_EnMkcg7fGQRyvZQc4JusQJ62bkms=.ec5eab9d-4a21-4fc8-9972-ac0c2f701908@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
 <jcRLax3jIgPAcJ_EnMkcg7fGQRyvZQc4JusQJ62bkms=.ec5eab9d-4a21-4fc8-9972-ac0c2f701908@github.com>
Message-ID: <BwEByM7M-5wpIGw2zFScpewg3hK4D2mGp9Y_z-vSqXc=.96a13860-d67a-4afd-ad88-219f7c5938b7@github.com>

On Sat, 2 Aug 2025 18:50:20 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Advice for people who would like to request an OpenJDK change to be implemented or backported.
>> Also added a note about having more than one noreg-label.
>> HotSpot issues in JBS must have a Subcomponent set.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Assign before work

src/guide/contributing-to-an-open-jdk-project.md line 13:

> 11: ## Requesting a change
> 12: 
> 13: If you want to request a change to the JDK, but don't have the intention to implement the change yourself, you should always contact the developers through the appropriate [mailing list](#mailing-lists). This is also the case if you find a change that you would like to see backported to an eralier JDK release. Never reach out directly to any developer.

Rather than directing people to our mailing lists, I suggest filing the concern at bugreport.java.com.  Only if somebody is interested in actively helping with some aspect of the implementation would I recommend contact via the OpenJDK mailing lists.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2252276271

From jwilhelm at openjdk.org  Mon Aug  4 19:20:31 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Mon, 4 Aug 2025 19:20:31 GMT
Subject: RFR: Requesting a change [v5]
In-Reply-To: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
Message-ID: <83cjdJWjQJlzvdoJZp4o34K0Z0GXvA3D7G8ygmqRRZ4=.3b6deaa1-b1b6-40e8-8b1f-d602b8c9d312@github.com>

> Advice for people who would like to request an OpenJDK change to be implemented or backported.
> Also added a note about having more than one noreg-label.
> HotSpot issues in JBS must have a Subcomponent set.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  SQE -> jtreg

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/155/files
  - new: https://git.openjdk.org/guide/pull/155/files/27a29491..14afc0ba

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=155&range=04
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=155&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/155/head:pull/155

PR: https://git.openjdk.org/guide/pull/155

From jwilhelm at openjdk.org  Tue Aug  5 18:40:10 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 5 Aug 2025 18:40:10 GMT
Subject: RFR: Requesting a change [v6]
In-Reply-To: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
Message-ID: <YJl8dCoY3txQ6wFLU8nbzN1GO8vci5r-mu3OgMOfD74=.7f185b0d-2381-41e6-a32b-32ad6295bec5@github.com>

> Advice for people who would like to request an OpenJDK change to be implemented or backported.
> Also added a note about having more than one noreg-label.
> HotSpot issues in JBS must have a Subcomponent set.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  bugfix -> change

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/155/files
  - new: https://git.openjdk.org/guide/pull/155/files/14afc0ba..7310ca75

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=155&range=05
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=155&range=04-05

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/155/head:pull/155

PR: https://git.openjdk.org/guide/pull/155

From jwilhelm at openjdk.org  Tue Aug  5 18:46:23 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 5 Aug 2025 18:46:23 GMT
Subject: RFR: Requesting a change [v4]
In-Reply-To: <udivgOitDs3874-QggGDfYrSAjD6HSpnakf80rzrCX8=.247a29df-aa2b-4f67-ab22-0a39942f720d@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
 <jcRLax3jIgPAcJ_EnMkcg7fGQRyvZQc4JusQJ62bkms=.ec5eab9d-4a21-4fc8-9972-ac0c2f701908@github.com>
 <udivgOitDs3874-QggGDfYrSAjD6HSpnakf80rzrCX8=.247a29df-aa2b-4f67-ab22-0a39942f720d@github.com>
Message-ID: <5ZNq4lvc8zOFySuR9Ql-audKw_PDisVhBtWBNLfs1PM=.88c3f188-ecda-4bd3-84e3-222b8393af1f@github.com>

On Mon, 4 Aug 2025 17:48:46 GMT, Rajan Halade <rhalade at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Assign before work
>
> src/guide/jbs-jdk-bug-system.md line 217:
> 
>> 215: 1. If the issue is a duplicate, close it as such.
>> 216: 1. If the issue belongs to a different area (it was filed in libraries, but it's an HotSpot issue), transfer it to the correct component/subcomponent making sure that the state remains [New]{.jbs-value}.
>> 217:    * Please note that issues in the [hotspot]{.jbs-value} component must have a [Subcomponent]{.jbs-field} set as well.
> 
> Per me, this is true for `security-libs` component also. Where unsure, we use `java.security` or` jdk.security` sub-components but a sub-component must be set. In addition, can we request to remove `Empty` sub-component from the list in JBS if it is possible to do so?

I have added security-libs. Unfortunately we can't enforce a subcomponent for some components without enforcing it for all components. (The `Empty` value is not a subcomponent in the list, it's Jira allowing to leave the field empty.)

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2255071423

From jwilhelm at openjdk.org  Tue Aug  5 19:19:07 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 5 Aug 2025 19:19:07 GMT
Subject: RFR: Requesting a change [v7]
In-Reply-To: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
Message-ID: <dKZn794XHEKEz4keswJu2YMpAX9jzw_VtlzPYQOvqZY=.f858b5e8-1177-4e36-8a7d-8a61c21cf237@github.com>

> Advice for people who would like to request an OpenJDK change to be implemented or backported.
> Also added a note about having more than one noreg-label.
> HotSpot issues in JBS must have a Subcomponent set.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  Use bugreport

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/155/files
  - new: https://git.openjdk.org/guide/pull/155/files/7310ca75..491c6a32

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=155&range=06
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=155&range=05-06

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/guide/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/155/head:pull/155

PR: https://git.openjdk.org/guide/pull/155

From jwilhelm at openjdk.org  Tue Aug  5 19:19:08 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 5 Aug 2025 19:19:08 GMT
Subject: RFR: Requesting a change [v4]
In-Reply-To: <BwEByM7M-5wpIGw2zFScpewg3hK4D2mGp9Y_z-vSqXc=.96a13860-d67a-4afd-ad88-219f7c5938b7@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
 <jcRLax3jIgPAcJ_EnMkcg7fGQRyvZQc4JusQJ62bkms=.ec5eab9d-4a21-4fc8-9972-ac0c2f701908@github.com>
 <BwEByM7M-5wpIGw2zFScpewg3hK4D2mGp9Y_z-vSqXc=.96a13860-d67a-4afd-ad88-219f7c5938b7@github.com>
Message-ID: <Kub-n75NJza8ju_yLkG1VvqzzM6Px3qrWctOHoLML1w=.e510a5c3-0d65-41c8-9c7d-89bb52b6eb69@github.com>

On Mon, 4 Aug 2025 18:23:25 GMT, Iris Clark <iris at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Assign before work
>
> src/guide/contributing-to-an-open-jdk-project.md line 13:
> 
>> 11: ## Requesting a change
>> 12: 
>> 13: If you want to request a change to the JDK, but don't have the intention to implement the change yourself, you should always contact the developers through the appropriate [mailing list](#mailing-lists). This is also the case if you find a change that you would like to see backported to an eralier JDK release. Never reach out directly to any developer.
> 
> Rather than directing people to our mailing lists, I suggest filing the concern at bugreport.java.com.  Only if somebody is interested in actively helping with some aspect of the implementation would I recommend contact via the OpenJDK mailing lists.

Agreed. I have updated the text.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2255131795

From iris at openjdk.org  Tue Aug  5 20:07:18 2025
From: iris at openjdk.org (Iris Clark)
Date: Tue, 5 Aug 2025 20:07:18 GMT
Subject: RFR: Requesting a change [v7]
In-Reply-To: <dKZn794XHEKEz4keswJu2YMpAX9jzw_VtlzPYQOvqZY=.f858b5e8-1177-4e36-8a7d-8a61c21cf237@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
 <dKZn794XHEKEz4keswJu2YMpAX9jzw_VtlzPYQOvqZY=.f858b5e8-1177-4e36-8a7d-8a61c21cf237@github.com>
Message-ID: <migS-KRlrdAtuz1d8pxq7V7xbDIezDwf0XhT-DgLm0g=.3098ca31-5418-4c5b-a44a-9523fff55a73@github.com>

On Tue, 5 Aug 2025 19:19:07 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Advice for people who would like to request an OpenJDK change to be implemented or backported.
>> Also added a note about having more than one noreg-label.
>> HotSpot issues in JBS must have a Subcomponent set.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use bugreport

src/guide/contributing-to-an-open-jdk-project.md line 13:

> 11: ## Requesting a change
> 12: 
> 13: If you want to request a change to the JDK, but don't have the intention to implement/contribute to the change yourself, you should always go through [bugreport.java.com](bugreport.java.com). This is also the case if you find a change that you would like to see backported to an eralier JDK release. **Never** reach out directly to any developer. Also, please note that the [OpenJDK mailing lists](#mailing-lists) are intended for developers and contributors. These lists are not support channels or channels for requesting changes.

I like the revised text.  Maybe "always go through" -> "always report it at"

typo: "eralier" -> "earlier"

src/guide/contributing-to-an-open-jdk-project.md line 15:

> 13: If you want to request a change to the JDK, but don't have the intention to implement/contribute to the change yourself, you should always go through [bugreport.java.com](bugreport.java.com). This is also the case if you find a change that you would like to see backported to an eralier JDK release. **Never** reach out directly to any developer. Also, please note that the [OpenJDK mailing lists](#mailing-lists) are intended for developers and contributors. These lists are not support channels or channels for requesting changes.
> 14: 
> 15: Before you reach out, make sure you have read [Things to consider before proposing changes to OpenJDK code](#things-to-consider-before-proposing-changes-to-openjdk-code) and [Why is my change rejected?](#why-is-my-change-rejected) below.

In light of your revision in the previous sentence, perhaps "Before you reach out" -> "Before you file an issue"?

src/guide/jbs-jdk-bug-system.md line 217:

> 215: 1. If the issue is a duplicate, close it as such.
> 216: 1. If the issue belongs to a different area (it was filed in libraries, but it's an HotSpot issue), transfer it to the correct component/subcomponent making sure that the state remains [New]{.jbs-value}.
> 217:    * Please note that issues in the [hotspot]{.jbs-value} and [security-libs]{.jbs-value} components must have a [Subcomponent]{.jbs-field} set as well.

Are these the only components which require a subcomponent?  I know that client-libs and core-libs are quite large (https://bugs.openjdk.org/projects/JDK?selectedItem=com.atlassian.jira.jira-projects-plugin:components-page) so it wouldn't surprise me if there were similar recommendations there too.  Perhaps update to "issues in the hotspot, security-libs, and other components ..." to leave this possibility open without needing to survey all of the components?

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2255205661
PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2255228900
PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2255229005

From jwilhelm at openjdk.org  Tue Aug  5 23:11:17 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 5 Aug 2025 23:11:17 GMT
Subject: RFR: Requesting a change [v7]
In-Reply-To: <migS-KRlrdAtuz1d8pxq7V7xbDIezDwf0XhT-DgLm0g=.3098ca31-5418-4c5b-a44a-9523fff55a73@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
 <dKZn794XHEKEz4keswJu2YMpAX9jzw_VtlzPYQOvqZY=.f858b5e8-1177-4e36-8a7d-8a61c21cf237@github.com>
 <migS-KRlrdAtuz1d8pxq7V7xbDIezDwf0XhT-DgLm0g=.3098ca31-5418-4c5b-a44a-9523fff55a73@github.com>
Message-ID: <b8sJMYQiNnATRCTiV6ndUSm1sNy5ZORdQ-CQSG49Zbs=.27bda420-2541-4c72-a44f-5d2dc37f0a8e@github.com>

On Tue, 5 Aug 2025 19:52:37 GMT, Iris Clark <iris at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use bugreport
>
> src/guide/contributing-to-an-open-jdk-project.md line 13:
> 
>> 11: ## Requesting a change
>> 12: 
>> 13: If you want to request a change to the JDK, but don't have the intention to implement/contribute to the change yourself, you should always go through [bugreport.java.com](bugreport.java.com). This is also the case if you find a change that you would like to see backported to an eralier JDK release. **Never** reach out directly to any developer. Also, please note that the [OpenJDK mailing lists](#mailing-lists) are intended for developers and contributors. These lists are not support channels or channels for requesting changes.
> 
> I like the revised text.  Maybe "always go through" -> "always report it at"
> 
> typo: "eralier" -> "earlier"

Fixed.

> src/guide/contributing-to-an-open-jdk-project.md line 15:
> 
>> 13: If you want to request a change to the JDK, but don't have the intention to implement/contribute to the change yourself, you should always go through [bugreport.java.com](bugreport.java.com). This is also the case if you find a change that you would like to see backported to an eralier JDK release. **Never** reach out directly to any developer. Also, please note that the [OpenJDK mailing lists](#mailing-lists) are intended for developers and contributors. These lists are not support channels or channels for requesting changes.
>> 14: 
>> 15: Before you reach out, make sure you have read [Things to consider before proposing changes to OpenJDK code](#things-to-consider-before-proposing-changes-to-openjdk-code) and [Why is my change rejected?](#why-is-my-change-rejected) below.
> 
> In light of your revision in the previous sentence, perhaps "Before you reach out" -> "Before you file an issue"?

Yes, much better :-)

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2255508536
PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2255509388

From jwilhelm at openjdk.org  Tue Aug  5 23:18:07 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 5 Aug 2025 23:18:07 GMT
Subject: RFR: Requesting a change [v8]
In-Reply-To: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
Message-ID: <Bfg8CoXiGUTsoBX5lhR-UcFTEXUqizoi9uNqIKoEqFE=.5ffa8f95-4c57-431d-b314-3798d93b9230@github.com>

> Advice for people who would like to request an OpenJDK change to be implemented or backported.
> Also added a note about having more than one noreg-label.
> HotSpot issues in JBS must have a Subcomponent set.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  Fixed typos

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/155/files
  - new: https://git.openjdk.org/guide/pull/155/files/491c6a32..7efca50a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=155&range=07
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=155&range=06-07

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/guide/pull/155.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/155/head:pull/155

PR: https://git.openjdk.org/guide/pull/155

From jwilhelm at openjdk.org  Tue Aug  5 23:18:10 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 5 Aug 2025 23:18:10 GMT
Subject: RFR: Requesting a change [v7]
In-Reply-To: <migS-KRlrdAtuz1d8pxq7V7xbDIezDwf0XhT-DgLm0g=.3098ca31-5418-4c5b-a44a-9523fff55a73@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
 <dKZn794XHEKEz4keswJu2YMpAX9jzw_VtlzPYQOvqZY=.f858b5e8-1177-4e36-8a7d-8a61c21cf237@github.com>
 <migS-KRlrdAtuz1d8pxq7V7xbDIezDwf0XhT-DgLm0g=.3098ca31-5418-4c5b-a44a-9523fff55a73@github.com>
Message-ID: <VxGLpJdmK62-AYPoMxokpEx9zyzMfOkVt6eQ5lzEvHQ=.dee467b0-3d19-48b3-a4be-f14ebf6963a3@github.com>

On Tue, 5 Aug 2025 20:04:16 GMT, Iris Clark <iris at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use bugreport
>
> src/guide/jbs-jdk-bug-system.md line 217:
> 
>> 215: 1. If the issue is a duplicate, close it as such.
>> 216: 1. If the issue belongs to a different area (it was filed in libraries, but it's an HotSpot issue), transfer it to the correct component/subcomponent making sure that the state remains [New]{.jbs-value}.
>> 217:    * Please note that issues in the [hotspot]{.jbs-value} and [security-libs]{.jbs-value} components must have a [Subcomponent]{.jbs-field} set as well.
> 
> Are these the only components which require a subcomponent?  I know that client-libs and core-libs are quite large (https://bugs.openjdk.org/projects/JDK?selectedItem=com.atlassian.jira.jira-projects-plugin:components-page) so it wouldn't surprise me if there were similar recommendations there too.  Perhaps update to "issues in the hotspot, security-libs, and other components ..." to leave this possibility open without needing to survey all of the components?

As far as I know the other components don't require a subcomponent.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2255517029

From iris at openjdk.org  Wed Aug  6 00:05:17 2025
From: iris at openjdk.org (Iris Clark)
Date: Wed, 6 Aug 2025 00:05:17 GMT
Subject: RFR: Requesting a change [v8]
In-Reply-To: <Bfg8CoXiGUTsoBX5lhR-UcFTEXUqizoi9uNqIKoEqFE=.5ffa8f95-4c57-431d-b314-3798d93b9230@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
 <Bfg8CoXiGUTsoBX5lhR-UcFTEXUqizoi9uNqIKoEqFE=.5ffa8f95-4c57-431d-b314-3798d93b9230@github.com>
Message-ID: <KJywCH5VISyaTtexcXIJ_vl5Tsd8rq3GCbowvl7EOH8=.94b52f81-cacf-4990-9149-3ac2d50f356b@github.com>

On Tue, 5 Aug 2025 23:18:07 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Advice for people who would like to request an OpenJDK change to be implemented or backported.
>> Also added a note about having more than one noreg-label.
>> HotSpot issues in JBS must have a Subcomponent set.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed typos

Looks good!  Thanks for making these changes.

-------------

Marked as reviewed by iris (Reviewer).

PR Review: https://git.openjdk.org/guide/pull/155#pullrequestreview-3090016144

From duke at openjdk.org  Wed Aug  6 12:44:24 2025
From: duke at openjdk.org (duke)
Date: Wed, 6 Aug 2025 12:44:24 GMT
Subject: RFR: Update mailman address
In-Reply-To: <Bo15SeZ0Stk3x93-didZjdIBRdatbdyTP60PnbaxExo=.ed30ffc3-6888-4bbe-96ee-e0af1f45f3c5@github.com>
References: <Bo15SeZ0Stk3x93-didZjdIBRdatbdyTP60PnbaxExo=.ed30ffc3-6888-4bbe-96ee-e0af1f45f3c5@github.com>
Message-ID: <Rd8O7IOgHgbIiEoCml2IvZkAthnN-wEYUNRdw_wH5lU=.68f7ae10-8cf4-4fef-9f92-43d70c845bf2@github.com>

On Fri, 1 Aug 2025 16:50:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Recently, a person sent an email to `mailman-at-openjdk.org` to change the email address as mentioned in the Guide, yet the email was rejected. The rejection email contained another address `mailman-owner-at-openjdk.org` that worked well. Therefore, I suggest updating the mail-man address in the Guide.
> 
> I also replaced ?discussions _around_? with ?discussions _about_?. This is how mailing lists are described on the page that lists all available OpenJDK mailing lists.

@aivanov-jdk 
Your change (at version 3be280d49a1f4fe40edeb0af46e5ac5420399d55) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/guide/pull/154#issuecomment-3160008775

From jwilhelm at openjdk.org  Wed Aug  6 18:20:36 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 6 Aug 2025 18:20:36 GMT
Subject: RFR: Requesting a change [v8]
In-Reply-To: <Bfg8CoXiGUTsoBX5lhR-UcFTEXUqizoi9uNqIKoEqFE=.5ffa8f95-4c57-431d-b314-3798d93b9230@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
 <Bfg8CoXiGUTsoBX5lhR-UcFTEXUqizoi9uNqIKoEqFE=.5ffa8f95-4c57-431d-b314-3798d93b9230@github.com>
Message-ID: <qyGhtKkd4wrmkiUIpKAvX85BfRMgJquBp1I4q48ZYx8=.7a4f969d-9026-4d32-8994-9e3c64f8aa8c@github.com>

On Tue, 5 Aug 2025 23:18:07 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Advice for people who would like to request an OpenJDK change to be implemented or backported.
>> Also added a note about having more than one noreg-label.
>> HotSpot issues in JBS must have a Subcomponent set.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed typos

Thank you for reviewing!

-------------

PR Comment: https://git.openjdk.org/guide/pull/155#issuecomment-3161138028

From aivanov at openjdk.org  Wed Aug  6 18:48:37 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Aug 2025 18:48:37 GMT
Subject: RFR: Requesting a change [v8]
In-Reply-To: <Bfg8CoXiGUTsoBX5lhR-UcFTEXUqizoi9uNqIKoEqFE=.5ffa8f95-4c57-431d-b314-3798d93b9230@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
 <Bfg8CoXiGUTsoBX5lhR-UcFTEXUqizoi9uNqIKoEqFE=.5ffa8f95-4c57-431d-b314-3798d93b9230@github.com>
Message-ID: <rOsaveh9IJfpvSSVtyOvT30r-XfcUKAyOmIcucRNIdo=.1e5eaf60-4ad6-48e5-b013-d5c90478d628@github.com>

On Tue, 5 Aug 2025 23:18:07 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Advice for people who would like to request an OpenJDK change to be implemented or backported.
>> Also added a note about having more than one noreg-label.
>> HotSpot issues in JBS must have a Subcomponent set.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed typos

Changes requested by aivanov (no project role).

src/guide/contributing-to-an-open-jdk-project.md line 13:

> 11: ## Requesting a change
> 12: 
> 13: If you want to request a change to the JDK, but don't have the intention to implement/contribute to the change yourself, you should always report it at [bugreport.java.com](bugreport.java.com). This is also the case if you find a change that you would like to see backported to an earlier JDK release. **Never** reach out directly to any developer. Also, please note that the [OpenJDK mailing lists](#mailing-lists) are intended for developers and contributors. These lists are not support channels or channels for requesting changes.

It's still unclear what a person should do to request backporting a fix. Is it recommended to submit a new bug?

src/guide/contributing-to-an-open-jdk-project.md line 46:

> 44: 
> 45: - As with any change, do bring it up for discussion on the [mailing lists](#mailing-lists) before spending time on the fix. Even though the issue has been filed in JBS there may be reasons not to fix that particular issue right now.
> 46: - Never work on an issue that is assigned to someone else. Duplicating work is pointless. If you think that an issue should be fixed and it has been assinged to someone for a long time without progress, reach out to that person and ask what the current status is. Many issues requires a lot of thought, and there may be half-baked solutions that you can build on to avoid the traps the initial developer has already fallen into.

Suggestion:

- Never work on an issue that is assigned to someone else. Duplicating work is pointless. If you think that an issue should be fixed and it has been assigned to someone for a long time without progress, reach out to that person and ask what the current status is. Many issues requires a lot of thought, and there may be half-baked solutions that you can build on to avoid the traps the initial developer has already fallen into.

src/guide/jbs-jdk-bug-system.md line 217:

> 215: 1. If the issue is a duplicate, close it as such.
> 216: 1. If the issue belongs to a different area (it was filed in libraries, but it's an HotSpot issue), transfer it to the correct component/subcomponent making sure that the state remains [New]{.jbs-value}.
> 217:    * Please note that issues in the [hotspot]{.jbs-value} and [security-libs]{.jbs-value} components must have a [Subcomponent]{.jbs-field} set as well.

@irisclark is right, it's advisable to set a subcomponent for issues in client-libs. However, it's not required as far as I can tell. There are issues where subcomponent isn't set, in majority of cases this is likely because the issue is too broad and is applicable to the entire client area.

src/guide/jbs-jdk-bug-system.md line 652:

> 650:                            [[nounit-]{.jbs-label}`.*`]{#nounit}</td>
> 651:     <td class="dictionary">
> 652:       The [noreg-]{.jbs-label}`.*` and [nounit-]{.jbs-label}`.*` labels are used to explain why a change doesn't need/have a regression test or a unit test. The suffix of the label is described below. Every change that is integrated into the JDK source code must either have a regression/unit test, or have at least one of these labels on its JBS issue. It's quite possible to have more than one of these labels on the same issue. For instance, an integration could contain both changes to documentation and test code. In that case it would be logical to label the issue with both [noreg-doc]{.jbs-label} and [noreg-self]{.jbs-label}.

Suggestion:

      The [noreg-]{.jbs-label}`.*` and [nounit-]{.jbs-label}`.*` labels are used to explain why a change doesn't need/have a regression test or a unit test. The suffix of the label is described below. Every change that is integrated into the JDK source code must either have a regression/unit test, or have at least one of these labels on its JBS issue. It's possible to have more than one of these labels on the same issue. For instance, a changeset could contain both changes to documentation and test code. In that case it would be logical to label the issue with both [noreg-doc]{.jbs-label} and [noreg-self]{.jbs-label}.

?An integration? sounds confusing. To avoid having ?changeset? and ?changes? close in one sentence, you could state: ?a change could modify both??

?Quite? doesn't clarify the meaning, the sentence is clearer without it.

-------------

PR Review: https://git.openjdk.org/guide/pull/155#pullrequestreview-3093763213
PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2257968034
PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2257971819
PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2257964308
PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2257988340

From aivanov at openjdk.org  Wed Aug  6 18:55:34 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Aug 2025 18:55:34 GMT
Subject: RFR: Fix links to #trivial-changes
In-Reply-To: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
Message-ID: <fVtG6fNBZahrTt7DoOc_XicYM-y9QpDapkqXfbgkJRU=.84c5cf54-5464-4211-8056-633c8ef998ea@github.com>

On Mon, 4 Aug 2025 11:59:12 GMT, Manuel H?ssig <mhaessig at openjdk.org> wrote:

> This simple PR fixes broken links to the "Trivial Changes" section.

src/guide/testing-the-jdk.md line 292:

> 290: ProblemListing and `@ignore`-ing are done in the JDK source tree, that means a check-in into the repository is needed. This in turn means that a unique JBS issue and a code review are needed. This is a good thing since it makes test problems visible.
> 291: 
> 292: * **Code review**: ProblemListing a test is considered a [trivial]#trivial-changes) change.

Suggestion:

* **Code review**: ProblemListing a test is considered a [trivial change]#trivial-changes).

To align with other usages?

src/guide/testing-the-jdk.md line 307:

> 305: It will happen of course when the build is broken or the JDK is DOA and similar situations that a change is immediately backed out without further investigation. Backing out a change is however seldom the first course of action if the change has been done in accordance with the guidance in [Working With Pull Requests]. If, when investigated, it is found that a change didn't go through relevant testing or there are other issues that should have been caught before integration if proper procedure had been followed, it's quite possible that a change is backed out even if the author is desperately working on a fix. The JDK source code is deliberately menat to have a high bar for acceptance of changes. If something crawls in underneath that bar it should most likely be backed out.
> 306: 
> 307: The backout is a regular change and will have to go through the standard code review process, but is considered a [trivial](#trivial-changes) change. The rationale is that a backout is usually urgent in nature and the change itself is automatically generated. In areas where two reviewers are normally required, only one [Reviewer](https://openjdk.org/bylaws#reviewer) is required for a backout since the person who is performing the backout also should review the change.

Suggestion:

The backout is a regular change and will have to go through the standard code review process, but is considered a [trivial change](#trivial-changes). The rationale is that a backout is usually urgent in nature and the change itself is automatically generated. In areas where two reviewers are normally required, only one [Reviewer](https://openjdk.org/bylaws#reviewer) is required for a backout since the person who is performing the backout also should review the change.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/156#discussion_r2258005353
PR Review Comment: https://git.openjdk.org/guide/pull/156#discussion_r2258006824

From jwilhelm at openjdk.org  Wed Aug  6 19:05:33 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 6 Aug 2025 19:05:33 GMT
Subject: Integrated: Requesting a change
In-Reply-To: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
Message-ID: <tjW7nTbNbE9NlEhAf9sBOIW1VOAX613vXT6jBr-g0D4=.9278383e-9e81-494c-b8ac-443cefb8a422@github.com>

On Sat, 2 Aug 2025 17:49:47 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Advice for people who would like to request an OpenJDK change to be implemented or backported.
> Also added a note about having more than one noreg-label.
> HotSpot issues in JBS must have a Subcomponent set.

This pull request has now been integrated.

Changeset: 9346fa2e
Author:    Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/9346fa2ec2dd3da4383c7e729ab69c30fdb9b092
Stats:     19 lines in 3 files changed: 16 ins; 0 del; 3 mod

Requesting a change

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/guide/pull/155

From aivanov at openjdk.org  Wed Aug  6 19:40:34 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Aug 2025 19:40:34 GMT
Subject: RFR: Requesting a change [v8]
In-Reply-To: <rOsaveh9IJfpvSSVtyOvT30r-XfcUKAyOmIcucRNIdo=.1e5eaf60-4ad6-48e5-b013-d5c90478d628@github.com>
References: <T5KPrElmCqCfq39sWFugUXUPpYRTjdsPk98LAgO9aSc=.2646eb34-e899-4fc6-b088-3c7d04c5a5bd@github.com>
 <Bfg8CoXiGUTsoBX5lhR-UcFTEXUqizoi9uNqIKoEqFE=.5ffa8f95-4c57-431d-b314-3798d93b9230@github.com>
 <rOsaveh9IJfpvSSVtyOvT30r-XfcUKAyOmIcucRNIdo=.1e5eaf60-4ad6-48e5-b013-d5c90478d628@github.com>
Message-ID: <z_7cdBc5glMx_qqOBZ9pCmUb6n5koUnnREfe4RzTio0=.02cce814-4495-494b-8111-1a0d35a25d6b@github.com>

On Wed, 6 Aug 2025 18:44:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed typos
>
> src/guide/jbs-jdk-bug-system.md line 652:
> 
>> 650:                            [[nounit-]{.jbs-label}`.*`]{#nounit}</td>
>> 651:     <td class="dictionary">
>> 652:       The [noreg-]{.jbs-label}`.*` and [nounit-]{.jbs-label}`.*` labels are used to explain why a change doesn't need/have a regression test or a unit test. The suffix of the label is described below. Every change that is integrated into the JDK source code must either have a regression/unit test, or have at least one of these labels on its JBS issue. It's quite possible to have more than one of these labels on the same issue. For instance, an integration could contain both changes to documentation and test code. In that case it would be logical to label the issue with both [noreg-doc]{.jbs-label} and [noreg-self]{.jbs-label}.
> 
> Suggestion:
> 
>       The [noreg-]{.jbs-label}`.*` and [nounit-]{.jbs-label}`.*` labels are used to explain why a change doesn't need/have a regression test or a unit test. The suffix of the label is described below. Every change that is integrated into the JDK source code must either have a regression/unit test, or have at least one of these labels on its JBS issue. It's possible to have more than one of these labels on the same issue. For instance, a changeset could contain both changes to documentation and test code. In that case it would be logical to label the issue with both [noreg-doc]{.jbs-label} and [noreg-self]{.jbs-label}.
> 
> ?An integration? sounds confusing. To avoid having ?changeset? and ?changes? close in one sentence, you could state: ?a change could modify both??
> 
> ?Quite? doesn't clarify the meaning, the sentence is clearer without it.

I applied my suggestions and submitted #157.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2258099120

From aivanov at openjdk.org  Wed Aug  6 19:44:45 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Wed, 6 Aug 2025 19:44:45 GMT
Subject: RFR: Amend Requesting a change
Message-ID: <4WMJJY9hKOVMrPfSHUGdQ96Ui8vkW9SJZkykLzPoy4Y=.d98db63a-d247-4f39-9219-848952ed8970@github.com>

A follow-up to #155 where I submitted suggestions after the issue was integrated. I applied [my suggestions](https://github.com/openjdk/guide/pull/155#discussion_r2257971819) in this PR.

* Fix a few typos;
* Clarify the sentences.

-------------

Commit messages:
 - Amend Requesting a change

Changes: https://git.openjdk.org/guide/pull/157/files
  Webrev: https://webrevs.openjdk.org/?repo=guide&pr=157&range=00
  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/guide/pull/157.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/157/head:pull/157

PR: https://git.openjdk.org/guide/pull/157

From mhaessig at openjdk.org  Thu Aug  7 07:23:39 2025
From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=)
Date: Thu, 7 Aug 2025 07:23:39 GMT
Subject: RFR: Fix links to #trivial-changes [v2]
In-Reply-To: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
Message-ID: <cBycVaZx1RgMENrF2eITSN207KwWleKloZR_uGuAPZY=.2bfc11cd-764f-4334-ae1a-004e5796b314@github.com>

> This simple PR fixes broken links to the "Trivial Changes" section.

Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision:

  Update src/guide/testing-the-jdk.md
  
  Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/156/files
  - new: https://git.openjdk.org/guide/pull/156/files/0880c2d8..84cd17a9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=156&range=01
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=156&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/156.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/156/head:pull/156

PR: https://git.openjdk.org/guide/pull/156

From aivanov at openjdk.org  Thu Aug  7 10:27:29 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 10:27:29 GMT
Subject: RFR: Fix links to #trivial-changes [v2]
In-Reply-To: <cBycVaZx1RgMENrF2eITSN207KwWleKloZR_uGuAPZY=.2bfc11cd-764f-4334-ae1a-004e5796b314@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
 <cBycVaZx1RgMENrF2eITSN207KwWleKloZR_uGuAPZY=.2bfc11cd-764f-4334-ae1a-004e5796b314@github.com>
Message-ID: <jFWWRJg8FCgq5XVPasYXMpx5tKiNNlYojE5GEK3cQ8k=.5be5489c-8e6f-46ba-a204-4a8de0a85c3e@github.com>

On Thu, 7 Aug 2025 07:23:39 GMT, Manuel H?ssig <mhaessig at openjdk.org> wrote:

>> This simple PR fixes broken links to the "Trivial Changes" section.
>
> Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/guide/testing-the-jdk.md
>   
>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

Changes requested by aivanov (no project role).

src/guide/testing-the-jdk.md line 292:

> 290: ProblemListing and `@ignore`-ing are done in the JDK source tree, that means a check-in into the repository is needed. This in turn means that a unique JBS issue and a code review are needed. This is a good thing since it makes test problems visible.
> 291: 
> 292: * **Code review**: ProblemListing a test is considered a [trivial]#trivial-changes) change.

Suggestion:

* **Code review**: ProblemListing a test is considered a [trivial change]#trivial-changes).

I'm still for updating this reference too.

You've marked [my comment](https://github.com/openjdk/guide/pull/156/files#r2258005353) as resolved, yet I can't see the changes.

-------------

PR Review: https://git.openjdk.org/guide/pull/156#pullrequestreview-3096454911
PR Review Comment: https://git.openjdk.org/guide/pull/156#discussion_r2259852328

From mhaessig at openjdk.org  Thu Aug  7 11:14:13 2025
From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=)
Date: Thu, 7 Aug 2025 11:14:13 GMT
Subject: RFR: Fix links to #trivial-changes [v3]
In-Reply-To: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
Message-ID: <7AljyKv3fXl7pu15eloiPeOC3_Ko8CqcKrH33BkyiDI=.d03b924f-8fa0-431c-ba8a-8b4f15560e77@github.com>

> This simple PR fixes broken links to the "Trivial Changes" section.

Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision:

  Update src/guide/testing-the-jdk.md
  
  Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/156/files
  - new: https://git.openjdk.org/guide/pull/156/files/84cd17a9..e7910511

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=156&range=02
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=156&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/156.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/156/head:pull/156

PR: https://git.openjdk.org/guide/pull/156

From mhaessig at openjdk.org  Thu Aug  7 11:14:15 2025
From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=)
Date: Thu, 7 Aug 2025 11:14:15 GMT
Subject: RFR: Fix links to #trivial-changes [v2]
In-Reply-To: <jFWWRJg8FCgq5XVPasYXMpx5tKiNNlYojE5GEK3cQ8k=.5be5489c-8e6f-46ba-a204-4a8de0a85c3e@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
 <cBycVaZx1RgMENrF2eITSN207KwWleKloZR_uGuAPZY=.2bfc11cd-764f-4334-ae1a-004e5796b314@github.com>
 <jFWWRJg8FCgq5XVPasYXMpx5tKiNNlYojE5GEK3cQ8k=.5be5489c-8e6f-46ba-a204-4a8de0a85c3e@github.com>
Message-ID: <QEg0cYN_VP7Z3Y9Ymqz0VFcWU8zoIiWOcu2JIq10rdw=.b7b43e46-b1ed-43cd-b46e-635ddb02365e@github.com>

On Thu, 7 Aug 2025 10:25:21 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/guide/testing-the-jdk.md
>>   
>>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>
> src/guide/testing-the-jdk.md line 292:
> 
>> 290: ProblemListing and `@ignore`-ing are done in the JDK source tree, that means a check-in into the repository is needed. This in turn means that a unique JBS issue and a code review are needed. This is a good thing since it makes test problems visible.
>> 291: 
>> 292: * **Code review**: ProblemListing a test is considered a [trivial]#trivial-changes) change.
> 
> Suggestion:
> 
> * **Code review**: ProblemListing a test is considered a [trivial change]#trivial-changes).
> 
> I'm still for updating this reference too.
> 
> You've marked [my comment](https://github.com/openjdk/guide/pull/156/files#r2258005353) as resolved, yet I can't see the changes.

Excuse me, I intended to commit both, but messed up.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/156#discussion_r2259950105

From aivanov at openjdk.org  Thu Aug  7 11:19:30 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 11:19:30 GMT
Subject: RFR: Fix links to #trivial-changes [v3]
In-Reply-To: <7AljyKv3fXl7pu15eloiPeOC3_Ko8CqcKrH33BkyiDI=.d03b924f-8fa0-431c-ba8a-8b4f15560e77@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
 <7AljyKv3fXl7pu15eloiPeOC3_Ko8CqcKrH33BkyiDI=.d03b924f-8fa0-431c-ba8a-8b4f15560e77@github.com>
Message-ID: <VIwJiUT8ED3DYpR0L_UYv6IYSGWTn3izEvx_Xdwz9N4=.936ba411-7200-41e5-a549-b7fc1814accd@github.com>

On Thu, 7 Aug 2025 11:14:13 GMT, Manuel H?ssig <mhaessig at openjdk.org> wrote:

>> This simple PR fixes broken links to the "Trivial Changes" section.
>
> Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/guide/testing-the-jdk.md
>   
>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

Changes requested by aivanov (no project role).

src/guide/testing-the-jdk.md line 292:

> 290: ProblemListing and `@ignore`-ing are done in the JDK source tree, that means a check-in into the repository is needed. This in turn means that a unique JBS issue and a code review are needed. This is a good thing since it makes test problems visible.
> 291: 
> 292: * **Code review**: ProblemListing a test is considered a [trivial change]#trivial-changes).

Suggestion:

* **Code review**: ProblemListing a test is considered a [trivial change](#trivial-changes).

Now the opening parenthesis is missing.

-------------

PR Review: https://git.openjdk.org/guide/pull/156#pullrequestreview-3096602428
PR Review Comment: https://git.openjdk.org/guide/pull/156#discussion_r2259960730

From aivanov at openjdk.org  Thu Aug  7 11:19:30 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 11:19:30 GMT
Subject: RFR: Fix links to #trivial-changes [v3]
In-Reply-To: <VIwJiUT8ED3DYpR0L_UYv6IYSGWTn3izEvx_Xdwz9N4=.936ba411-7200-41e5-a549-b7fc1814accd@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
 <7AljyKv3fXl7pu15eloiPeOC3_Ko8CqcKrH33BkyiDI=.d03b924f-8fa0-431c-ba8a-8b4f15560e77@github.com>
 <VIwJiUT8ED3DYpR0L_UYv6IYSGWTn3izEvx_Xdwz9N4=.936ba411-7200-41e5-a549-b7fc1814accd@github.com>
Message-ID: <Z-EwDOTPVA00igDD7NK1MGjnoM5LzZpHBFdmOiIW70M=.5ac1a1a2-7dda-40d5-a9dc-2df1860174be@github.com>

On Thu, 7 Aug 2025 11:15:32 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/guide/testing-the-jdk.md
>>   
>>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>
> src/guide/testing-the-jdk.md line 292:
> 
>> 290: ProblemListing and `@ignore`-ing are done in the JDK source tree, that means a check-in into the repository is needed. This in turn means that a unique JBS issue and a code review are needed. This is a good thing since it makes test problems visible.
>> 291: 
>> 292: * **Code review**: ProblemListing a test is considered a [trivial change]#trivial-changes).
> 
> Suggestion:
> 
> * **Code review**: ProblemListing a test is considered a [trivial change](#trivial-changes).
> 
> Now the opening parenthesis is missing.

I messed up my previous suggestion and I didn't noticed it.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/156#discussion_r2259964323

From mhaessig at openjdk.org  Thu Aug  7 11:26:45 2025
From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=)
Date: Thu, 7 Aug 2025 11:26:45 GMT
Subject: RFR: Fix links to #trivial-changes [v4]
In-Reply-To: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
Message-ID: <FPk3u_tJ5m0T_m1PDnWU_DVllqkNO5SejbeWExwlYqk=.5f176371-23e6-460a-9044-398565c1d860@github.com>

> This simple PR fixes broken links to the "Trivial Changes" section.

Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision:

  Apply suggestions from code review
  
  Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/156/files
  - new: https://git.openjdk.org/guide/pull/156/files/e7910511..bc4dbab0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=156&range=03
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=156&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/156.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/156/head:pull/156

PR: https://git.openjdk.org/guide/pull/156

From mhaessig at openjdk.org  Thu Aug  7 11:26:45 2025
From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=)
Date: Thu, 7 Aug 2025 11:26:45 GMT
Subject: RFR: Fix links to #trivial-changes [v3]
In-Reply-To: <Z-EwDOTPVA00igDD7NK1MGjnoM5LzZpHBFdmOiIW70M=.5ac1a1a2-7dda-40d5-a9dc-2df1860174be@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
 <7AljyKv3fXl7pu15eloiPeOC3_Ko8CqcKrH33BkyiDI=.d03b924f-8fa0-431c-ba8a-8b4f15560e77@github.com>
 <VIwJiUT8ED3DYpR0L_UYv6IYSGWTn3izEvx_Xdwz9N4=.936ba411-7200-41e5-a549-b7fc1814accd@github.com>
 <Z-EwDOTPVA00igDD7NK1MGjnoM5LzZpHBFdmOiIW70M=.5ac1a1a2-7dda-40d5-a9dc-2df1860174be@github.com>
Message-ID: <iXUbY5gf4crpS5Fg2JWL5UiaFAOvXEA_tJ31zXsUgAQ=.0ded6055-63d2-4208-8faf-2be938995f92@github.com>

On Thu, 7 Aug 2025 11:16:34 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> src/guide/testing-the-jdk.md line 292:
>> 
>>> 290: ProblemListing and `@ignore`-ing are done in the JDK source tree, that means a check-in into the repository is needed. This in turn means that a unique JBS issue and a code review are needed. This is a good thing since it makes test problems visible.
>>> 291: 
>>> 292: * **Code review**: ProblemListing a test is considered a [trivial change]#trivial-changes).
>> 
>> Suggestion:
>> 
>> * **Code review**: ProblemListing a test is considered a [trivial change](#trivial-changes).
>> 
>> Now the opening parenthesis is missing.
>
> I messed up my previous suggestion and I didn't noticed it.

Neither did I...

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/156#discussion_r2259979845

From aivanov at openjdk.org  Thu Aug  7 11:31:29 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 11:31:29 GMT
Subject: RFR: Fix links to #trivial-changes [v4]
In-Reply-To: <FPk3u_tJ5m0T_m1PDnWU_DVllqkNO5SejbeWExwlYqk=.5f176371-23e6-460a-9044-398565c1d860@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
 <FPk3u_tJ5m0T_m1PDnWU_DVllqkNO5SejbeWExwlYqk=.5f176371-23e6-460a-9044-398565c1d860@github.com>
Message-ID: <NWW4Wg_NiJFoP--ss4EFPFMClrofcxW7zyHJoZx9-1g=.51fffc0e-2ba9-4ed1-8be6-69a8925860b2@github.com>

On Thu, 7 Aug 2025 11:26:45 GMT, Manuel H?ssig <mhaessig at openjdk.org> wrote:

>> This simple PR fixes broken links to the "Trivial Changes" section.
>
> Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply suggestions from code review
>   
>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

Looks good to me.

-------------

Marked as reviewed by aivanov (no project role).

PR Review: https://git.openjdk.org/guide/pull/156#pullrequestreview-3096656906

From jwilhelm at openjdk.org  Thu Aug  7 23:10:51 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 7 Aug 2025 23:10:51 GMT
Subject: RFR: Updated AffectsVersion image [v2]
In-Reply-To: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
Message-ID: <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>

> Updated image to make case 5 look more like the previous cases.
> Also fixed a borken link.

Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:

 - Update jbs-jdk-bug-system.md
   
   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
 - Made another pass
 - Restore image some more
 - Restore image
 - Merge branch 'master' of github.com:openjdk/guide into cleanup
 - Update src/guide/jbs-jdk-bug-system.md
   
   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
 - Update src/guide/jbs-jdk-bug-system.md
   
   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
 - Update src/guide/jbs-jdk-bug-system.md
   
   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
 - Update src/guide/jbs-jdk-bug-system.md
   
   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
 - Updated based on Alexey's comments
 - ... and 14 more: https://git.openjdk.org/guide/compare/74b90e8e...be7d4aa9

-------------

Changes: https://git.openjdk.org/guide/pull/149/files
  Webrev: https://webrevs.openjdk.org/?repo=guide&pr=149&range=01
  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/guide/pull/149.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/149/head:pull/149

PR: https://git.openjdk.org/guide/pull/149

From iris at openjdk.org  Thu Aug  7 23:10:51 2025
From: iris at openjdk.org (Iris Clark)
Date: Thu, 7 Aug 2025 23:10:51 GMT
Subject: RFR: Updated AffectsVersion image [v2]
In-Reply-To: <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
Message-ID: <BX5yU7NZzBY2O1M3RNFqxNZH0zdULQ2yM73XDnvCibU=.ce30a8b9-ea0b-457d-8e81-4b0ad6165b6c@github.com>

On Thu, 7 Aug 2025 23:06:10 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Updated image to make case 5 look more like the previous cases.
>> Also fixed a borken link.
>
> Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
> 
>  - Update jbs-jdk-bug-system.md
>    
>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>  - Made another pass
>  - Restore image some more
>  - Restore image
>  - Merge branch 'master' of github.com:openjdk/guide into cleanup
>  - Update src/guide/jbs-jdk-bug-system.md
>    
>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>  - Update src/guide/jbs-jdk-bug-system.md
>    
>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>  - Update src/guide/jbs-jdk-bug-system.md
>    
>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>  - Update src/guide/jbs-jdk-bug-system.md
>    
>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>  - Updated based on Alexey's comments
>  - ... and 14 more: https://git.openjdk.org/guide/compare/74b90e8e...be7d4aa9

Marked as reviewed by iris (Reviewer).

Still an improvement.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/guide/pull/149#pullrequestreview-2788711398
Marked as reviewed by iris (Reviewer).

PR Review: https://git.openjdk.org/guide/pull/149#pullrequestreview-2801745065
PR Review: https://git.openjdk.org/guide/pull/149#pullrequestreview-3073670364

From aivanov at openjdk.org  Thu Aug  7 23:10:52 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 23:10:52 GMT
Subject: RFR: Updated AffectsVersion image [v2]
In-Reply-To: <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
Message-ID: <0K6pliN-mSO0Hs3mecuHAsENcJrQoLAdOVDwTgLta6Y=.ceb11879-38dd-4a8e-837e-b7ac16a09435@github.com>

On Thu, 7 Aug 2025 23:06:10 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Updated image to make case 5 look more like the previous cases.
>> Also fixed a borken link.
>
> Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
> 
>  - Update jbs-jdk-bug-system.md
>    
>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>  - Made another pass
>  - Restore image some more
>  - Restore image
>  - Merge branch 'master' of github.com:openjdk/guide into cleanup
>  - Update src/guide/jbs-jdk-bug-system.md
>    
>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>  - Update src/guide/jbs-jdk-bug-system.md
>    
>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>  - Update src/guide/jbs-jdk-bug-system.md
>    
>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>  - Update src/guide/jbs-jdk-bug-system.md
>    
>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>  - Updated based on Alexey's comments
>  - ... and 14 more: https://git.openjdk.org/guide/compare/74b90e8e...be7d4aa9

Changes requested by aivanov (no project role).

Changes requested by aivanov (no project role).

Looks good to me, with a minor comment.

Marked as reviewed by aivanov (no project role).

src/guide/jbs-jdk-bug-system.md line 125:

> 123: ![Guidelines for setting [Affects Version/s]{.jbs-field}](affects_versions.svg)
> 124: 
> 125: 1. Affects Version contains 8 only, which means this issue is applicable to 8 and all future releases (until it's fixed).

Suggestion:

1. [Affects Version/s]{.jbs-field} contains 8 only, which means this issue is applicable to 8 and all future releases (until it's fixed).

Shall we mark-up the JBS field?

src/guide/jbs-jdk-bug-system.md line 126:

> 124: 
> 125: 1. Affects Version contains 8 only, which means this issue is applicable to 8 and all future releases (until it's fixed).
> 126: 2. Affects Version contains 8, 8u40, 9, and 12, yet 8 already implies that the later releases are affected.

I used strike-through to indicate 8u40, 9, and 12 aren't need, which could also be confusing. Therefore, it makes to explicitly state that 8u40, 9, and 12 should not be added to the Affects Version field.

src/guide/jbs-jdk-bug-system.md line 127:

> 125: 1. Affects Version contains 8 only, which means this issue is applicable to 8 and all future releases (until it's fixed).
> 126: 2. Affects Version contains 8, 8u40, 9, and 12, yet 8 already implies that the later releases are affected.
> 127: 3. Adding the occasional LTS release value is ok.

We should expand the description of case (3) in a similar way:

Suggestion:

3. [Affects Version/s]{.jbs-field} contains 11 and 21. Adding the occasional LTS release version (21 in this example) is fine; 17 is implicitly affected as well as versions after 21.

src/guide/jbs-jdk-bug-system.md line 127:

> 125: 1. [Affects Version/s]{.jbs-field} contains [8]{.jbs-value} only, which means this issue is applicable to JDK 8 and all releases thereafter (until it's fixed).
> 126: 2. [Affects Version/s]{.jbs-field} contains [8]{.jbs-value}, [8u40]{.jbs-value}, [9]{.jbs-value}, and [12]{.jbs-value}. Since [8]{.jbs-value} already implies that later releases are affected, adding other versions are discouraged.
> 127: 3. [Affects Version/s]{.jbs-field} contains [11]{.jbs-value} and [21]{.jbs-value}. Adding occasional versions for actively maintained JDK releases (JDK 21 in this example) is fine; JDK 17 is implicitly affected as well as releases after JDK 21.

Suggestion:

3. [Affects Version/s]{.jbs-field} contains [11]{.jbs-value} and [21]{.jbs-value}. Adding occasional versions of actively maintained JDK releases (JDK 21 in this example) is fine; JDK 17 is implicitly affected as well as releases after JDK 21.

I think ?of? suits better here.

src/guide/jbs-jdk-bug-system.md line 128:

> 126: 2. Affects Version contains 8, 8u40, 9, and 12, yet 8 already implies that the later releases are affected.
> 127: 3. Adding the occasional LTS release value is ok.
> 128: 4. Affects Version contains 8 and the issue is fixed in 11. The 12-na label indicates that the issue is not applicable to 12 and subsequent versions.

Suggestion:

4. Affects Version contains 8 and the issue is fixed in 11. The [12-na]{.jbs-label} label indicates that the issue is not applicable to 12 and subsequent versions.

src/guide/jbs-jdk-bug-system.md line 129:

> 127: 3. Adding the occasional LTS release value is ok.
> 128: 4. Affects Version contains 8 and the issue is fixed in 11. The 12-na label indicates that the issue is not applicable to 12 and subsequent versions.
> 129: 5. Affects Version contains 8, the issue is fixed in 21 and is backported to 17. The label 11-wnf indicates that the fix will not be backported to 11 or 8.

Suggestion:

5. Affects Version contains 8, the issue is fixed in 21 and is backported to 17. The [11-wnf]{.jbs-label} label indicates that the fix will not be backported to 11 or 8.

Mark up the label; I also moved the words for consistency with case 4.

src/images/affects_versions.svg line 1:

> 1: <?xml version="1.0" encoding="UTF-8" standalone="no"?>

Why is 12-na displayed below the affects-versions line? I think the text label should stay aligned to 8 on the left.

Aligning both 12-na and 11-wnf would make the image more appealing (which I did in my version). Yet it may look confusing.

Either way, bullet 5 below the image needs updating to clarify what it illustrates.

https://github.com/openjdk/guide/blob/71fbb94b0b7b3ca75869bc158805971a3fe3d3df/src/guide/jbs-jdk-bug-system.md?plain=1#L129

-------------

PR Review: https://git.openjdk.org/guide/pull/149#pullrequestreview-2802947050
PR Review: https://git.openjdk.org/guide/pull/149#pullrequestreview-3079838063
Marked as reviewed by aivanov (no project role).

PR Review: https://git.openjdk.org/guide/pull/149#pullrequestreview-3093705101
PR Review: https://git.openjdk.org/guide/pull/149#pullrequestreview-3093728812
PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2248376696
PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2248380714
PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2248387497
PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2257921100
PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2248388743
PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2248390747
PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2066049224

From aivanov at openjdk.org  Thu Aug  7 23:10:52 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 23:10:52 GMT
Subject: RFR: Updated AffectsVersion image
In-Reply-To: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
Message-ID: <4GAY3yyMfRKnroVq5BC304yG8BaLI5ojE_aKECEKGBE=.89dda9d6-c7bd-415f-a7ac-7cb03dabf70e@github.com>

On Wed, 23 Apr 2025 17:04:05 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Updated image to make case 5 look more like the previous cases.
> Also fixed a borken link.

Wow, the SVG is huge now.

> Updated image to make case 5 look more like the previous cases.

Perhaps, @calnan's intention was to illustrate that in case 5 an issue was fixed in 21 (therefore there's no arrow, since the issue isn't applicable to later releases), and that the fix was backported to 17 but it will not backported to 11u or 8u.

-------------

PR Comment: https://git.openjdk.org/guide/pull/149#issuecomment-2825414179
PR Comment: https://git.openjdk.org/guide/pull/149#issuecomment-2827464738

From jwilhelm at openjdk.org  Thu Aug  7 23:10:52 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 7 Aug 2025 23:10:52 GMT
Subject: RFR: Updated AffectsVersion image
In-Reply-To: <4GAY3yyMfRKnroVq5BC304yG8BaLI5ojE_aKECEKGBE=.89dda9d6-c7bd-415f-a7ac-7cb03dabf70e@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <4GAY3yyMfRKnroVq5BC304yG8BaLI5ojE_aKECEKGBE=.89dda9d6-c7bd-415f-a7ac-7cb03dabf70e@github.com>
Message-ID: <_yJahtEYKxPni1qConxV2gyiFQGrGHsDAsbtnNeuJzA=.fa5c0aa8-3257-4d3d-918d-0b9fc5ce5375@github.com>

On Wed, 23 Apr 2025 20:18:11 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Updated image to make case 5 look more like the previous cases.
>> Also fixed a borken link.
>
> Wow, the SVG is huge now.

@aivanov-jdk, what program did you use to edit the SVG? I'm using Incscape but it seems to be suboptimal.

-------------

PR Comment: https://git.openjdk.org/guide/pull/149#issuecomment-2825538060

From aivanov at openjdk.org  Thu Aug  7 23:10:53 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 23:10:53 GMT
Subject: RFR: Updated AffectsVersion image
In-Reply-To: <4GAY3yyMfRKnroVq5BC304yG8BaLI5ojE_aKECEKGBE=.89dda9d6-c7bd-415f-a7ac-7cb03dabf70e@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <4GAY3yyMfRKnroVq5BC304yG8BaLI5ojE_aKECEKGBE=.89dda9d6-c7bd-415f-a7ac-7cb03dabf70e@github.com>
Message-ID: <eHS3Y1q7ISXDcDP-mFEPBT-VJy2oaVVCtvntC83NG04=.4fd1c8d6-52c9-457e-8f61-0e6d096ca30d@github.com>

On Wed, 23 Apr 2025 20:18:11 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Updated image to make case 5 look more like the previous cases.
>> Also fixed a borken link.
>
> Wow, the SVG is huge now.

> @aivanov-jdk, what program did you use to edit the SVG? I'm using Incscape but it seems to be suboptimal.

I hand-coded it in IDEA, I find it relaxing and easier than to use a visual editor.

In fairness, I used Inkscape when I started to look at SVG. It's a handy tool for creating complex shapes. A few times, I drafted the image in Inkscape and then simplified the image by hand-coding. [`FocusCycle.svg`](https://raw.githubusercontent.com/openjdk/jdk/refs/heads/master/src/java.desktop/share/classes/java/awt/doc-files/FocusCycle.svg) is a great example of the latter: I drafted the red, green and blue curves in Inkscape and then edited the curves by hand to make them simpler and to get rid of the fractional coordinates.

-------------

PR Comment: https://git.openjdk.org/guide/pull/149#issuecomment-2827384439

From aivanov at openjdk.org  Thu Aug  7 23:10:53 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 23:10:53 GMT
Subject: RFR: Updated AffectsVersion image
In-Reply-To: <_yJahtEYKxPni1qConxV2gyiFQGrGHsDAsbtnNeuJzA=.fa5c0aa8-3257-4d3d-918d-0b9fc5ce5375@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <4GAY3yyMfRKnroVq5BC304yG8BaLI5ojE_aKECEKGBE=.89dda9d6-c7bd-415f-a7ac-7cb03dabf70e@github.com>
 <_yJahtEYKxPni1qConxV2gyiFQGrGHsDAsbtnNeuJzA=.fa5c0aa8-3257-4d3d-918d-0b9fc5ce5375@github.com>
Message-ID: <BpWtefxaqrPvYAr9S2CFmczqxq9OrOhkypATKj9J4AE=.83072ff2-8d73-422c-b70b-2697aa309823@github.com>

On Wed, 23 Apr 2025 21:26:56 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Wow, the SVG is huge now.
>
> @aivanov-jdk, what program did you use to edit the SVG? I'm using Incscape but it seems to be suboptimal.

@JesperIRL Does this look good to you?
https://github.com/openjdk/guide/compare/master...aivanov-jdk:dev-guide:update-affects-versions

![Updated Affects Versions](https://raw.githubusercontent.com/aivanov-jdk/dev-guide/4fb430598594234f867fef7720efc426505e2ac0/src/images/affects_versions.svg)

I left the circles at this time. Removing the circles and making the case 5 line longer is really simple.

-------------

PR Comment: https://git.openjdk.org/guide/pull/149#issuecomment-2827697028

From aivanov at openjdk.org  Thu Aug  7 23:11:26 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 23:11:26 GMT
Subject: Integrated: Update mailman address
In-Reply-To: <Bo15SeZ0Stk3x93-didZjdIBRdatbdyTP60PnbaxExo=.ed30ffc3-6888-4bbe-96ee-e0af1f45f3c5@github.com>
References: <Bo15SeZ0Stk3x93-didZjdIBRdatbdyTP60PnbaxExo=.ed30ffc3-6888-4bbe-96ee-e0af1f45f3c5@github.com>
Message-ID: <noHaarBGeZqOaUgqovtp9bBbIPcswfurqGZuBbk72-M=.18972762-72b0-4b40-bd43-415923246dc9@github.com>

On Fri, 1 Aug 2025 16:50:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> Recently, a person sent an email to `mailman-at-openjdk.org` to change the email address as mentioned in the Guide, yet the email was rejected. The rejection email contained another address `mailman-owner-at-openjdk.org` that worked well. Therefore, I suggest updating the mail-man address in the Guide.
> 
> I also replaced ?discussions _around_? with ?discussions _about_?. This is how mailing lists are described on the page that lists all available OpenJDK mailing lists.

This pull request has now been integrated.

Changeset: 5fdbea70
Author:    Alexey Ivanov <aivanov at openjdk.org>
Committer: Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/5fdbea70811e5bbf2698609822f38252e2b7063b
Stats:     4 lines in 1 file changed: 0 ins; 0 del; 4 mod

Update mailman address

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/guide/pull/154

From jwilhelm at openjdk.org  Thu Aug  7 23:10:53 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 7 Aug 2025 23:10:53 GMT
Subject: RFR: Updated AffectsVersion image
In-Reply-To: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
Message-ID: <3loKU5OveNtxZu6q2osC2yvFe3YlRMeMG3nJRWXgruw=.b1100b40-ed3e-4940-96bf-8a75557da25b@github.com>

On Wed, 23 Apr 2025 17:04:05 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Updated image to make case 5 look more like the previous cases.
> Also fixed a borken link.

Ah, now I see why we were confused here :-)  (5) is talking about backports while the other cases are about whether something is relevant later or not. I extended the line to show that it originates from mainline. Maybe it would be even more clear if there is a left-arrow at the right end of (5)?

I also did an attempt at cleaning up the file. I'm not sure it's worth it for a single image on such a large page, but I'm also not against removing unnecessary characters :-)

I liked the left-arrow :-) At least now it's obvious that there is something different with (5).

Ok, I made another pass over the descriptions and removed my changes to the image.

-------------

PR Comment: https://git.openjdk.org/guide/pull/149#issuecomment-2837142864
PR Comment: https://git.openjdk.org/guide/pull/149#issuecomment-2837146840
PR Comment: https://git.openjdk.org/guide/pull/149#issuecomment-3146507018

From aivanov at openjdk.org  Thu Aug  7 23:10:53 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 23:10:53 GMT
Subject: RFR: Updated AffectsVersion image
In-Reply-To: <3loKU5OveNtxZu6q2osC2yvFe3YlRMeMG3nJRWXgruw=.b1100b40-ed3e-4940-96bf-8a75557da25b@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <3loKU5OveNtxZu6q2osC2yvFe3YlRMeMG3nJRWXgruw=.b1100b40-ed3e-4940-96bf-8a75557da25b@github.com>
Message-ID: <y2exgD2Q3z2T_IacFrpe9DRQ3-5dZ6AS65n_za0pb6Y=.a07482be-e554-4d9d-8166-2f17d19bbed4@github.com>

On Tue, 29 Apr 2025 00:52:23 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> (5) is talking about backports while the other cases are about whether something is relevant later or not. I extended the line to show that it originates from mainline.

This doesn't make sense?

In this example, mainline was 21 at the time the issue was fixed. Therefore, the line of Affects Versions had to end at 21 where the issue is fixed.

Then, it was decided to backport the fix to 17u (completed now); yet it was decided not to backport the fix to 11u.

> Maybe it would be even more clear if there is a left-arrow at the right end of (5)?

Sorry, but I don't think it makes things clearer? rather more confusing.

> I also did an attempt at cleaning up the file. I'm not sure it's worth it for a single image on such a large page, but I'm also not against removing unnecessary characters :-)

I don't think it's reasonable to clean up after editing in Inkscape.

At the same time, I'm providing the version which is still small.

https://github.com/openjdk/guide/compare/master...aivanov-jdk:dev-guide:update-affects-versions

![Updated Affects Versions](https://raw.githubusercontent.com/openjdk/guide/13ebe135a979889400bb82e8ca38156be8a6b400/src/images/affects_versions.svg)

> Ok, I made another pass over the descriptions and removed my changes to the image.

@JesperIRL May I get a contributor attribution for this change?

> @JesperIRL This pull request has not yet been marked as ready for integration.

Do you need to remove *Draft* status from the PR before integrating?

-------------

PR Comment: https://git.openjdk.org/guide/pull/149#issuecomment-2838291209
PR Comment: https://git.openjdk.org/guide/pull/149#issuecomment-2838296966
PR Comment: https://git.openjdk.org/guide/pull/149#issuecomment-3161290072

From jwilhelm at openjdk.org  Thu Aug  7 23:10:53 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 7 Aug 2025 23:10:53 GMT
Subject: RFR: Updated AffectsVersion image [v2]
In-Reply-To: <0K6pliN-mSO0Hs3mecuHAsENcJrQoLAdOVDwTgLta6Y=.ceb11879-38dd-4a8e-837e-b7ac16a09435@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
 <0K6pliN-mSO0Hs3mecuHAsENcJrQoLAdOVDwTgLta6Y=.ceb11879-38dd-4a8e-837e-b7ac16a09435@github.com>
Message-ID: <qGymm7ZuIHm3sEjIhqpBD6mA1cvs87dQj6JKeg0DXs0=.bb661ecb-3957-4d56-b24c-9a1e189dfe6c@github.com>

On Fri, 1 Aug 2025 16:20:00 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
>> 
>>  - Update jbs-jdk-bug-system.md
>>    
>>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>>  - Made another pass
>>  - Restore image some more
>>  - Restore image
>>  - Merge branch 'master' of github.com:openjdk/guide into cleanup
>>  - Update src/guide/jbs-jdk-bug-system.md
>>    
>>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>>  - Update src/guide/jbs-jdk-bug-system.md
>>    
>>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>>  - Update src/guide/jbs-jdk-bug-system.md
>>    
>>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>>  - Update src/guide/jbs-jdk-bug-system.md
>>    
>>    Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>>  - Updated based on Alexey's comments
>>  - ... and 14 more: https://git.openjdk.org/guide/compare/74b90e8e...be7d4aa9
>
> src/guide/jbs-jdk-bug-system.md line 125:
> 
>> 123: ![Guidelines for setting [Affects Version/s]{.jbs-field}](affects_versions.svg)
>> 124: 
>> 125: 1. Affects Version contains 8 only, which means this issue is applicable to 8 and all future releases (until it's fixed).
> 
> Suggestion:
> 
> 1. [Affects Version/s]{.jbs-field} contains 8 only, which means this issue is applicable to 8 and all future releases (until it's fixed).
> 
> Shall we mark-up the JBS field?

Right. I meant to do that but pushed in a hurry when I left the office... ?

> src/images/affects_versions.svg line 1:
> 
>> 1: <?xml version="1.0" encoding="UTF-8" standalone="no"?>
> 
> Why is 12-na displayed below the affects-versions line? I think the text label should stay aligned to 8 on the left.
> 
> Aligning both 12-na and 11-wnf would make the image more appealing (which I did in my version). Yet it may look confusing.
> 
> Either way, bullet 5 below the image needs updating to clarify what it illustrates.
> 
> https://github.com/openjdk/guide/blob/71fbb94b0b7b3ca75869bc158805971a3fe3d3df/src/guide/jbs-jdk-bug-system.md?plain=1#L129

I can't really think of a better way to phrase bullet 5 without it becoming quite long. Do you have a suggestion?
As for the image, since you have the clean image already, maybe it's better if you create a separate PR to push that one, and I'll remove the image from this PR?

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2248600022
PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2162774492

From aivanov at openjdk.org  Thu Aug  7 23:10:53 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 23:10:53 GMT
Subject: RFR: Updated AffectsVersion image [v2]
In-Reply-To: <qGymm7ZuIHm3sEjIhqpBD6mA1cvs87dQj6JKeg0DXs0=.bb661ecb-3957-4d56-b24c-9a1e189dfe6c@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
 <0K6pliN-mSO0Hs3mecuHAsENcJrQoLAdOVDwTgLta6Y=.ceb11879-38dd-4a8e-837e-b7ac16a09435@github.com>
 <qGymm7ZuIHm3sEjIhqpBD6mA1cvs87dQj6JKeg0DXs0=.bb661ecb-3957-4d56-b24c-9a1e189dfe6c@github.com>
Message-ID: <i5oP6d1zUIbnjqC8nCHccXpsxfyJJltDC9PhCojsnCg=.aa2ee680-146b-41aa-8c9f-4982d7e0335a@github.com>

On Fri, 1 Aug 2025 18:28:54 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> src/guide/jbs-jdk-bug-system.md line 125:
>> 
>>> 123: ![Guidelines for setting [Affects Version/s]{.jbs-field}](affects_versions.svg)
>>> 124: 
>>> 125: 1. Affects Version contains 8 only, which means this issue is applicable to 8 and all future releases (until it's fixed).
>> 
>> Suggestion:
>> 
>> 1. [Affects Version/s]{.jbs-field} contains 8 only, which means this issue is applicable to 8 and all future releases (until it's fixed).
>> 
>> Shall we mark-up the JBS field?
>
> Right. I meant to do that but pushed in a hurry when I left the office... ?

I see.

Then this should be applied to all the five cases.

>> src/images/affects_versions.svg line 1:
>> 
>>> 1: <?xml version="1.0" encoding="UTF-8" standalone="no"?>
>> 
>> Why is 12-na displayed below the affects-versions line? I think the text label should stay aligned to 8 on the left.
>> 
>> Aligning both 12-na and 11-wnf would make the image more appealing (which I did in my version). Yet it may look confusing.
>> 
>> Either way, bullet 5 below the image needs updating to clarify what it illustrates.
>> 
>> https://github.com/openjdk/guide/blob/71fbb94b0b7b3ca75869bc158805971a3fe3d3df/src/guide/jbs-jdk-bug-system.md?plain=1#L129
>
> I can't really think of a better way to phrase bullet 5 without it becoming quite long. Do you have a suggestion?
> As for the image, since you have the clean image already, maybe it's better if you create a separate PR to push that one, and I'll remove the image from this PR?

@JesperIRL Yeah! I'll create a new PR.

> I can't really think of a better way to phrase bullet 5 without it becoming quite long. Do you have a suggestion?

Should we describe each example with words to make it clearer?

Let bullet 5 become longer if it makes things clear.

Sorry for my delayed reply.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2248614097
PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2180846328

From jwilhelm at openjdk.org  Thu Aug  7 23:10:53 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 7 Aug 2025 23:10:53 GMT
Subject: RFR: Updated AffectsVersion image [v2]
In-Reply-To: <i5oP6d1zUIbnjqC8nCHccXpsxfyJJltDC9PhCojsnCg=.aa2ee680-146b-41aa-8c9f-4982d7e0335a@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
 <0K6pliN-mSO0Hs3mecuHAsENcJrQoLAdOVDwTgLta6Y=.ceb11879-38dd-4a8e-837e-b7ac16a09435@github.com>
 <qGymm7ZuIHm3sEjIhqpBD6mA1cvs87dQj6JKeg0DXs0=.bb661ecb-3957-4d56-b24c-9a1e189dfe6c@github.com>
 <i5oP6d1zUIbnjqC8nCHccXpsxfyJJltDC9PhCojsnCg=.aa2ee680-146b-41aa-8c9f-4982d7e0335a@github.com>
Message-ID: <tKaeW3hlMwwxwI9kfX0NPgsrkISPpLCQ4vk2wHP0AUU=.caa5f29b-cc83-4091-b598-c2f7b8cb5f59@github.com>

On Wed, 2 Jul 2025 19:43:22 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I can't really think of a better way to phrase bullet 5 without it becoming quite long. Do you have a suggestion?
>> As for the image, since you have the clean image already, maybe it's better if you create a separate PR to push that one, and I'll remove the image from this PR?
>
> @JesperIRL Yeah! I'll create a new PR.
> 
>> I can't really think of a better way to phrase bullet 5 without it becoming quite long. Do you have a suggestion?
> 
> Should we describe each example with words to make it clearer?
> 
> Let bullet 5 become longer if it makes things clear.
> 
> Sorry for my delayed reply.

Ok. Did some more changes. The image should be fairly clean and makes more sense now with the updated descriptions, I think. My main problem with the old descriptions was that they repeated how to use the labels rather than explaining the situation in the example.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2245177975

From aivanov at openjdk.org  Thu Aug  7 23:10:53 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 23:10:53 GMT
Subject: RFR: Updated AffectsVersion image [v2]
In-Reply-To: <tKaeW3hlMwwxwI9kfX0NPgsrkISPpLCQ4vk2wHP0AUU=.caa5f29b-cc83-4091-b598-c2f7b8cb5f59@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
 <0K6pliN-mSO0Hs3mecuHAsENcJrQoLAdOVDwTgLta6Y=.ceb11879-38dd-4a8e-837e-b7ac16a09435@github.com>
 <qGymm7ZuIHm3sEjIhqpBD6mA1cvs87dQj6JKeg0DXs0=.bb661ecb-3957-4d56-b24c-9a1e189dfe6c@github.com>
 <i5oP6d1zUIbnjqC8nCHccXpsxfyJJltDC9PhCojsnCg=.aa2ee680-146b-41aa-8c9f-4982d7e0335a@github.com>
 <tKaeW3hlMwwxwI9kfX0NPgsrkISPpLCQ4vk2wHP0AUU=.caa5f29b-cc83-4091-b598-c2f7b8cb5f59@github.com>
Message-ID: <22bVLY72abXi9Ub8k18UxR78GXbU0Z2nnZOQorq_q7k=.7e7f733e-c604-449c-9de3-ea70b5dfa631@github.com>

On Thu, 31 Jul 2025 11:58:12 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> @JesperIRL Yeah! I'll create a new PR.
>> 
>>> I can't really think of a better way to phrase bullet 5 without it becoming quite long. Do you have a suggestion?
>> 
>> Should we describe each example with words to make it clearer?
>> 
>> Let bullet 5 become longer if it makes things clear.
>> 
>> Sorry for my delayed reply.
>
> Ok. Did some more changes. The image should be fairly clean and makes more sense now with the updated descriptions, I think. My main problem with the old descriptions was that they repeated how to use the labels rather than explaining the situation in the example.

I've been working on high priority issues, I still am?

Anyway I've raised my own pull request in #153. Both versions of the image look nearly identical: my version has smaller arrows and smaller circles; both `12-na` and `11-wnf` are aligned.

What I particularly don't like about positioning the text closer to the lines is that the ends of commas in case 2 is hidden by the timeline line.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2245924460

From aivanov at openjdk.org  Thu Aug  7 23:10:53 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 23:10:53 GMT
Subject: RFR: Updated AffectsVersion image [v2]
In-Reply-To: <22bVLY72abXi9Ub8k18UxR78GXbU0Z2nnZOQorq_q7k=.7e7f733e-c604-449c-9de3-ea70b5dfa631@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
 <0K6pliN-mSO0Hs3mecuHAsENcJrQoLAdOVDwTgLta6Y=.ceb11879-38dd-4a8e-837e-b7ac16a09435@github.com>
 <qGymm7ZuIHm3sEjIhqpBD6mA1cvs87dQj6JKeg0DXs0=.bb661ecb-3957-4d56-b24c-9a1e189dfe6c@github.com>
 <i5oP6d1zUIbnjqC8nCHccXpsxfyJJltDC9PhCojsnCg=.aa2ee680-146b-41aa-8c9f-4982d7e0335a@github.com>
 <tKaeW3hlMwwxwI9kfX0NPgsrkISPpLCQ4vk2wHP0AUU=.caa5f29b-cc83-4091-b598-c2f7b8cb5f59@github.com>
 <22bVLY72abXi9Ub8k18UxR78GXbU0Z2nnZOQorq_q7k=.7e7f733e-c604-449c-9de3-ea70b5dfa631@github.com>
Message-ID: <T27PAWJUfGRWoRV1uSjWpHptYu0_x8So17dFuBHZpu0=.966fb5a5-f437-4483-bf19-ddf4e278be71@github.com>

On Thu, 31 Jul 2025 16:59:32 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ok. Did some more changes. The image should be fairly clean and makes more sense now with the updated descriptions, I think. My main problem with the old descriptions was that they repeated how to use the labels rather than explaining the situation in the example.
>
> I've been working on high priority issues, I still am?
> 
> Anyway I've raised my own pull request in #153. Both versions of the image look nearly identical: my version has smaller arrows and smaller circles; both `12-na` and `11-wnf` are aligned.
> 
> What I particularly don't like about positioning the text closer to the lines is that the ends of commas in case 2 is hidden by the timeline line.

> My main problem with the old descriptions was that they repeated how to use the labels rather than explaining the situation in the example.

Yes, that's the thing! I've been thinking about it too. Does it makes sense to expand the descriptions of the cases like this:

1. Affects Version contains 8 only which means this issue is applicable to 8 and all future releases (until it's fixed).
2. Affects Version contains 8, ~~8u40, 9 and 12~~, yet 8 already implies that these releases are affected.
3. (no change)
4. Affects Version contains 8, the issue is fixed in 11; then the `12-na` label indicates the issue is not applicable to 12 and subsequent versions.
5. Affects Version contains 8, the issue is fixed in 21 and is backported to 17; the label `11-wnf` indicates the fix will not be backported to 11 or 8.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2245945985

From aivanov at openjdk.org  Thu Aug  7 23:10:53 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 23:10:53 GMT
Subject: RFR: Updated AffectsVersion image [v2]
In-Reply-To: <T27PAWJUfGRWoRV1uSjWpHptYu0_x8So17dFuBHZpu0=.966fb5a5-f437-4483-bf19-ddf4e278be71@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
 <0K6pliN-mSO0Hs3mecuHAsENcJrQoLAdOVDwTgLta6Y=.ceb11879-38dd-4a8e-837e-b7ac16a09435@github.com>
 <qGymm7ZuIHm3sEjIhqpBD6mA1cvs87dQj6JKeg0DXs0=.bb661ecb-3957-4d56-b24c-9a1e189dfe6c@github.com>
 <i5oP6d1zUIbnjqC8nCHccXpsxfyJJltDC9PhCojsnCg=.aa2ee680-146b-41aa-8c9f-4982d7e0335a@github.com>
 <tKaeW3hlMwwxwI9kfX0NPgsrkISPpLCQ4vk2wHP0AUU=.caa5f29b-cc83-4091-b598-c2f7b8cb5f59@github.com>
 <22bVLY72abXi9Ub8k18UxR78GXbU0Z2nnZOQorq_q7k=.7e7f733e-c604-449c-9de3-ea70b5dfa631@github.com>
 <T27PAWJUfGRWoRV1uSjWpHptYu0_x8So17dFuBHZpu0=.966fb5a5-f437-4483-bf19-ddf4e278be71@github.com>
Message-ID: <He1NH1OdVhmKwEsEvZjuTYZtRSy4HPDi1PBsb5bpMmw=.50209f2d-3a07-4ddf-9eda-5044e6fb2180@github.com>

On Thu, 31 Jul 2025 17:08:59 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I've been working on high priority issues, I still am?
>> 
>> Anyway I've raised my own pull request in #153. Both versions of the image look nearly identical: my version has smaller arrows and smaller circles; both `12-na` and `11-wnf` are aligned.
>> 
>> What I particularly don't like about positioning the text closer to the lines is that the ends of commas in case 2 is hidden by the timeline line.
>
>> My main problem with the old descriptions was that they repeated how to use the labels rather than explaining the situation in the example.
> 
> Yes, that's the thing! I've been thinking about it too. Does it makes sense to expand the descriptions of the cases like this:
> 
> 1. Affects Version contains 8 only which means this issue is applicable to 8 and all future releases (until it's fixed).
> 2. Affects Version contains 8, ~~8u40, 9 and 12~~, yet 8 already implies that these releases are affected.
> 3. (no change)
> 4. Affects Version contains 8, the issue is fixed in 11; then the `12-na` label indicates the issue is not applicable to 12 and subsequent versions.
> 5. Affects Version contains 8, the issue is fixed in 21 and is backported to 17; the label `11-wnf` indicates the fix will not be backported to 11 or 8.

I think such longer descriptions will make the image more accessible: anyone who relies on screen reader for accessibility wouldn't be able to figure out what's displayed on the image.

The section with the image is titled **Examples**, and the image provides the five examples. However, the examples aren't as clear, which is proved by the discussion in this PR.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2246319835

From jwilhelm at openjdk.org  Thu Aug  7 23:10:53 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 7 Aug 2025 23:10:53 GMT
Subject: RFR: Updated AffectsVersion image [v2]
In-Reply-To: <He1NH1OdVhmKwEsEvZjuTYZtRSy4HPDi1PBsb5bpMmw=.50209f2d-3a07-4ddf-9eda-5044e6fb2180@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
 <0K6pliN-mSO0Hs3mecuHAsENcJrQoLAdOVDwTgLta6Y=.ceb11879-38dd-4a8e-837e-b7ac16a09435@github.com>
 <qGymm7ZuIHm3sEjIhqpBD6mA1cvs87dQj6JKeg0DXs0=.bb661ecb-3957-4d56-b24c-9a1e189dfe6c@github.com>
 <i5oP6d1zUIbnjqC8nCHccXpsxfyJJltDC9PhCojsnCg=.aa2ee680-146b-41aa-8c9f-4982d7e0335a@github.com>
 <tKaeW3hlMwwxwI9kfX0NPgsrkISPpLCQ4vk2wHP0AUU=.caa5f29b-cc83-4091-b598-c2f7b8cb5f59@github.com>
 <22bVLY72abXi9Ub8k18UxR78GXbU0Z2nnZOQorq_q7k=.7e7f733e-c604-449c-9de3-ea70b5dfa631@github.com>
 <T27PAWJUfGRWoRV1uSjWpHptYu0_x8So17dFuBHZpu0=.966fb5a5-f437-4483-bf19-ddf4e278be71@github.com>
 <He1NH1OdVhmKwEsEvZjuTYZtRSy4HPDi1PBsb5bpMmw=.50209f2d-3a07-4ddf-9eda-5044e6fb2180@github.com>
Message-ID: <9t1rNO6Ygrz3fW5tz74tlQv-tPDi4fT6Lbn96etyihY=.200341cb-e637-4451-847b-0b1ae5f08eaf@github.com>

On Thu, 31 Jul 2025 20:31:20 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> My main problem with the old descriptions was that they repeated how to use the labels rather than explaining the situation in the example.
>> 
>> Yes, that's the thing! I've been thinking about it too. Does it makes sense to expand the descriptions of the cases like this:
>> 
>> 1. Affects Version contains 8 only which means this issue is applicable to 8 and all future releases (until it's fixed).
>> 2. Affects Version contains 8, ~~8u40, 9 and 12~~, yet 8 already implies that these releases are affected.
>> 3. (no change)
>> 4. Affects Version contains 8, the issue is fixed in 11; then the `12-na` label indicates the issue is not applicable to 12 and subsequent versions.
>> 5. Affects Version contains 8, the issue is fixed in 21 and is backported to 17; the label `11-wnf` indicates the fix will not be backported to 11 or 8.
>
> I think such longer descriptions will make the image more accessible: anyone who relies on screen reader for accessibility wouldn't be able to figure out what's displayed on the image.
> 
> The section with the image is titled **Examples**, and the image provides the five examples. However, the examples aren't as clear, which is proved by the discussion in this PR.

Yes, your descriptions are better. I have updated to use them with just minor edits.
I approved #153. If you integrate it before this is integrated I'll make sure to not touch the image in this PR :-)

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2248290933

From aivanov at openjdk.org  Thu Aug  7 23:10:54 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 23:10:54 GMT
Subject: RFR: Updated AffectsVersion image [v2]
In-Reply-To: <9t1rNO6Ygrz3fW5tz74tlQv-tPDi4fT6Lbn96etyihY=.200341cb-e637-4451-847b-0b1ae5f08eaf@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
 <0K6pliN-mSO0Hs3mecuHAsENcJrQoLAdOVDwTgLta6Y=.ceb11879-38dd-4a8e-837e-b7ac16a09435@github.com>
 <qGymm7ZuIHm3sEjIhqpBD6mA1cvs87dQj6JKeg0DXs0=.bb661ecb-3957-4d56-b24c-9a1e189dfe6c@github.com>
 <i5oP6d1zUIbnjqC8nCHccXpsxfyJJltDC9PhCojsnCg=.aa2ee680-146b-41aa-8c9f-4982d7e0335a@github.com>
 <tKaeW3hlMwwxwI9kfX0NPgsrkISPpLCQ4vk2wHP0AUU=.caa5f29b-cc83-4091-b598-c2f7b8cb5f59@github.com>
 <22bVLY72abXi9Ub8k18UxR78GXbU0Z2nnZOQorq_q7k=.7e7f733e-c604-449c-9de3-ea70b5dfa631@github.com>
 <T27PAWJUfGRWoRV1uSjWpHptYu0_x8So17dFuBHZpu0=.966fb5a5-f437-4483-bf19-ddf4e278be71@github.com>
 <He1NH1OdVhmKwEsEvZjuTYZtRSy4HPDi1PBsb5bpMmw=.50209f2d-3a07-4ddf-9eda-5044e6fb2180@github.com>
 <9t1rNO6Ygrz3fW5tz74tlQv-tPDi4fT6Lbn96etyihY=.200341cb-e637-4451-847b-0b1ae5f08eaf@github.com>
Message-ID: <sCVG88yeZVcBi_cXG5CIVMz6ONif1vxKDD26VBwkw5w=.496b4cb9-c35b-458e-8601-4b838276c603@github.com>

On Fri, 1 Aug 2025 15:40:16 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> I think such longer descriptions will make the image more accessible: anyone who relies on screen reader for accessibility wouldn't be able to figure out what's displayed on the image.
>> 
>> The section with the image is titled **Examples**, and the image provides the five examples. However, the examples aren't as clear, which is proved by the discussion in this PR.
>
> Yes, your descriptions are better. I have updated to use them with just minor edits.
> I approved #153. If you integrate it before this is integrated I'll make sure to not touch the image in this PR :-)

Thanks!

I issued the `/integrate` command in that PR.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2248391647

From aivanov at openjdk.org  Thu Aug  7 23:10:54 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Thu, 7 Aug 2025 23:10:54 GMT
Subject: RFR: Updated AffectsVersion image [v2]
In-Reply-To: <sCVG88yeZVcBi_cXG5CIVMz6ONif1vxKDD26VBwkw5w=.496b4cb9-c35b-458e-8601-4b838276c603@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
 <2UWd1qEQ0ZMCEjIKJNlRf1AWEbS9G6uePrbAKohNNQI=.3c995d48-7a17-481a-9ef4-cb724a8805a0@github.com>
 <0K6pliN-mSO0Hs3mecuHAsENcJrQoLAdOVDwTgLta6Y=.ceb11879-38dd-4a8e-837e-b7ac16a09435@github.com>
 <qGymm7ZuIHm3sEjIhqpBD6mA1cvs87dQj6JKeg0DXs0=.bb661ecb-3957-4d56-b24c-9a1e189dfe6c@github.com>
 <i5oP6d1zUIbnjqC8nCHccXpsxfyJJltDC9PhCojsnCg=.aa2ee680-146b-41aa-8c9f-4982d7e0335a@github.com>
 <tKaeW3hlMwwxwI9kfX0NPgsrkISPpLCQ4vk2wHP0AUU=.caa5f29b-cc83-4091-b598-c2f7b8cb5f59@github.com>
 <22bVLY72abXi9Ub8k18UxR78GXbU0Z2nnZOQorq_q7k=.7e7f733e-c604-449c-9de3-ea70b5dfa631@github.com>
 <T27PAWJUfGRWoRV1uSjWpHptYu0_x8So17dFuBHZpu0=.966fb5a5-f437-4483-bf19-ddf4e278be71@github.com>
 <He1NH1OdVhmKwEsEvZjuTYZtRSy4HPDi1PBsb5bpMmw=.50209f2d-3a07-4ddf-9eda-5044e6fb2180@github.com>
 <9t1rNO6Ygrz3fW5tz74tlQv-tPDi4fT6Lbn96etyihY=.200341cb-e637-4451-847b-0b1ae5f08eaf@github.com>
 <sCVG88yeZVcBi_cXG5CIVMz6ONif1vxKDD2
 6VBwkw5w=.496b4cb9-c35b-458e-8601-4b838276c603@github.com>
Message-ID: <07Nvepn23WKAROqwHx41mFJhc6A4GdwKPTxqJWW1cbw=.20966ffb-28c4-4400-ab7d-c6595fc1c7b8@github.com>

On Fri, 1 Aug 2025 16:28:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Yes, your descriptions are better. I have updated to use them with just minor edits.
>> I approved #153. If you integrate it before this is integrated I'll make sure to not touch the image in this PR :-)
>
> Thanks!
> 
> I issued the `/integrate` command in that PR.

> Yes, your descriptions are better. I have updated to use them with just minor edits.

@JesperIRL May I get a contributor attribution?

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2257926572

From jwilhelm at openjdk.org  Fri Aug  8 04:08:25 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 8 Aug 2025 04:08:25 GMT
Subject: RFR: Fix links to #trivial-changes [v4]
In-Reply-To: <FPk3u_tJ5m0T_m1PDnWU_DVllqkNO5SejbeWExwlYqk=.5f176371-23e6-460a-9044-398565c1d860@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
 <FPk3u_tJ5m0T_m1PDnWU_DVllqkNO5SejbeWExwlYqk=.5f176371-23e6-460a-9044-398565c1d860@github.com>
Message-ID: <-NmGW5dSuOTRosj60UTDBLdeO59aZsn8derJmtbqbmw=.1f754dbe-7fde-4d17-b171-fa7d11dc4cc0@github.com>

On Thu, 7 Aug 2025 11:26:45 GMT, Manuel H?ssig <mhaessig at openjdk.org> wrote:

>> This simple PR fixes broken links to the "Trivial Changes" section.
>
> Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply suggestions from code review
>   
>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

Looks good

-------------

Marked as reviewed by jwilhelm (Lead).

PR Review: https://git.openjdk.org/guide/pull/156#pullrequestreview-3099388519

From jwilhelm at openjdk.org  Fri Aug  8 04:17:29 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 8 Aug 2025 04:17:29 GMT
Subject: RFR: Amend Requesting a change
In-Reply-To: <4WMJJY9hKOVMrPfSHUGdQ96Ui8vkW9SJZkykLzPoy4Y=.d98db63a-d247-4f39-9219-848952ed8970@github.com>
References: <4WMJJY9hKOVMrPfSHUGdQ96Ui8vkW9SJZkykLzPoy4Y=.d98db63a-d247-4f39-9219-848952ed8970@github.com>
Message-ID: <bA7RMEg0ioTKi2I5rTGl67pcYyZQgJaHq7M9BObBPoA=.e72ba48f-0a2e-4d50-b423-01d9f36a4b07@github.com>

On Wed, 6 Aug 2025 19:35:49 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> A follow-up to #155 where I submitted suggestions after the issue was integrated. I applied [my suggestions](https://github.com/openjdk/guide/pull/155#discussion_r2257971819) in this PR.
> 
> * Fix a few typos;
> * Clarify the sentences.

Looks good.

-------------

Marked as reviewed by jwilhelm (Lead).

PR Review: https://git.openjdk.org/guide/pull/157#pullrequestreview-3099400448

From jwilhelm at openjdk.org  Fri Aug  8 04:20:27 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 8 Aug 2025 04:20:27 GMT
Subject: Integrated: Updated AffectsVersion image
In-Reply-To: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
References: <shCte7VWPPlvSceOME42honwF2fbUPChZqs7khprP3E=.45c9ccce-2d02-4eb7-90b2-580e2af1af5a@github.com>
Message-ID: <D1IBQx1u95mR_pZRXCHn9s9ZACbIE_n2YZ1VxfvU2z8=.95a67e62-b31a-4c30-a1c5-1dd517410829@github.com>

On Wed, 23 Apr 2025 17:04:05 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Updated image to make case 5 look more like the previous cases.
> Also fixed a borken link.

This pull request has now been integrated.

Changeset: 13fc384f
Author:    Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/13fc384fd41d8610b43c921b9c020075c079f2ff
Stats:     6 lines in 1 file changed: 0 ins; 0 del; 6 mod

Updated AffectsVersion image

Reviewed-by: iris, aivanov

-------------

PR: https://git.openjdk.org/guide/pull/149

From iris at openjdk.org  Fri Aug  8 04:26:26 2025
From: iris at openjdk.org (Iris Clark)
Date: Fri, 8 Aug 2025 04:26:26 GMT
Subject: RFR: Amend Requesting a change
In-Reply-To: <4WMJJY9hKOVMrPfSHUGdQ96Ui8vkW9SJZkykLzPoy4Y=.d98db63a-d247-4f39-9219-848952ed8970@github.com>
References: <4WMJJY9hKOVMrPfSHUGdQ96Ui8vkW9SJZkykLzPoy4Y=.d98db63a-d247-4f39-9219-848952ed8970@github.com>
Message-ID: <NMl48bHI7VT5hbw8Ldqqp1TrN_WRAGN1F_F8qzk2keY=.eff970c5-1322-4cc9-9b64-0ae58e818abf@github.com>

On Wed, 6 Aug 2025 19:35:49 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> A follow-up to #155 where I submitted suggestions after the issue was integrated. I applied [my suggestions](https://github.com/openjdk/guide/pull/155#discussion_r2257971819) in this PR.
> 
> * Fix a few typos;
> * Clarify the sentences.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/guide/pull/157#pullrequestreview-3099414977

From iris at openjdk.org  Fri Aug  8 04:28:27 2025
From: iris at openjdk.org (Iris Clark)
Date: Fri, 8 Aug 2025 04:28:27 GMT
Subject: RFR: Fix links to #trivial-changes [v4]
In-Reply-To: <FPk3u_tJ5m0T_m1PDnWU_DVllqkNO5SejbeWExwlYqk=.5f176371-23e6-460a-9044-398565c1d860@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
 <FPk3u_tJ5m0T_m1PDnWU_DVllqkNO5SejbeWExwlYqk=.5f176371-23e6-460a-9044-398565c1d860@github.com>
Message-ID: <9IYRzIH3A5TwmGCm5oHsx0m0pvPCNT9VOqiD4-GUgsE=.f0cfbc17-b086-4e89-bfc2-b71ef1d34219@github.com>

On Thu, 7 Aug 2025 11:26:45 GMT, Manuel H?ssig <mhaessig at openjdk.org> wrote:

>> This simple PR fixes broken links to the "Trivial Changes" section.
>
> Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply suggestions from code review
>   
>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/guide/pull/156#pullrequestreview-3099416898

From mhaessig at openjdk.org  Fri Aug  8 07:30:29 2025
From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=)
Date: Fri, 8 Aug 2025 07:30:29 GMT
Subject: RFR: Fix links to #trivial-changes [v4]
In-Reply-To: <FPk3u_tJ5m0T_m1PDnWU_DVllqkNO5SejbeWExwlYqk=.5f176371-23e6-460a-9044-398565c1d860@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
 <FPk3u_tJ5m0T_m1PDnWU_DVllqkNO5SejbeWExwlYqk=.5f176371-23e6-460a-9044-398565c1d860@github.com>
Message-ID: <5CgwFcbSU1zZzY2gcnW4KS3xQ9j30jdJfX7SfS7qSb8=.62304e84-a284-47f0-97f8-6f0fd665c200@github.com>

On Thu, 7 Aug 2025 11:26:45 GMT, Manuel H?ssig <mhaessig at openjdk.org> wrote:

>> This simple PR fixes broken links to the "Trivial Changes" section.
>
> Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply suggestions from code review
>   
>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

Thank you all for reviewing!

-------------

PR Comment: https://git.openjdk.org/guide/pull/156#issuecomment-3166846251

From duke at openjdk.org  Fri Aug  8 07:30:29 2025
From: duke at openjdk.org (duke)
Date: Fri, 8 Aug 2025 07:30:29 GMT
Subject: RFR: Fix links to #trivial-changes [v4]
In-Reply-To: <FPk3u_tJ5m0T_m1PDnWU_DVllqkNO5SejbeWExwlYqk=.5f176371-23e6-460a-9044-398565c1d860@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
 <FPk3u_tJ5m0T_m1PDnWU_DVllqkNO5SejbeWExwlYqk=.5f176371-23e6-460a-9044-398565c1d860@github.com>
Message-ID: <SOIWVqoGAMj-CXFVrosc7zRaa3pMBvx-qgah_v7Hm9I=.6b5d40c6-59e2-4094-921e-a6085b4c46c0@github.com>

On Thu, 7 Aug 2025 11:26:45 GMT, Manuel H?ssig <mhaessig at openjdk.org> wrote:

>> This simple PR fixes broken links to the "Trivial Changes" section.
>
> Manuel H?ssig has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply suggestions from code review
>   
>   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>

@mhaessig 
Your change (at version bc4dbab02fe887323da5e6da6660614d9442bb53) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/guide/pull/156#issuecomment-3166848645

From mhaessig at openjdk.org  Fri Aug  8 17:36:28 2025
From: mhaessig at openjdk.org (Manuel =?UTF-8?B?SMOkc3NpZw==?=)
Date: Fri, 8 Aug 2025 17:36:28 GMT
Subject: Integrated: Fix links to #trivial-changes
In-Reply-To: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
References: <p2CcSNO8T2t42bNZQSm0vAxhWzqfZhVCcfq46QLQVw0=.894d582c-531d-47ee-91a2-07aa084bfa1a@github.com>
Message-ID: <u5OsmFmJdNP66Msc_o_Ls6EPq20M4oiMwYDFOhStDZM=.2e9d8417-8b5e-474c-bd4b-5376dc167cbb@github.com>

On Mon, 4 Aug 2025 11:59:12 GMT, Manuel H?ssig <mhaessig at openjdk.org> wrote:

> This simple PR fixes broken links to the "Trivial Changes" section.

This pull request has now been integrated.

Changeset: a5a8e50d
Author:    Manuel H?ssig <mhaessig at openjdk.org>
Committer: Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/a5a8e50d9ec60dd61c1db437f764be13da29d534
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

Fix links to #trivial-changes

Reviewed-by: aivanov, jwilhelm, iris

-------------

PR: https://git.openjdk.org/guide/pull/156

From duke at openjdk.org  Fri Aug  8 18:36:30 2025
From: duke at openjdk.org (duke)
Date: Fri, 8 Aug 2025 18:36:30 GMT
Subject: RFR: Amend Requesting a change
In-Reply-To: <4WMJJY9hKOVMrPfSHUGdQ96Ui8vkW9SJZkykLzPoy4Y=.d98db63a-d247-4f39-9219-848952ed8970@github.com>
References: <4WMJJY9hKOVMrPfSHUGdQ96Ui8vkW9SJZkykLzPoy4Y=.d98db63a-d247-4f39-9219-848952ed8970@github.com>
Message-ID: <8Lrtw2dY24cRfRyFhwtOsP1Ohsodo6MJnLgIBOeXQ6k=.09af5c8e-6953-486a-adca-ae6985be1e11@github.com>

On Wed, 6 Aug 2025 19:35:49 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> A follow-up to #155 where I submitted suggestions after the issue was integrated. I applied [my suggestions](https://github.com/openjdk/guide/pull/155#discussion_r2257971819) in this PR.
> 
> * Fix a few typos;
> * Clarify the sentences.

@aivanov-jdk 
Your change (at version c4d103c082ddcf3e55c905575319001fd79081a6) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/guide/pull/157#issuecomment-3168966069