RFR: Fix links to #trivial-changes

Alexey Ivanov aivanov at openjdk.org
Wed Aug 6 18:55:34 UTC 2025


On Mon, 4 Aug 2025 11:59:12 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

> This simple PR fixes broken links to the "Trivial Changes" section.

src/guide/testing-the-jdk.md line 292:

> 290: ProblemListing and `@ignore`-ing are done in the JDK source tree, that means a check-in into the repository is needed. This in turn means that a unique JBS issue and a code review are needed. This is a good thing since it makes test problems visible.
> 291: 
> 292: * **Code review**: ProblemListing a test is considered a [trivial]#trivial-changes) change.

Suggestion:

* **Code review**: ProblemListing a test is considered a [trivial change]#trivial-changes).

To align with other usages?

src/guide/testing-the-jdk.md line 307:

> 305: It will happen of course when the build is broken or the JDK is DOA and similar situations that a change is immediately backed out without further investigation. Backing out a change is however seldom the first course of action if the change has been done in accordance with the guidance in [Working With Pull Requests]. If, when investigated, it is found that a change didn't go through relevant testing or there are other issues that should have been caught before integration if proper procedure had been followed, it's quite possible that a change is backed out even if the author is desperately working on a fix. The JDK source code is deliberately menat to have a high bar for acceptance of changes. If something crawls in underneath that bar it should most likely be backed out.
> 306: 
> 307: The backout is a regular change and will have to go through the standard code review process, but is considered a [trivial](#trivial-changes) change. The rationale is that a backout is usually urgent in nature and the change itself is automatically generated. In areas where two reviewers are normally required, only one [Reviewer](https://openjdk.org/bylaws#reviewer) is required for a backout since the person who is performing the backout also should review the change.

Suggestion:

The backout is a regular change and will have to go through the standard code review process, but is considered a [trivial change](#trivial-changes). The rationale is that a backout is usually urgent in nature and the change itself is automatically generated. In areas where two reviewers are normally required, only one [Reviewer](https://openjdk.org/bylaws#reviewer) is required for a backout since the person who is performing the backout also should review the change.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/156#discussion_r2258005353
PR Review Comment: https://git.openjdk.org/guide/pull/156#discussion_r2258006824


More information about the guide-dev mailing list