RFR: Requesting a change [v8]

Alexey Ivanov aivanov at openjdk.org
Wed Aug 6 19:40:34 UTC 2025


On Wed, 6 Aug 2025 18:44:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed typos
>
> src/guide/jbs-jdk-bug-system.md line 652:
> 
>> 650:                            [[nounit-]{.jbs-label}`.*`]{#nounit}</td>
>> 651:     <td class="dictionary">
>> 652:       The [noreg-]{.jbs-label}`.*` and [nounit-]{.jbs-label}`.*` labels are used to explain why a change doesn't need/have a regression test or a unit test. The suffix of the label is described below. Every change that is integrated into the JDK source code must either have a regression/unit test, or have at least one of these labels on its JBS issue. It's quite possible to have more than one of these labels on the same issue. For instance, an integration could contain both changes to documentation and test code. In that case it would be logical to label the issue with both [noreg-doc]{.jbs-label} and [noreg-self]{.jbs-label}.
> 
> Suggestion:
> 
>       The [noreg-]{.jbs-label}`.*` and [nounit-]{.jbs-label}`.*` labels are used to explain why a change doesn't need/have a regression test or a unit test. The suffix of the label is described below. Every change that is integrated into the JDK source code must either have a regression/unit test, or have at least one of these labels on its JBS issue. It's possible to have more than one of these labels on the same issue. For instance, a changeset could contain both changes to documentation and test code. In that case it would be logical to label the issue with both [noreg-doc]{.jbs-label} and [noreg-self]{.jbs-label}.
> 
> “An integration” sounds confusing. To avoid having “changeset” and “changes” close in one sentence, you could state: “a change could modify both…”
> 
> “Quite” doesn't clarify the meaning, the sentence is clearer without it.

I applied my suggestions and submitted #157.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/155#discussion_r2258099120


More information about the guide-dev mailing list