RFR: Updated AffectsVersion image [v2]
Jesper Wilhelmsson
jwilhelm at openjdk.org
Thu Aug 7 23:10:53 UTC 2025
On Fri, 1 Aug 2025 16:20:00 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
>>
>> - Update jbs-jdk-bug-system.md
>>
>> Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>> - Made another pass
>> - Restore image some more
>> - Restore image
>> - Merge branch 'master' of github.com:openjdk/guide into cleanup
>> - Update src/guide/jbs-jdk-bug-system.md
>>
>> Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>> - Update src/guide/jbs-jdk-bug-system.md
>>
>> Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>> - Update src/guide/jbs-jdk-bug-system.md
>>
>> Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>> - Update src/guide/jbs-jdk-bug-system.md
>>
>> Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>> - Updated based on Alexey's comments
>> - ... and 14 more: https://git.openjdk.org/guide/compare/74b90e8e...be7d4aa9
>
> src/guide/jbs-jdk-bug-system.md line 125:
>
>> 123: ![Guidelines for setting [Affects Version/s]{.jbs-field}](affects_versions.svg)
>> 124:
>> 125: 1. Affects Version contains 8 only, which means this issue is applicable to 8 and all future releases (until it's fixed).
>
> Suggestion:
>
> 1. [Affects Version/s]{.jbs-field} contains 8 only, which means this issue is applicable to 8 and all future releases (until it's fixed).
>
> Shall we mark-up the JBS field?
Right. I meant to do that but pushed in a hurry when I left the office... 😅
> src/images/affects_versions.svg line 1:
>
>> 1: <?xml version="1.0" encoding="UTF-8" standalone="no"?>
>
> Why is 12-na displayed below the affects-versions line? I think the text label should stay aligned to 8 on the left.
>
> Aligning both 12-na and 11-wnf would make the image more appealing (which I did in my version). Yet it may look confusing.
>
> Either way, bullet 5 below the image needs updating to clarify what it illustrates.
>
> https://github.com/openjdk/guide/blob/71fbb94b0b7b3ca75869bc158805971a3fe3d3df/src/guide/jbs-jdk-bug-system.md?plain=1#L129
I can't really think of a better way to phrase bullet 5 without it becoming quite long. Do you have a suggestion?
As for the image, since you have the clean image already, maybe it's better if you create a separate PR to push that one, and I'll remove the image from this PR?
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2248600022
PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2162774492
More information about the guide-dev
mailing list