RFR: Updated AffectsVersion image [v2]
Alexey Ivanov
aivanov at openjdk.org
Thu Aug 7 23:10:53 UTC 2025
On Thu, 31 Jul 2025 11:58:12 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:
>> @JesperIRL Yeah! I'll create a new PR.
>>
>>> I can't really think of a better way to phrase bullet 5 without it becoming quite long. Do you have a suggestion?
>>
>> Should we describe each example with words to make it clearer?
>>
>> Let bullet 5 become longer if it makes things clear.
>>
>> Sorry for my delayed reply.
>
> Ok. Did some more changes. The image should be fairly clean and makes more sense now with the updated descriptions, I think. My main problem with the old descriptions was that they repeated how to use the labels rather than explaining the situation in the example.
I've been working on high priority issues, I still am…
Anyway I've raised my own pull request in #153. Both versions of the image look nearly identical: my version has smaller arrows and smaller circles; both `12-na` and `11-wnf` are aligned.
What I particularly don't like about positioning the text closer to the lines is that the ends of commas in case 2 is hidden by the timeline line.
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/149#discussion_r2245924460
More information about the guide-dev
mailing list