From jwilhelm at openjdk.org Fri Dec 5 15:04:38 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Fri, 5 Dec 2025 15:04:38 GMT Subject: RFR: Updated code owners for JDK 26 Message-ID: Updated code owners for JDK 26 ------------- Commit messages: - Updated code owners for JDK 26 Changes: https://git.openjdk.org/guide/pull/165/files Webrev: https://webrevs.openjdk.org/?repo=guide&pr=165&range=00 Stats: 5 lines in 2 files changed: 1 ins; 1 del; 3 mod Patch: https://git.openjdk.org/guide/pull/165.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/165/head:pull/165 PR: https://git.openjdk.org/guide/pull/165 From iris at openjdk.org Fri Dec 5 15:04:39 2025 From: iris at openjdk.org (Iris Clark) Date: Fri, 5 Dec 2025 15:04:39 GMT Subject: RFR: Updated code owners for JDK 26 In-Reply-To: References: Message-ID: On Tue, 2 Dec 2025 20:20:08 GMT, Jesper Wilhelmsson wrote: > Updated code owners for JDK 26 Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/guide/pull/165#pullrequestreview-3532041514 From jwilhelm at openjdk.org Fri Dec 5 15:13:39 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Fri, 5 Dec 2025 15:13:39 GMT Subject: Integrated: Updated code owners for JDK 26 In-Reply-To: References: Message-ID: On Tue, 2 Dec 2025 20:20:08 GMT, Jesper Wilhelmsson wrote: > Updated code owners for JDK 26 This pull request has now been integrated. Changeset: bdbd6e01 Author: Jesper Wilhelmsson URL: https://git.openjdk.org/guide/commit/bdbd6e01476142a9aa17907a4aadcb411acf5762 Stats: 5 lines in 2 files changed: 1 ins; 1 del; 3 mod Updated code owners for JDK 26 Reviewed-by: iris ------------- PR: https://git.openjdk.org/guide/pull/165 From jwilhelm at openjdk.org Fri Dec 12 00:05:45 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Fri, 12 Dec 2025 00:05:45 GMT Subject: RFR: Clarified resolving release notes Message-ID: A little more info. ------------- Commit messages: - Clarified resolving release notes Changes: https://git.openjdk.org/guide/pull/166/files Webrev: https://webrevs.openjdk.org/?repo=guide&pr=166&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/guide/pull/166.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/166/head:pull/166 PR: https://git.openjdk.org/guide/pull/166 From bchristi at openjdk.org Fri Dec 12 00:05:55 2025 From: bchristi at openjdk.org (Brent Christian) Date: Fri, 12 Dec 2025 00:05:55 GMT Subject: RFR: Clarified resolving release notes In-Reply-To: References: Message-ID: On Thu, 11 Dec 2025 23:58:57 GMT, Jesper Wilhelmsson wrote: > A little more info. Better, thanks! ------------- Marked as reviewed by bchristi (no project role). PR Review: https://git.openjdk.org/guide/pull/166#pullrequestreview-3569772009 From iris at openjdk.org Fri Dec 12 00:23:59 2025 From: iris at openjdk.org (Iris Clark) Date: Fri, 12 Dec 2025 00:23:59 GMT Subject: RFR: Clarified resolving release notes In-Reply-To: References: Message-ID: On Thu, 11 Dec 2025 23:58:57 GMT, Jesper Wilhelmsson wrote: > A little more info. Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/guide/pull/166#pullrequestreview-3569805840 From jwilhelm at openjdk.org Mon Dec 15 21:21:38 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Mon, 15 Dec 2025 21:21:38 GMT Subject: Integrated: Clarified resolving release notes In-Reply-To: References: Message-ID: <7pK51Rb5io4mfEjZT14dcq2ccOI67HExPmKD3Qjsc1Y=.11571b40-488c-4d62-b45b-6d782246f886@github.com> On Thu, 11 Dec 2025 23:58:57 GMT, Jesper Wilhelmsson wrote: > A little more info. This pull request has now been integrated. Changeset: 9f18ff18 Author: Jesper Wilhelmsson URL: https://git.openjdk.org/guide/commit/9f18ff18fa126cf9003838ced5d111a367d528f2 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Clarified resolving release notes Reviewed-by: bchristi, iris ------------- PR: https://git.openjdk.org/guide/pull/166 From duke at openjdk.org Thu Dec 18 14:48:36 2025 From: duke at openjdk.org (Roger Calnan) Date: Thu, 18 Dec 2025 14:48:36 GMT Subject: RFR: cover the documentation linking options in release notes Message-ID: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com> added an explanation on the support of JavaDoc like links and the automatic linking of JBS IDs ------------- Commit messages: - adjust case of text in section headings - cover the documentation linking options in release notes Changes: https://git.openjdk.org/guide/pull/167/files Webrev: https://webrevs.openjdk.org/?repo=guide&pr=167&range=00 Stats: 25 lines in 2 files changed: 24 ins; 0 del; 1 mod Patch: https://git.openjdk.org/guide/pull/167.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/167/head:pull/167 PR: https://git.openjdk.org/guide/pull/167 From iris at openjdk.org Thu Dec 18 16:12:25 2025 From: iris at openjdk.org (Iris Clark) Date: Thu, 18 Dec 2025 16:12:25 GMT Subject: RFR: cover the documentation linking options in release notes In-Reply-To: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com> References: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com> Message-ID: On Thu, 18 Dec 2025 14:43:24 GMT, Roger Calnan wrote: > added an explanation on the support of JavaDoc like links and the automatic linking of JBS IDs Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/guide/pull/167#pullrequestreview-3593768353 From jwilhelm at openjdk.org Thu Dec 18 16:32:20 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Thu, 18 Dec 2025 16:32:20 GMT Subject: RFR: cover the documentation linking options in release notes In-Reply-To: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com> References: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com> Message-ID: On Thu, 18 Dec 2025 14:43:24 GMT, Roger Calnan wrote: > added an explanation on the support of JavaDoc like links and the automatic linking of JBS IDs src/guide/release-notes.md line 74: > 72: As well as the standard [CommonMark link types](https://spec.commonmark.org/0.31.2/#links) the following custom links are supported: > 73: > 74: **Linking of JBS issues** Please use actual headers (###) instead of **bold text** for these three sub-sections. src/guide/release-notes.md line 76: > 74: **Linking of JBS issues** > 75: > 76: * any JBS ID of the form `JDK-NNNNNNN` will be linked Please use complete sentences with capital letter and period in all bullets. src/guide/release-notes.md line 81: > 79: > 80: * the linking options defined in JavaDoc [MarkDown](https://openjdk.org/jeps/467#Links) are supported. > 81: * links to the JDK tools is supported. To differentiate between `[JarSigner]` the class, and `[jarsigner]` the tool, the tool reference should be in all lowercase. I think it would be nice if "JDK tools" was a link to the tools page. I know it's version specific, but the JDK 25 page should be good enough for a few years :-) ------------- PR Review Comment: https://git.openjdk.org/guide/pull/167#discussion_r2631742403 PR Review Comment: https://git.openjdk.org/guide/pull/167#discussion_r2631748436 PR Review Comment: https://git.openjdk.org/guide/pull/167#discussion_r2631754342 From duke at openjdk.org Thu Dec 18 18:18:33 2025 From: duke at openjdk.org (Roger Calnan) Date: Thu, 18 Dec 2025 18:18:33 GMT Subject: RFR: cover the documentation linking options in release notes In-Reply-To: References: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com> Message-ID: On Thu, 18 Dec 2025 16:24:07 GMT, Jesper Wilhelmsson wrote: >> added an explanation on the support of JavaDoc like links and the automatic linking of JBS IDs > > src/guide/release-notes.md line 74: > >> 72: As well as the standard [CommonMark link types](https://spec.commonmark.org/0.31.2/#links) the following custom links are supported: >> 73: >> 74: **Linking of JBS issues** > > Please use actual headers (###) instead of **bold text** for these three sub-sections. yes, I looked at that and was going to use ### but then decided it didn't make sense for them to appear in the index, I can make them ### if you feel it would be better ------------- PR Review Comment: https://git.openjdk.org/guide/pull/167#discussion_r2632092636 From duke at openjdk.org Thu Dec 18 18:52:01 2025 From: duke at openjdk.org (Roger Calnan) Date: Thu, 18 Dec 2025 18:52:01 GMT Subject: RFR: cover the documentation linking options in release notes [v2] In-Reply-To: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com> References: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com> Message-ID: > added an explanation on the support of JavaDoc like links and the automatic linking of JBS IDs Roger Calnan has updated the pull request incrementally with one additional commit since the last revision: formatting changes ------------- Changes: - all: https://git.openjdk.org/guide/pull/167/files - new: https://git.openjdk.org/guide/pull/167/files/8c8422da..803195dc Webrevs: - full: https://webrevs.openjdk.org/?repo=guide&pr=167&range=01 - incr: https://webrevs.openjdk.org/?repo=guide&pr=167&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/guide/pull/167.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/167/head:pull/167 PR: https://git.openjdk.org/guide/pull/167 From duke at openjdk.org Thu Dec 18 18:52:04 2025 From: duke at openjdk.org (Roger Calnan) Date: Thu, 18 Dec 2025 18:52:04 GMT Subject: RFR: cover the documentation linking options in release notes [v2] In-Reply-To: References: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com> Message-ID: On Thu, 18 Dec 2025 16:25:59 GMT, Jesper Wilhelmsson wrote: >> Roger Calnan has updated the pull request incrementally with one additional commit since the last revision: >> >> formatting changes > > src/guide/release-notes.md line 76: > >> 74: **Linking of JBS issues** >> 75: >> 76: * any JBS ID of the form `JDK-NNNNNNN` will be linked > > Please use complete sentences with capital letter and period in all bullets. done > src/guide/release-notes.md line 81: > >> 79: >> 80: * the linking options defined in JavaDoc [MarkDown](https://openjdk.org/jeps/467#Links) are supported. >> 81: * links to the JDK tools is supported. To differentiate between `[JarSigner]` the class, and `[jarsigner]` the tool, the tool reference should be in all lowercase. > > I think it would be nice if "JDK tools" was a link to the tools page. I know it's version specific, but the JDK 25 page should be good enough for a few years :-) you mean [JDK tools] should be a link to the tools page? ------------- PR Review Comment: https://git.openjdk.org/guide/pull/167#discussion_r2632258674 PR Review Comment: https://git.openjdk.org/guide/pull/167#discussion_r2632252561 From duke at openjdk.org Mon Dec 22 12:54:34 2025 From: duke at openjdk.org (Roger Calnan) Date: Mon, 22 Dec 2025 12:54:34 GMT Subject: RFR: cover the documentation linking options in release notes [v3] In-Reply-To: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com> References: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com> Message-ID: > added an explanation on the support of JavaDoc like links and the automatic linking of JBS IDs Roger Calnan has updated the pull request incrementally with one additional commit since the last revision: additional notes ------------- Changes: - all: https://git.openjdk.org/guide/pull/167/files - new: https://git.openjdk.org/guide/pull/167/files/803195dc..c8597bd8 Webrevs: - full: https://webrevs.openjdk.org/?repo=guide&pr=167&range=02 - incr: https://webrevs.openjdk.org/?repo=guide&pr=167&range=01-02 Stats: 15 lines in 1 file changed: 5 ins; 0 del; 10 mod Patch: https://git.openjdk.org/guide/pull/167.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/167/head:pull/167 PR: https://git.openjdk.org/guide/pull/167 From duke at openjdk.org Mon Dec 22 12:54:36 2025 From: duke at openjdk.org (Roger Calnan) Date: Mon, 22 Dec 2025 12:54:36 GMT Subject: RFR: cover the documentation linking options in release notes [v3] In-Reply-To: References: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com> Message-ID: On Thu, 18 Dec 2025 18:16:19 GMT, Roger Calnan wrote: >> src/guide/release-notes.md line 74: >> >>> 72: As well as the standard [CommonMark link types](https://spec.commonmark.org/0.31.2/#links) the following custom links are supported: >>> 73: >>> 74: **Linking of JBS issues** >> >> Please use actual headers (###) instead of **bold text** for these three sub-sections. > > yes, I looked at that and was going to use ### but then decided it didn't make sense for them to appear in the index, I can make them ### if you feel it would be better changed them to ### - the index is sufficiently long that adding a couple more is probably fine ------------- PR Review Comment: https://git.openjdk.org/guide/pull/167#discussion_r2639789696