From iris at openjdk.org  Thu Feb 20 20:22:06 2025
From: iris at openjdk.org (Iris Clark)
Date: Thu, 20 Feb 2025 20:22:06 GMT
Subject: RFR: Put toc on the side
In-Reply-To: <U2nNCkYkeRW5b5qsKyIk0IHjfRreR4XjjfCuZqW1TaI=.a7e2a1e0-2d79-498f-9240-f4247bace21c@github.com>
References: <U2nNCkYkeRW5b5qsKyIk0IHjfRreR4XjjfCuZqW1TaI=.a7e2a1e0-2d79-498f-9240-f4247bace21c@github.com>
Message-ID: <DWOZhetMLT_n2YPc54F6YCI0EhWU5ZPXV6oNe-Yn1UI=.cdeec1ab-8537-4b79-8143-159bcc07902b@github.com>

On Thu, 20 Feb 2025 19:56:07 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Fix the table of contents to the right side for easier navigation.
> Also some minor bug fixes.

Nice improvements.  Thanks for the updates!

-------------

Marked as reviewed by iris (Reviewer).

PR Review: https://git.openjdk.org/guide/pull/142#pullrequestreview-2631060691

From jwilhelm at openjdk.org  Fri Feb 21 00:02:05 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 21 Feb 2025 00:02:05 GMT
Subject: Integrated: Put toc on the side
In-Reply-To: <U2nNCkYkeRW5b5qsKyIk0IHjfRreR4XjjfCuZqW1TaI=.a7e2a1e0-2d79-498f-9240-f4247bace21c@github.com>
References: <U2nNCkYkeRW5b5qsKyIk0IHjfRreR4XjjfCuZqW1TaI=.a7e2a1e0-2d79-498f-9240-f4247bace21c@github.com>
Message-ID: <WRjkFAJp0chm6KnhhmKT8SljUIL3Th7dBu0RMRCZJ7Q=.2748385b-1cb9-4987-a73d-bec0ae6d22a4@github.com>

On Thu, 20 Feb 2025 19:56:07 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Fix the table of contents to the right side for easier navigation.
> Also some minor bug fixes.

This pull request has now been integrated.

Changeset: 55047cea
Author:    Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/55047cea8e334b7ceaab5a6ad9cc62dc1836b58a
Stats:     39 lines in 3 files changed: 22 ins; 3 del; 14 mod

Put toc on the side

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/guide/pull/142

From jwilhelm at openjdk.org  Fri Feb 21 16:31:40 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 21 Feb 2025 16:31:40 GMT
Subject: RFR: Reminder to remove label
Message-ID: <lnxQXLCyg_mTY_Hdq3dU3i1e9srSvSzuz_mjsXyrB4E=.c6612d25-83cc-4d1e-b520-2b74cc5f6d04@github.com>

Reminder to remove label

-------------

Commit messages:
 - Reminder to remove label

Changes: https://git.openjdk.org/guide/pull/136/files
  Webrev: https://webrevs.openjdk.org/?repo=guide&pr=136&range=00
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/136.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/136/head:pull/136

PR: https://git.openjdk.org/guide/pull/136

From iris at openjdk.org  Fri Feb 21 17:03:09 2025
From: iris at openjdk.org (Iris Clark)
Date: Fri, 21 Feb 2025 17:03:09 GMT
Subject: RFR: Reminder to remove label
In-Reply-To: <lnxQXLCyg_mTY_Hdq3dU3i1e9srSvSzuz_mjsXyrB4E=.c6612d25-83cc-4d1e-b520-2b74cc5f6d04@github.com>
References: <lnxQXLCyg_mTY_Hdq3dU3i1e9srSvSzuz_mjsXyrB4E=.c6612d25-83cc-4d1e-b520-2b74cc5f6d04@github.com>
Message-ID: <cJwj2g3k0ZGlfabAHDI_mHkCsN-nQ-y8XrZRzVDxl7Q=.e95f174f-a32c-4dcd-9e77-3e0a167d3b46@github.com>

On Tue, 22 Oct 2024 15:22:04 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Reminder to remove label

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/guide/pull/136#pullrequestreview-2633711713

From duke at openjdk.org  Fri Feb 21 18:12:08 2025
From: duke at openjdk.org (Suren K)
Date: Fri, 21 Feb 2025 18:12:08 GMT
Subject: RFR: Reminder to remove label
In-Reply-To: <lnxQXLCyg_mTY_Hdq3dU3i1e9srSvSzuz_mjsXyrB4E=.c6612d25-83cc-4d1e-b520-2b74cc5f6d04@github.com>
References: <lnxQXLCyg_mTY_Hdq3dU3i1e9srSvSzuz_mjsXyrB4E=.c6612d25-83cc-4d1e-b520-2b74cc5f6d04@github.com>
Message-ID: <Zl-1Yl5wxS1ez5uZ40HwpnU1E-CsTtFTLvdnWzc6zt8=.a5b7e9ec-2e3d-4a03-899d-84765ca9988f@github.com>

On Tue, 22 Oct 2024 15:22:04 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Reminder to remove label

this change looks good @JesperIRL

Need any help on this ?

-------------

Marked as reviewed by thesurenk at github.com (no known OpenJDK username).

PR Review: https://git.openjdk.org/guide/pull/136#pullrequestreview-2633605815
PR Comment: https://git.openjdk.org/guide/pull/136#issuecomment-2675006592

From duke at openjdk.org  Wed Feb 26 21:02:34 2025
From: duke at openjdk.org (Roger Calnan)
Date: Wed, 26 Feb 2025 21:02:34 GMT
Subject: RFR: Follow-on update due to the introduction of caused-by links
Message-ID: <Gh3SabkLGEmoWLw6cKersOkdgFQLiQR_N0-9j9OhB90=.1cd1ff8c-34c9-4447-abaf-bee63b7876ee@github.com>

Noted that the label regression_ID is now deprecated and a caused-by link should be used.  Fixed a couple of typos

-------------

Commit messages:
 - small update to deprecated sentence
 - Noted that the label regression_ID is now deprecated and a caused-by link should be used.  Fixed a couple of typos

Changes: https://git.openjdk.org/guide/pull/143/files
  Webrev: https://webrevs.openjdk.org/?repo=guide&pr=143&range=00
  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/guide/pull/143.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/143/head:pull/143

PR: https://git.openjdk.org/guide/pull/143

From iris at openjdk.org  Thu Feb 27 00:54:05 2025
From: iris at openjdk.org (Iris Clark)
Date: Thu, 27 Feb 2025 00:54:05 GMT
Subject: RFR: Follow-on update due to the introduction of caused-by links
In-Reply-To: <Gh3SabkLGEmoWLw6cKersOkdgFQLiQR_N0-9j9OhB90=.1cd1ff8c-34c9-4447-abaf-bee63b7876ee@github.com>
References: <Gh3SabkLGEmoWLw6cKersOkdgFQLiQR_N0-9j9OhB90=.1cd1ff8c-34c9-4447-abaf-bee63b7876ee@github.com>
Message-ID: <nZkqnRSnvYUx1QjD-UydXiHwJUgrrAYTksXGknu2MO8=.42c4fca4-33dd-45c8-8c5c-e40043ecb8d6@github.com>

On Wed, 26 Feb 2025 20:57:39 GMT, Roger Calnan <duke at openjdk.org> wrote:

> Noted that the label regression_ID is now deprecated and a caused-by link should be used.  Fixed a couple of typos

src/guide/jbs-jdk-bug-system.md line 84:

> 82: 1) If an issue is applicable to release N, then it can't be assumed that it is applicable to older releases less than N. It may be, but in general this is less important to know, as the majority of issues are only fixed in the latest feature release. If the issue is a crash or important in another way, then it becomes worthwhile to take the time to determine if it's relevant to earlier LTS releases.
> 83: 
> 84: Another aspect of an issue is when the feature, it's a part of, was added or removed from the JDK, which in either case limits the range of releases the issue impacts. Knowing that a feature was removed before the oldest currently maintained release means it can be resolved as [Won't Fix]{.jbs-value}.

Maybe "... when a part of the feature was added ...".  I'm not sure because that may change the intent.

src/guide/jbs-jdk-bug-system.md line 128:

> 126: 2. No need to add additional releases as they are implied.
> 127: 3. Adding the occasional LTS release value is ok.
> 128: 4. Use N-na to indicate that the issue is no longer relevant from that release, which could be due to the feature or platform being removed or the code has been rewritten.

I think that "being rewritten" was correct since it parallels the earlier "being removed".

src/guide/jbs-jdk-bug-system.md line 739:

> 737:     <td class="dictionary">[[regression_]{.jbs-label}*(ID)*]{#regression_id}</td>
> 738:     <td class="dictionary">
> 739:       **Deprecated.** Was used to identify the fix that caused the regression, where known. Has been replaced by the use of the [caused by]{.jbs-value} link.

Maybe "**Formerly** used to identify...".

Also either "**This label** has been replaced by the use..." or "**Replaced** by the use..."

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/143#discussion_r1972635376
PR Review Comment: https://git.openjdk.org/guide/pull/143#discussion_r1972636220
PR Review Comment: https://git.openjdk.org/guide/pull/143#discussion_r1972638661

From jwilhelm at openjdk.org  Thu Feb 27 13:08:08 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 27 Feb 2025 13:08:08 GMT
Subject: RFR: Follow-on update due to the introduction of caused-by links
In-Reply-To: <nZkqnRSnvYUx1QjD-UydXiHwJUgrrAYTksXGknu2MO8=.42c4fca4-33dd-45c8-8c5c-e40043ecb8d6@github.com>
References: <Gh3SabkLGEmoWLw6cKersOkdgFQLiQR_N0-9j9OhB90=.1cd1ff8c-34c9-4447-abaf-bee63b7876ee@github.com>
 <nZkqnRSnvYUx1QjD-UydXiHwJUgrrAYTksXGknu2MO8=.42c4fca4-33dd-45c8-8c5c-e40043ecb8d6@github.com>
Message-ID: <G9qowJcGxdO_dyVe3Hv3szc0KNdSSvYuMafnoBWpEIk=.16e7ab92-452e-47ac-a13b-15aed3f13011@github.com>

On Thu, 27 Feb 2025 00:46:48 GMT, Iris Clark <iris at openjdk.org> wrote:

>> Noted that the label regression_ID is now deprecated and a caused-by link should be used.  Fixed a couple of typos
>
> src/guide/jbs-jdk-bug-system.md line 84:
> 
>> 82: 1) If an issue is applicable to release N, then it can't be assumed that it is applicable to older releases less than N. It may be, but in general this is less important to know, as the majority of issues are only fixed in the latest feature release. If the issue is a crash or important in another way, then it becomes worthwhile to take the time to determine if it's relevant to earlier LTS releases.
>> 83: 
>> 84: Another aspect of an issue is when the feature, it's a part of, was added or removed from the JDK, which in either case limits the range of releases the issue impacts. Knowing that a feature was removed before the oldest currently maintained release means it can be resolved as [Won't Fix]{.jbs-value}.
> 
> Maybe "... when a part of the feature was added ...".  I'm not sure because that may change the intent.

This could be more generalized since it doesn't only hold for features, but basically any code.
"...is when the impacted code was added or..."

> src/guide/jbs-jdk-bug-system.md line 128:
> 
>> 126: 2. No need to add additional releases as they are implied.
>> 127: 3. Adding the occasional LTS release value is ok.
>> 128: 4. Use N-na to indicate that the issue is no longer relevant from that release, which could be due to the feature or platform being removed or the code has been rewritten.
> 
> I think that "being rewritten" was correct since it parallels the earlier "being removed".

Agree with Iris.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/143#discussion_r1973543486
PR Review Comment: https://git.openjdk.org/guide/pull/143#discussion_r1973545172

From aivanov at openjdk.org  Fri Feb 28 16:48:12 2025
From: aivanov at openjdk.org (Alexey Ivanov)
Date: Fri, 28 Feb 2025 16:48:12 GMT
Subject: RFR: Reminder to remove label
In-Reply-To: <lnxQXLCyg_mTY_Hdq3dU3i1e9srSvSzuz_mjsXyrB4E=.c6612d25-83cc-4d1e-b520-2b74cc5f6d04@github.com>
References: <lnxQXLCyg_mTY_Hdq3dU3i1e9srSvSzuz_mjsXyrB4E=.c6612d25-83cc-4d1e-b520-2b74cc5f6d04@github.com>
Message-ID: <SL-MnUzYX5y-q3ISFwGpoykpkSyhr-AJ1DqFN_vdY8E=.e9211528-0324-47fa-a864-366750826637@github.com>

On Tue, 22 Oct 2024 15:22:04 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Reminder to remove label

Marked as reviewed by aivanov (no project role).

-------------

PR Review: https://git.openjdk.org/guide/pull/136#pullrequestreview-2651276546