RFR: Addition of a causes link type [v3]

Roger Calnan duke at openjdk.org
Tue Jan 21 19:24:05 UTC 2025


On Tue, 14 Jan 2025 18:54:34 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Roger Calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updates from feedback - restructured the section on the causes/caused by link, moving most of the text into other relevant sections of the guide
>
> src/guide/backporting.md line 32:
> 
>> 30: Testing each individual change is more likely to find issues than just testing the single merged change. It's also easier and less error prone to use the `/backport` command on each commit instead of manually cherrypick and deal with the merges etc.
>> 31: 
>> 32: Whenever looking to backport a fix the developer should look for both ‘blocked by’ and ‘causes’ links in order to understand the set of fixes that should be backported. Likewise, if A has already been backported the new causes linked issues will need to be assessed to see if it is important enough to be backported as well.
> 
> Suggestion:
> 
> Whenever looking to backport a fix the developer should look for both ‘blocked by’ and ‘causes’ links in order to understand the set of fixes that should be backported. Likewise, if A has already been backported the new ‘causes’ linked issues will need to be assessed to see if it is important enough to be backported as well.
> 
> Maybe even use _italics_ for the relation ship type? “…for both _‘blocked by’_ and ‘_causes’_ links…” and “…the new _‘causes’_ linked issues…”

checked with Jesper and have changed them all to [name]{.jbs-value}

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/139#discussion_r1924254047


More information about the guide-dev mailing list