From aph at openjdk.org  Sun Jun  1 16:12:16 2025
From: aph at openjdk.org (Andrew Haley)
Date: Sun, 1 Jun 2025 16:12:16 GMT
Subject: RFR: Get agreement before PR
In-Reply-To: <uAjQPLeDvsH9M2BpWPMn4UzJBApxLXX4cbjm7bmqXK4=.a1807821-b1f2-4206-b748-24409a27a0c7@github.com>
References: <C1NyQt2GUpVeo_JsJHMXRUyG9Xs-sBMAY7rNkXU8NT0=.205ddb89-b322-4e39-9e7a-e6520845c999@github.com>
 <iPtQpHrtgzFyM9TB5R3Ofk4Py2meP5ZMJ1PFsmcKQyI=.2f9210d4-dd5c-4f02-879e-3a0578546d2e@github.com>
 <uAjQPLeDvsH9M2BpWPMn4UzJBApxLXX4cbjm7bmqXK4=.a1807821-b1f2-4206-b748-24409a27a0c7@github.com>
Message-ID: <YmdtWXoBIXCvabJSDEgBu1wh6cZYVNo4n2vWSqIXhIA=.beb0f05b-c9d9-49cf-8624-69adb96d098a@github.com>

On Tue, 13 May 2025 22:07:44 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> src/guide/contributing-to-an-open-jdk-project.md line 65:
>> 
>>> 63: ### 3. Find a Sponsor
>>> 64: 
>>> 65: Socializing your change on the mailing lists also prevents the surprise that would otherwise make the community choke on their morning coffee when they see a huge patch in a new, unknown PR. As a new developer in the community you'll need to make a few friends that agree with your change. There are many good reasons to make friends, but the one relevant here is that for your first changes you'll need a [Sponsor](https://openjdk.org/bylaws#sponsor) to facilitate the integration of your work. The [Sponsor](https://openjdk.org/bylaws#sponsor) will perform any number of administrative tasks like JBS updates, additional testing, etc. It's usual for a [Sponsor](https://openjdk.org/bylaws#sponsor) to also be a reviewer of a change and thus familiar with it, but it's not a requirement.
>> 
>> Imho "for your first changes" is misleading here. I contributed lots of commits, but still do need a sponsor even after years. We should find a wording which does not give the impression that contributing many commits over several years will change anything on the fact that a sponsor *still* is mandatory for each PR.
>
> If I'm not mistaken you have contributed 16 changes over the last three and a half year. I haven't looked at them in detail, but provided these aren't trivial changes or changes that caused more harm than good, you should be eligible for a Committer role in the JDK project and thereby not be needing a Sponsor.

Socializing your change on the mailing lists also prevents the surprise that would otherwise make the community choke on their morning coffee when they see a huge patch in a new, unknown PR.


This makes me feel a bit uneasy. To "socialize your change" is much easier for people who are part of a community ? in effect, those who are already insiders, but it's hard for a newcomer to know where to start. While I agree that this sentence accurately reflects the reality of the OpenJDK project, socializing is not an easy thing for many people.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/150#discussion_r2119291031

From jwilhelm at openjdk.org  Tue Jun 24 00:47:05 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 24 Jun 2025 00:47:05 GMT
Subject: RFR: Updated code owners for JDK 25
Message-ID: <3Jv-BY6W94ArM-7DJ6U0hnrBYHfI-mVN8rD3W2NxKv4=.8a5b7765-14a0-49d3-858b-3815242193b7@github.com>

Fixed missing "src" and added new directories for JDK 25.

-------------

Commit messages:
 - Updated code owners for JDK 25

Changes: https://git.openjdk.org/guide/pull/152/files
  Webrev: https://webrevs.openjdk.org/?repo=guide&pr=152&range=00
  Stats: 36 lines in 1 file changed: 7 ins; 1 del; 28 mod
  Patch: https://git.openjdk.org/guide/pull/152.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/152/head:pull/152

PR: https://git.openjdk.org/guide/pull/152

From iris at openjdk.org  Tue Jun 24 02:34:42 2025
From: iris at openjdk.org (Iris Clark)
Date: Tue, 24 Jun 2025 02:34:42 GMT
Subject: RFR: Updated code owners for JDK 25
In-Reply-To: <3Jv-BY6W94ArM-7DJ6U0hnrBYHfI-mVN8rD3W2NxKv4=.8a5b7765-14a0-49d3-858b-3815242193b7@github.com>
References: <3Jv-BY6W94ArM-7DJ6U0hnrBYHfI-mVN8rD3W2NxKv4=.8a5b7765-14a0-49d3-858b-3815242193b7@github.com>
Message-ID: <s9m_3JDSMmQ-845zNdFP1oHNdF1TDJ31slAsfsHG-YA=.8fe9789e-6a7e-40cb-8d30-7b759eb949aa@github.com>

On Tue, 24 Jun 2025 00:43:13 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Fixed missing "src" and added new directories for JDK 25.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/guide/pull/152#pullrequestreview-2951996294

From jwilhelm at openjdk.org  Fri Jun 27 15:01:50 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 27 Jun 2025 15:01:50 GMT
Subject: Integrated: Updated code owners for JDK 25
In-Reply-To: <3Jv-BY6W94ArM-7DJ6U0hnrBYHfI-mVN8rD3W2NxKv4=.8a5b7765-14a0-49d3-858b-3815242193b7@github.com>
References: <3Jv-BY6W94ArM-7DJ6U0hnrBYHfI-mVN8rD3W2NxKv4=.8a5b7765-14a0-49d3-858b-3815242193b7@github.com>
Message-ID: <gU94qic4HEnL7PZDnszZifH4gqjGWeZswUgWj1vhacg=.1d587e2b-e069-46b3-a3c5-5597bd52e39b@github.com>

On Tue, 24 Jun 2025 00:43:13 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Fixed missing "src" and added new directories for JDK 25.

This pull request has now been integrated.

Changeset: a1d89f89
Author:    Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/a1d89f89643d12eb2a3e524bbbb52cfb83a73de4
Stats:     36 lines in 1 file changed: 7 ins; 1 del; 28 mod

Updated code owners for JDK 25

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/guide/pull/152