From weijun at openjdk.org Mon Mar 3 19:35:19 2025 From: weijun at openjdk.org (Weijun Wang) Date: Mon, 3 Mar 2025 19:35:19 GMT Subject: RFR: Fix a typo in guide Message-ID: <3J1fHLEq-4iOFS_5aDe7ccPZ27ui1ag68ehPDc03xtA=.94de7d68-1bb0-4ae2-8a33-24f91f68eabf@github.com> `s/RPD2/RDP2/` ------------- Commit messages: - typo Changes: https://git.openjdk.org/guide/pull/144/files Webrev: https://webrevs.openjdk.org/?repo=guide&pr=144&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/guide/pull/144.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/144/head:pull/144 PR: https://git.openjdk.org/guide/pull/144 From iris at openjdk.org Mon Mar 3 19:39:09 2025 From: iris at openjdk.org (Iris Clark) Date: Mon, 3 Mar 2025 19:39:09 GMT Subject: RFR: Fix a typo in guide In-Reply-To: <3J1fHLEq-4iOFS_5aDe7ccPZ27ui1ag68ehPDc03xtA=.94de7d68-1bb0-4ae2-8a33-24f91f68eabf@github.com> References: <3J1fHLEq-4iOFS_5aDe7ccPZ27ui1ag68ehPDc03xtA=.94de7d68-1bb0-4ae2-8a33-24f91f68eabf@github.com> Message-ID: On Mon, 3 Mar 2025 19:30:32 GMT, Weijun Wang wrote: > `s/RPD2/RDP2/` Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/guide/pull/144#pullrequestreview-2655102710 From duke at openjdk.org Mon Mar 3 19:42:06 2025 From: duke at openjdk.org (duke) Date: Mon, 3 Mar 2025 19:42:06 GMT Subject: RFR: Fix a typo in guide In-Reply-To: <3J1fHLEq-4iOFS_5aDe7ccPZ27ui1ag68ehPDc03xtA=.94de7d68-1bb0-4ae2-8a33-24f91f68eabf@github.com> References: <3J1fHLEq-4iOFS_5aDe7ccPZ27ui1ag68ehPDc03xtA=.94de7d68-1bb0-4ae2-8a33-24f91f68eabf@github.com> Message-ID: On Mon, 3 Mar 2025 19:30:32 GMT, Weijun Wang wrote: > `s/RPD2/RDP2/` @wangweij Your change (at version 585283f21f341fa588d3c4fdc864b8c346e8e82c) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/guide/pull/144#issuecomment-2695369395 From weijun at openjdk.org Mon Mar 3 19:48:10 2025 From: weijun at openjdk.org (Weijun Wang) Date: Mon, 3 Mar 2025 19:48:10 GMT Subject: Integrated: Fix a typo in guide In-Reply-To: <3J1fHLEq-4iOFS_5aDe7ccPZ27ui1ag68ehPDc03xtA=.94de7d68-1bb0-4ae2-8a33-24f91f68eabf@github.com> References: <3J1fHLEq-4iOFS_5aDe7ccPZ27ui1ag68ehPDc03xtA=.94de7d68-1bb0-4ae2-8a33-24f91f68eabf@github.com> Message-ID: On Mon, 3 Mar 2025 19:30:32 GMT, Weijun Wang wrote: > `s/RPD2/RDP2/` This pull request has now been integrated. Changeset: 52c12ebe Author: Weijun Wang Committer: Iris Clark URL: https://git.openjdk.org/guide/commit/52c12ebe429f62f5661be74535690e6b2c2adafd Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Fix a typo in guide Reviewed-by: iris ------------- PR: https://git.openjdk.org/guide/pull/144 From jwilhelm at openjdk.org Mon Mar 3 21:57:55 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Mon, 3 Mar 2025 21:57:55 GMT Subject: RFR: Re-open when info received Message-ID: If issues are left as Resolved no-one will notice the new information. ------------- Commit messages: - Re-open when info received Changes: https://git.openjdk.org/guide/pull/145/files Webrev: https://webrevs.openjdk.org/?repo=guide&pr=145&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/guide/pull/145.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/145/head:pull/145 PR: https://git.openjdk.org/guide/pull/145 From jwilhelm at openjdk.org Mon Mar 3 22:12:33 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Mon, 3 Mar 2025 22:12:33 GMT Subject: RFR: Re-open when info received [v2] In-Reply-To: References: Message-ID: > If issues are left as Resolved no-one will notice the new information. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Fixed grammar ------------- Changes: - all: https://git.openjdk.org/guide/pull/145/files - new: https://git.openjdk.org/guide/pull/145/files/7fb2d0ec..e57d7ca4 Webrevs: - full: https://webrevs.openjdk.org/?repo=guide&pr=145&range=01 - incr: https://webrevs.openjdk.org/?repo=guide&pr=145&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/guide/pull/145.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/145/head:pull/145 PR: https://git.openjdk.org/guide/pull/145 From iris at openjdk.org Tue Mar 4 02:47:03 2025 From: iris at openjdk.org (Iris Clark) Date: Tue, 4 Mar 2025 02:47:03 GMT Subject: RFR: Re-open when info received [v2] In-Reply-To: References: Message-ID: <0s6xi7CwARgMgNcuY-YzoyDjhuKCzXnT36CZsWH1YTs=.11a65490-bb37-4a93-a645-a7ea8f94d199@github.com> On Mon, 3 Mar 2025 22:12:33 GMT, Jesper Wilhelmsson wrote: >> If issues are left as Resolved no-one will notice the new information. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fixed grammar Marked as reviewed by iris (Reviewer). src/guide/jbs-jdk-bug-system.md line 340: > 338: ### Closing incomplete issues > 339: > 340: As mentioned above, issues that lack the information needed to investigate the problem are placed in status [Resolved]{.jbs-value} - [Incomplete]{.jbs-value}. Triage teams should monitor incomplete issues in their area and if needed ping the relevant person. When new information has been received, the bug should be put back to status [Open]{.jbs-value}. If the required information hasn't been obtained within reasonable time (3-4 weeks) the bug should be closed as [Incomplete]{.jbs-value}. Perhaps change the tense to "When new information is received, the bug should be returned to status ...". ------------- PR Review: https://git.openjdk.org/guide/pull/145#pullrequestreview-2655783196 PR Review Comment: https://git.openjdk.org/guide/pull/145#discussion_r1978518427 From jwilhelm at openjdk.org Thu Mar 6 18:51:27 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Thu, 6 Mar 2025 18:51:27 GMT Subject: RFR: Re-open when info received [v3] In-Reply-To: References: Message-ID: > If issues are left as Resolved no-one will notice the new information. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Review comments ------------- Changes: - all: https://git.openjdk.org/guide/pull/145/files - new: https://git.openjdk.org/guide/pull/145/files/e57d7ca4..07a5e1af Webrevs: - full: https://webrevs.openjdk.org/?repo=guide&pr=145&range=02 - incr: https://webrevs.openjdk.org/?repo=guide&pr=145&range=01-02 Stats: 169 lines in 1 file changed: 169 ins; 0 del; 0 mod Patch: https://git.openjdk.org/guide/pull/145.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/145/head:pull/145 PR: https://git.openjdk.org/guide/pull/145 From jwilhelm at openjdk.org Thu Mar 6 18:51:27 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Thu, 6 Mar 2025 18:51:27 GMT Subject: RFR: Re-open when info received [v2] In-Reply-To: <0s6xi7CwARgMgNcuY-YzoyDjhuKCzXnT36CZsWH1YTs=.11a65490-bb37-4a93-a645-a7ea8f94d199@github.com> References: <0s6xi7CwARgMgNcuY-YzoyDjhuKCzXnT36CZsWH1YTs=.11a65490-bb37-4a93-a645-a7ea8f94d199@github.com> Message-ID: On Tue, 4 Mar 2025 02:44:01 GMT, Iris Clark wrote: >> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: >> >> Fixed grammar > > src/guide/jbs-jdk-bug-system.md line 340: > >> 338: ### Closing incomplete issues >> 339: >> 340: As mentioned above, issues that lack the information needed to investigate the problem are placed in status [Resolved]{.jbs-value} - [Incomplete]{.jbs-value}. Triage teams should monitor incomplete issues in their area and if needed ping the relevant person. When new information has been received, the bug should be put back to status [Open]{.jbs-value}. If the required information hasn't been obtained within reasonable time (3-4 weeks) the bug should be closed as [Incomplete]{.jbs-value}. > > Perhaps change the tense to "When new information is received, the bug should be returned to status ...". Agreed. Fixed. ------------- PR Review Comment: https://git.openjdk.org/guide/pull/145#discussion_r1983889480 From iris at openjdk.org Thu Mar 6 19:19:24 2025 From: iris at openjdk.org (Iris Clark) Date: Thu, 6 Mar 2025 19:19:24 GMT Subject: RFR: Re-open when info received [v3] In-Reply-To: References: Message-ID: <6NzaPZCBnVVMBzHne0d1U_RNsnSQCfzNI_REcA2ybWA=.f6f4daec-48c6-40cf-b469-8711764d9328@github.com> On Thu, 6 Mar 2025 18:51:27 GMT, Jesper Wilhelmsson wrote: >> If issues are left as Resolved no-one will notice the new information. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Review comments Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/guide/pull/145#pullrequestreview-2665404536 From duke at openjdk.org Mon Mar 10 13:35:50 2025 From: duke at openjdk.org (Roger Calnan) Date: Mon, 10 Mar 2025 13:35:50 GMT Subject: RFR: Follow-on update due to the introduction of caused-by links [v2] In-Reply-To: References: Message-ID: > Noted that the label regression_ID is now deprecated and a caused-by link should be used. Fixed a couple of typos Roger Calnan has updated the pull request incrementally with two additional commits since the last revision: - typo - adjustments from feedback ------------- Changes: - all: https://git.openjdk.org/guide/pull/143/files - new: https://git.openjdk.org/guide/pull/143/files/b2e31865..47bc8927 Webrevs: - full: https://webrevs.openjdk.org/?repo=guide&pr=143&range=01 - incr: https://webrevs.openjdk.org/?repo=guide&pr=143&range=00-01 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/guide/pull/143.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/143/head:pull/143 PR: https://git.openjdk.org/guide/pull/143 From duke at openjdk.org Mon Mar 10 13:35:53 2025 From: duke at openjdk.org (Roger Calnan) Date: Mon, 10 Mar 2025 13:35:53 GMT Subject: RFR: Follow-on update due to the introduction of caused-by links [v2] In-Reply-To: References: Message-ID: On Thu, 27 Feb 2025 13:03:09 GMT, Jesper Wilhelmsson wrote: >> src/guide/jbs-jdk-bug-system.md line 84: >> >>> 82: 1) If an issue is applicable to release N, then it can't be assumed that it is applicable to older releases less than N. It may be, but in general this is less important to know, as the majority of issues are only fixed in the latest feature release. If the issue is a crash or important in another way, then it becomes worthwhile to take the time to determine if it's relevant to earlier LTS releases. >>> 83: >>> 84: Another aspect of an issue is when the feature, it's a part of, was added or removed from the JDK, which in either case limits the range of releases the issue impacts. Knowing that a feature was removed before the oldest currently maintained release means it can be resolved as [Won't Fix]{.jbs-value}. >> >> Maybe "... when a part of the feature was added ...". I'm not sure because that may change the intent. > > This could be more generalized since it doesn't only hold for features, but basically any code. > "...is when the impacted code was added or..." done >> src/guide/jbs-jdk-bug-system.md line 128: >> >>> 126: 2. No need to add additional releases as they are implied. >>> 127: 3. Adding the occasional LTS release value is ok. >>> 128: 4. Use N-na to indicate that the issue is no longer relevant from that release, which could be due to the feature or platform being removed or the code has been rewritten. >> >> I think that "being rewritten" was correct since it parallels the earlier "being removed". > > Agree with Iris. reverted the change ------------- PR Review Comment: https://git.openjdk.org/guide/pull/143#discussion_r1987287658 PR Review Comment: https://git.openjdk.org/guide/pull/143#discussion_r1987288211 From duke at openjdk.org Mon Mar 10 13:35:56 2025 From: duke at openjdk.org (Roger Calnan) Date: Mon, 10 Mar 2025 13:35:56 GMT Subject: RFR: Follow-on update due to the introduction of caused-by links [v2] In-Reply-To: References: Message-ID: On Thu, 27 Feb 2025 00:51:43 GMT, Iris Clark wrote: >> Roger Calnan has updated the pull request incrementally with two additional commits since the last revision: >> >> - typo >> - adjustments from feedback > > src/guide/jbs-jdk-bug-system.md line 739: > >> 737: [[regression_]{.jbs-label}*(ID)*]{#regression_id} >> 738: >> 739: **Deprecated.** Was used to identify the fix that caused the regression, where known. Has been replaced by the use of the [caused by]{.jbs-value} link. > > Maybe "**Formerly** used to identify...". > > Also either "**This label** has been replaced by the use..." or "**Replaced** by the use..." "Formerly" is good, the one thing is that the rest use "Was used". I'm ok with it being different but just noting that ------------- PR Review Comment: https://git.openjdk.org/guide/pull/143#discussion_r1987291604 From aivanov at openjdk.org Mon Mar 10 13:42:11 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Mon, 10 Mar 2025 13:42:11 GMT Subject: RFR: Follow-on update due to the introduction of caused-by links [v2] In-Reply-To: References: Message-ID: On Mon, 10 Mar 2025 13:35:50 GMT, Roger Calnan wrote: >> Noted that the label regression_ID is now deprecated and a caused-by link should be used. Fixed a couple of typos > > Roger Calnan has updated the pull request incrementally with two additional commits since the last revision: > > - typo > - adjustments from feedback src/guide/jbs-jdk-bug-system.md line 434: > 432: [*(Rel)*[-fix-no]{.jbs-label}]{#rel-fix-no} > 433: > 434: Used in ramp down phase 2 to indicate that an issue would be of interest to be integrated into release *(Rel)*. E.g., [jdk12u-fix-request]{.jbs-label} The `jdk*u-fix-request` labels are used for approval to backport / integrate a fix into an update release rather than after ramp down phase 2. However, the labels without `*u` in release family apply to RDP2. Also, below sentences mention the label explicitly, this one should do it too: `*(Rel)*[-fix-request]{.jbs-label}`. It'll make the reference explicit. ------------- PR Review Comment: https://git.openjdk.org/guide/pull/143#discussion_r1987307393 From jwilhelm at openjdk.org Mon Mar 10 22:20:18 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Mon, 10 Mar 2025 22:20:18 GMT Subject: RFR: Re-open when info received [v4] In-Reply-To: References: Message-ID: > If issues are left as Resolved no-one will notice the new information. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Label on JEP issue ------------- Changes: - all: https://git.openjdk.org/guide/pull/145/files - new: https://git.openjdk.org/guide/pull/145/files/07a5e1af..1b85f937 Webrevs: - full: https://webrevs.openjdk.org/?repo=guide&pr=145&range=03 - incr: https://webrevs.openjdk.org/?repo=guide&pr=145&range=02-03 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/guide/pull/145.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/145/head:pull/145 PR: https://git.openjdk.org/guide/pull/145 From jwilhelm at openjdk.org Mon Mar 10 22:37:45 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Mon, 10 Mar 2025 22:37:45 GMT Subject: RFR: Re-open when info received [v5] In-Reply-To: References: Message-ID: > If issues are left as Resolved no-one will notice the new information. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Delete file committed by misstake ------------- Changes: - all: https://git.openjdk.org/guide/pull/145/files - new: https://git.openjdk.org/guide/pull/145/files/1b85f937..12bbcf8a Webrevs: - full: https://webrevs.openjdk.org/?repo=guide&pr=145&range=04 - incr: https://webrevs.openjdk.org/?repo=guide&pr=145&range=03-04 Stats: 169 lines in 1 file changed: 0 ins; 169 del; 0 mod Patch: https://git.openjdk.org/guide/pull/145.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/145/head:pull/145 PR: https://git.openjdk.org/guide/pull/145 From jwilhelm at openjdk.org Mon Mar 10 22:37:45 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Mon, 10 Mar 2025 22:37:45 GMT Subject: Integrated: Re-open when info received In-Reply-To: References: Message-ID: On Mon, 3 Mar 2025 21:53:32 GMT, Jesper Wilhelmsson wrote: > If issues are left as Resolved no-one will notice the new information. This pull request has now been integrated. Changeset: be88a6de Author: Jesper Wilhelmsson URL: https://git.openjdk.org/guide/commit/be88a6debcb0dfb7f8fb0e8f3e95ff35950ca9c4 Stats: 3 lines in 3 files changed: 1 ins; 0 del; 2 mod Re-open when info received Reviewed-by: iris ------------- PR: https://git.openjdk.org/guide/pull/145 From jwilhelm at openjdk.org Fri Mar 14 00:22:23 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Fri, 14 Mar 2025 00:22:23 GMT Subject: RFR: No localization in RDP2 Message-ID: Localization can't be expected for changes made in RDP2. @irisclark This change also contain your fixes from #145 that I apparently didn't commit before integrating. ------------- Commit messages: - No localization in RDP2 Changes: https://git.openjdk.org/guide/pull/146/files Webrev: https://webrevs.openjdk.org/?repo=guide&pr=146&range=00 Stats: 8 lines in 3 files changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.org/guide/pull/146.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/146/head:pull/146 PR: https://git.openjdk.org/guide/pull/146 From jwilhelm at openjdk.org Fri Mar 14 00:32:20 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Fri, 14 Mar 2025 00:32:20 GMT Subject: RFR: No localization in RDP2 [v2] In-Reply-To: References: Message-ID: > Localization can't be expected for changes made in RDP2. > > @irisclark This change also contain your fixes from #145 that I apparently didn't commit before integrating. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Fix typo in label ------------- Changes: - all: https://git.openjdk.org/guide/pull/146/files - new: https://git.openjdk.org/guide/pull/146/files/89412d41..8abf8899 Webrevs: - full: https://webrevs.openjdk.org/?repo=guide&pr=146&range=01 - incr: https://webrevs.openjdk.org/?repo=guide&pr=146&range=00-01 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/guide/pull/146.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/146/head:pull/146 PR: https://git.openjdk.org/guide/pull/146 From jwilhelm at openjdk.org Fri Mar 14 00:34:03 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Fri, 14 Mar 2025 00:34:03 GMT Subject: RFR: Follow-on update due to the introduction of caused-by links [v2] In-Reply-To: References: Message-ID: On Mon, 10 Mar 2025 13:35:50 GMT, Roger Calnan wrote: >> Noted that the label regression_ID is now deprecated and a caused-by link should be used. Fixed a couple of typos > > Roger Calnan has updated the pull request incrementally with two additional commits since the last revision: > > - typo > - adjustments from feedback Marked as reviewed by jwilhelm (Lead). ------------- PR Review: https://git.openjdk.org/guide/pull/143#pullrequestreview-2683664098 From jwilhelm at openjdk.org Fri Mar 14 00:34:03 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Fri, 14 Mar 2025 00:34:03 GMT Subject: RFR: Follow-on update due to the introduction of caused-by links [v2] In-Reply-To: References: Message-ID: On Mon, 10 Mar 2025 13:39:08 GMT, Alexey Ivanov wrote: >> Roger Calnan has updated the pull request incrementally with two additional commits since the last revision: >> >> - typo >> - adjustments from feedback > > src/guide/jbs-jdk-bug-system.md line 434: > >> 432: [*(Rel)*[-fix-no]{.jbs-label}]{#rel-fix-no} >> 433: >> 434: Used in ramp down phase 2 to indicate that an issue would be of interest to be integrated into release *(Rel)*. E.g., [jdk12u-fix-request]{.jbs-label} > > The `jdk*u-fix-request` labels are used for approval to backport / integrate a fix into an update release rather than after ramp down phase 2. However, the labels without `*u` in release family apply to RDP2. > > Also, below sentences mention the label explicitly, this one should do it too: `*(Rel)*[-fix-request]{.jbs-label}`. It'll make the reference explicit. I have made this fix as part of #146. Please have a look to make sure I got it right. ------------- PR Review Comment: https://git.openjdk.org/guide/pull/143#discussion_r1994476752 From iris at openjdk.org Fri Mar 14 02:03:03 2025 From: iris at openjdk.org (Iris Clark) Date: Fri, 14 Mar 2025 02:03:03 GMT Subject: RFR: No localization in RDP2 [v2] In-Reply-To: References: Message-ID: On Fri, 14 Mar 2025 00:32:20 GMT, Jesper Wilhelmsson wrote: >> Localization can't be expected for changes made in RDP2. >> >> @irisclark This change also contain your fixes from #145 that I apparently didn't commit before integrating. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fix typo in label Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/guide/pull/146#pullrequestreview-2683799331 From aivanov at openjdk.org Fri Mar 14 16:09:14 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 14 Mar 2025 16:09:14 GMT Subject: RFR: Replace affects_versions.png with SVG Message-ID: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com> Replace `affects_versions.png` with Scalable Vector Graphics (SVG) image.
PNG vs SVG **PNG:**\ ![affects_versions.png](https://github.com/openjdk/guide/blob/be88a6debcb0dfb7f8fb0e8f3e95ff35950ca9c4/src/images/affects_versions.png?raw=true) **SVG:**\ ![affects_versions.svg](https://raw.githubusercontent.com/aivanov-jdk/dev-guide/bc65ea67251cc68360fc746a77200d8c93fd78b5/src/images/affects_versions.svg)
SVG is crisper, especially on High DPI monitors, its size is much smaller (1.04 KB vs 26.24 KB), it's easier to edit and the edit history is preserved. ------------- Commit messages: - Replace affects_versions.png with SVG Changes: https://git.openjdk.org/guide/pull/147/files Webrev: https://webrevs.openjdk.org/?repo=guide&pr=147&range=00 Stats: 157 lines in 3 files changed: 156 ins; 0 del; 1 mod Patch: https://git.openjdk.org/guide/pull/147.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/147/head:pull/147 PR: https://git.openjdk.org/guide/pull/147 From aivanov at openjdk.org Fri Mar 14 16:41:11 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 14 Mar 2025 16:41:11 GMT Subject: RFR: No localization in RDP2 [v2] In-Reply-To: References: Message-ID: On Fri, 14 Mar 2025 00:32:20 GMT, Jesper Wilhelmsson wrote: >> Localization can't be expected for changes made in RDP2. >> >> @irisclark This change also contain your fixes from #145 that I apparently didn't commit before integrating. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fix typo in label src/guide/jbs-jdk-bug-system.md line 340: > 338: ### Closing incomplete issues > 339: > 340: As mentioned above, issues that lack the information needed to investigate the problem are placed in status [Resolved]{.jbs-value} - [Incomplete]{.jbs-value}. Triage teams should monitor incomplete issues in their area and if needed ping the relevant person. When new information is received, the bug should be returned to status [Open]{.jbs-value}. If the required information hasn't been obtained within reasonable time (3-4 weeks) the bug should be closed as [Incomplete]{.jbs-value}. Does ??the bug should be closed?? imply that the *Resolved* status changes to *Closed*? src/guide/jbs-jdk-bug-system.md line 434: > 432: [*(Rel)*[-fix-no]{.jbs-label}]{#rel-fix-no} > 433: > 434: *(Rel)*[-fix-request]{.jbs-label} is used in ramp down phase 2 to indicate that an issue would be of interest to be integrated into release *(Rel)*. E.g., [jdk12-fix-request]{.jbs-label} Should the section be expanded for update releases? The labels like `jdk12u-fix-request` and `jdk24u-fix-request` are constantly used to [request approval for backporting](https://openjdk.org/guide/#requesting-approvals-for-backports) an update release. The `jdk##-fix-request` and `jdk##u-fix-request` are similar, but they have a different role in the OpenJDK Project. src/guide/jbs-jdk-bug-system.md line 437: > 435: > 436: *(Rel)*[-fix-SQE-ok]{.jbs-label} is used to indicate that the issue will be covered by the test plan for *(Rel)*. E.g., [jdk12-fix-SQE-ok]{.jbs-label}
> 437: *(Rel)*[-fix-yes]{.jbs-label} and *(Rel)*[-fix-no]{.jbs-label} are used to indicate wether an issue has been approved for backport to *(Rel)*. E.g., [jdk12-fix-yes]{.jbs-label} Yet `jdk12-fix-yes` isn't applicable to backports, it's for post RDP2 integrations (which are also *backports* since the initial fix goes to mainline which is at *Rel+1*). Maybe a different wording should be used to clarify? src/guide/making-a-change.md line 73: > 71: ## Changes Late in the Release > 72: > 73: You should always aim to get your changes integrated as early in a release as possible to maximize the amount of testing done before release. If you risk running late it's almost always a better idea to defer the change to the next release rather than trying to squeeze it in in the last minute. The next release is only six months out, the world can wait even though you are eager. Suggestion: You should always aim to get your changes integrated as early in a release as possible to maximize the amount of testing done before release. If you risk running late, it's almost always a better idea to defer the change to the next release rather than trying to squeeze it in in the last minute. The next release is only six months away, the world can wait even though you are eager. A comma after the conditional cause which comes before the main clause helps reading. I think ?away? is correct when you're referring to an upcoming release; whereas ?out? would imply an already released version six months ago. *??to squeeze it in in the last minute?* could be hard to read because of two adjacent ?in?s. src/guide/making-a-change.md line 75: > 73: You should always aim to get your changes integrated as early in a release as possible to maximize the amount of testing done before release. If you risk running late it's almost always a better idea to defer the change to the next release rather than trying to squeeze it in in the last minute. The next release is only six months out, the world can wait even though you are eager. > 74: > 75: Integrating during the rampdown phase is not recommended. The bar to integrate a change in the rampdown phase is considerably higher than during the normal development phase. See [The JDK Release Process] for more information. Also note that changes that are made late in the release shouldn't expect localization since this in itself takes some time. Suggestion: Integrating during the rampdown phase is not recommended. The bar to integrate a change in the rampdown phase is considerably higher than during the normal development phase. See [The JDK Release Process] for more information. Also note changes that are made late in the release shouldn't expect localization since this in itself takes some time. Is the last sentence easier to read and understand if you omit the relative conjunction ?that?? ------------- PR Review Comment: https://git.openjdk.org/guide/pull/146#discussion_r1995847429 PR Review Comment: https://git.openjdk.org/guide/pull/146#discussion_r1995875143 PR Review Comment: https://git.openjdk.org/guide/pull/146#discussion_r1995880459 PR Review Comment: https://git.openjdk.org/guide/pull/146#discussion_r1995892111 PR Review Comment: https://git.openjdk.org/guide/pull/146#discussion_r1995898511 From aivanov at openjdk.org Fri Mar 14 16:43:06 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 14 Mar 2025 16:43:06 GMT Subject: RFR: Follow-on update due to the introduction of caused-by links [v2] In-Reply-To: References: Message-ID: <2IaEJGMcHzffiRXiJqtmXTRt1SLq5AJlisPHPdrTHaU=.b0b841b9-33a3-43fe-9bd6-14c0e873a4ad@github.com> On Mon, 10 Mar 2025 13:35:50 GMT, Roger Calnan wrote: >> Noted that the label regression_ID is now deprecated and a caused-by link should be used. Fixed a couple of typos > > Roger Calnan has updated the pull request incrementally with two additional commits since the last revision: > > - typo > - adjustments from feedback Marked as reviewed by aivanov (no project role). ------------- PR Review: https://git.openjdk.org/guide/pull/143#pullrequestreview-2686150060 From aivanov at openjdk.org Fri Mar 14 16:43:06 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Fri, 14 Mar 2025 16:43:06 GMT Subject: RFR: Follow-on update due to the introduction of caused-by links [v2] In-Reply-To: References: Message-ID: <56x0wfqBhcfqZbv2z8ujTb91IqDZ0Z6GPvwFaVOp5vo=.16e359f7-95a5-457b-80fd-73fb257de728@github.com> On Fri, 14 Mar 2025 00:30:24 GMT, Jesper Wilhelmsson wrote: >> src/guide/jbs-jdk-bug-system.md line 434: >> >>> 432: [*(Rel)*[-fix-no]{.jbs-label}]{#rel-fix-no} >>> 433: >>> 434: Used in ramp down phase 2 to indicate that an issue would be of interest to be integrated into release *(Rel)*. E.g., [jdk12u-fix-request]{.jbs-label} >> >> The `jdk*u-fix-request` labels are used for approval to backport / integrate a fix into an update release rather than after ramp down phase 2. However, the labels without `*u` in release family apply to RDP2. >> >> Also, below sentences mention the label explicitly, this one should do it too: `*(Rel)*[-fix-request]{.jbs-label}`. It'll make the reference explicit. > > I have made this fix as part of #146. Please have a look to make sure I got it right. Shall this `s/get/be/` dropped from this PR to avoid conflict in #146? ------------- PR Review Comment: https://git.openjdk.org/guide/pull/143#discussion_r1995901880 From ihse at openjdk.org Fri Mar 14 18:35:25 2025 From: ihse at openjdk.org (Magnus Ihse Bursie) Date: Fri, 14 Mar 2025 18:35:25 GMT Subject: RFR: Replace affects_versions.png with SVG In-Reply-To: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com> References: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com> Message-ID: On Fri, 14 Mar 2025 16:04:56 GMT, Alexey Ivanov wrote: > Replace `affects_versions.png` with Scalable Vector Graphics (SVG) image. > >
> PNG vs SVG > > **PNG:**\ > ![affects_versions.png](https://github.com/openjdk/guide/blob/be88a6debcb0dfb7f8fb0e8f3e95ff35950ca9c4/src/images/affects_versions.png?raw=true) > > **SVG:**\ > ![affects_versions.svg](https://raw.githubusercontent.com/aivanov-jdk/dev-guide/bc65ea67251cc68360fc746a77200d8c93fd78b5/src/images/affects_versions.svg) >
> > SVG is crisper, especially on High DPI monitors, its size is much smaller (1.04 KB vs 26.24 KB), it's easier to edit and the edit history is preserved. Nice! ------------- Marked as reviewed by ihse (Committer). PR Review: https://git.openjdk.org/guide/pull/147#pullrequestreview-2686399698 From jwilhelm at openjdk.org Sat Mar 15 00:54:05 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Sat, 15 Mar 2025 00:54:05 GMT Subject: RFR: No localization in RDP2 [v2] In-Reply-To: References: Message-ID: On Fri, 14 Mar 2025 16:07:41 GMT, Alexey Ivanov wrote: >> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix typo in label > > src/guide/jbs-jdk-bug-system.md line 340: > >> 338: ### Closing incomplete issues >> 339: >> 340: As mentioned above, issues that lack the information needed to investigate the problem are placed in status [Resolved]{.jbs-value} - [Incomplete]{.jbs-value}. Triage teams should monitor incomplete issues in their area and if needed ping the relevant person. When new information is received, the bug should be returned to status [Open]{.jbs-value}. If the required information hasn't been obtained within reasonable time (3-4 weeks) the bug should be closed as [Incomplete]{.jbs-value}. > > Does ??the bug should be closed?? imply that the *Resolved* status changes to *Closed*? Yes. > src/guide/jbs-jdk-bug-system.md line 434: > >> 432: [*(Rel)*[-fix-no]{.jbs-label}]{#rel-fix-no} >> 433: >> 434: *(Rel)*[-fix-request]{.jbs-label} is used in ramp down phase 2 to indicate that an issue would be of interest to be integrated into release *(Rel)*. E.g., [jdk12-fix-request]{.jbs-label} > > Should the section be expanded for update releases? The labels like `jdk12u-fix-request` and `jdk24u-fix-request` are constantly used to [request approval for backporting](https://openjdk.org/guide/#requesting-approvals-for-backports) an update release. > > The `jdk##-fix-request` and `jdk##u-fix-request` are similar, but they have a different role in the OpenJDK Project. I'd be happy to include such an update. Could you write the text, either here in a comment or as a separate change? ------------- PR Review Comment: https://git.openjdk.org/guide/pull/146#discussion_r1996470178 PR Review Comment: https://git.openjdk.org/guide/pull/146#discussion_r1996470497 From jwilhelm at openjdk.org Sat Mar 15 01:09:02 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Sat, 15 Mar 2025 01:09:02 GMT Subject: RFR: Replace affects_versions.png with SVG In-Reply-To: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com> References: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com> Message-ID: On Fri, 14 Mar 2025 16:04:56 GMT, Alexey Ivanov wrote: > Replace `affects_versions.png` with Scalable Vector Graphics (SVG) image. > >
> PNG vs SVG > > **PNG:**\ > ![affects_versions.png](https://github.com/openjdk/guide/blob/be88a6debcb0dfb7f8fb0e8f3e95ff35950ca9c4/src/images/affects_versions.png?raw=true) > > **SVG:**\ > ![affects_versions.svg](https://raw.githubusercontent.com/aivanov-jdk/dev-guide/bc65ea67251cc68360fc746a77200d8c93fd78b5/src/images/affects_versions.svg) >
> > SVG is crisper, especially on High DPI monitors, its size is much smaller (1.04 KB vs 26.24 KB), it's easier to edit and the edit history is preserved. Indeed nice! As you are in the area... ;-) I think it would make more sense if case 4 didn't end with an arrow pointing at 12-na, but rather ends with a tilted "T" .. as in "--| 12-na". The arrow could be interpreted as the issue lives on. ------------- PR Comment: https://git.openjdk.org/guide/pull/147#issuecomment-2726083272 From aivanov at openjdk.org Tue Mar 18 20:03:34 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Tue, 18 Mar 2025 20:03:34 GMT Subject: RFR: Replace affects_versions.png with SVG [v2] In-Reply-To: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com> References: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com> Message-ID: > Replace `affects_versions.png` with Scalable Vector Graphics (SVG) image. > >
> PNG vs SVG > > **PNG:**\ > ![affects_versions.png](https://github.com/openjdk/guide/blob/be88a6debcb0dfb7f8fb0e8f3e95ff35950ca9c4/src/images/affects_versions.png?raw=true) > > **SVG:**\ > ![affects_versions.svg](https://raw.githubusercontent.com/aivanov-jdk/dev-guide/bc65ea67251cc68360fc746a77200d8c93fd78b5/src/images/affects_versions.svg) >
> > SVG is crisper, especially on High DPI monitors, its size is much smaller (1.04 KB vs 26.24 KB), it's easier to edit and the edit history is preserved. Alexey Ivanov has updated the pull request incrementally with three additional commits since the last revision: - Red cross under 11-wnf - Dashed line to 12-na label - End 12-na with T-like instead of arrow ------------- Changes: - all: https://git.openjdk.org/guide/pull/147/files - new: https://git.openjdk.org/guide/pull/147/files/bc65ea67..3a13348b Webrevs: - full: https://webrevs.openjdk.org/?repo=guide&pr=147&range=01 - incr: https://webrevs.openjdk.org/?repo=guide&pr=147&range=00-01 Stats: 10 lines in 1 file changed: 7 ins; 0 del; 3 mod Patch: https://git.openjdk.org/guide/pull/147.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/147/head:pull/147 PR: https://git.openjdk.org/guide/pull/147 From aivanov at openjdk.org Tue Mar 18 20:08:20 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Tue, 18 Mar 2025 20:08:20 GMT Subject: RFR: Replace affects_versions.png with SVG In-Reply-To: References: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com> Message-ID: On Sat, 15 Mar 2025 01:06:48 GMT, Jesper Wilhelmsson wrote: > ?if case 4 didn't end with an arrow pointing at 12-na, but rather ends with a tilted "T" .. as in "--| 12-na". The arrow could be interpreted as the issue lives on. That's a good idea. I made it end with with ?? and made the line for 12 dashed/dotted. Should I use the circle as in case 5 for consistency? The circle seem to represent that an issue is fixed in that release, in other words, the issue is fixed in 11, but it's not applicable to 12 and above. ------------- PR Comment: https://git.openjdk.org/guide/pull/147#issuecomment-2734574036 From aivanov at openjdk.org Tue Mar 18 21:03:24 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Tue, 18 Mar 2025 21:03:24 GMT Subject: RFR: No localization in RDP2 [v3] In-Reply-To: References: Message-ID: On Sat, 15 Mar 2025 01:01:23 GMT, Jesper Wilhelmsson wrote: >> Localization can't be expected for changes made in RDP2. >> >> @irisclark This change also contain your fixes from #145 that I apparently didn't commit before integrating. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Update src/guide/making-a-change.md > > Co-authored-by: Alexey Ivanov Marked as reviewed by aivanov (no project role). ------------- PR Review: https://git.openjdk.org/guide/pull/146#pullrequestreview-2696273969 From aivanov at openjdk.org Tue Mar 18 21:03:24 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Tue, 18 Mar 2025 21:03:24 GMT Subject: RFR: No localization in RDP2 [v2] In-Reply-To: References: Message-ID: <-6vZ4n35FAPo03BeLOOc55HyYq8Xyb0KhPBZOkTGzso=.0d753375-837f-4f65-bb36-e097e384937f@github.com> On Sat, 15 Mar 2025 00:51:25 GMT, Jesper Wilhelmsson wrote: >> src/guide/jbs-jdk-bug-system.md line 434: >> >>> 432: [*(Rel)*[-fix-no]{.jbs-label}]{#rel-fix-no} >>> 433: >>> 434: *(Rel)*[-fix-request]{.jbs-label} is used in ramp down phase 2 to indicate that an issue would be of interest to be integrated into release *(Rel)*. E.g., [jdk12-fix-request]{.jbs-label} >> >> Should the section be expanded for update releases? The labels like `jdk12u-fix-request` and `jdk24u-fix-request` are constantly used to [request approval for backporting](https://openjdk.org/guide/#requesting-approvals-for-backports) an update release. >> >> The `jdk##-fix-request` and `jdk##u-fix-request` are similar, but they have a different role in the OpenJDK Project. > > I'd be happy to include such an update. Could you write the text, either here in a comment or as a separate change? Yeah, it makes sense to expand the section in another PR. > I don't think so. Your suggestion would require a comma after "note", and I don't think that sentence would be easier to read. You're right. The sentence is easier to understand with both ?that? on their own places. > It could be simplified by removing "that are" (the second that) instead. No, the second ?that? can't be removed because it's the subject of the dependent sentence ?that are made late in the release? which describes _changes_. ------------- PR Review Comment: https://git.openjdk.org/guide/pull/146#discussion_r2002007684 PR Review Comment: https://git.openjdk.org/guide/pull/146#discussion_r2002004271 From aivanov at openjdk.org Wed Mar 19 15:24:26 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Wed, 19 Mar 2025 15:24:26 GMT Subject: RFR: Replace affects_versions.png with SVG In-Reply-To: References: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com> Message-ID: On Tue, 18 Mar 2025 20:05:33 GMT, Alexey Ivanov wrote: > > ?if case 4 didn't end with an arrow pointing at 12-na, but rather ends with a tilted "T" .. as in "--| 12-na". The arrow could be interpreted as the issue lives on. > > That's a good idea. > > I made it end with with ?? and made the line for 12 dashed/dotted. The current version with T-like end for ?12-na?:\ ![Affects Versions where ?12-na? line ends with a ?T?-like end](https://raw.githubusercontent.com/openjdk/guide/3a13348b52530dcfbdf45d6819a3677fddb63123/src/images/affects_versions.svg) > Should I use the circle as in case 5 for consistency? The circle seem to represent that an issue is fixed in that release, in other words, the issue is fixed in 11, but it's not applicable to 12 and above. The version which ends 12-na line with a circle:\ ![Affects Versions where ?12-na? line ends with a circle](https://raw.githubusercontent.com/openjdk/guide/b994bb25ed2237483a0f0ea2acd9dc532b0d6454/src/images/affects_versions.svg) ------------- PR Comment: https://git.openjdk.org/guide/pull/147#issuecomment-2737050277 From jwilhelm at openjdk.org Thu Mar 20 15:30:30 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Thu, 20 Mar 2025 15:30:30 GMT Subject: RFR: Replace affects_versions.png with SVG [v2] In-Reply-To: References: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com> Message-ID: On Tue, 18 Mar 2025 20:03:34 GMT, Alexey Ivanov wrote: >> Replace `affects_versions.png` with Scalable Vector Graphics (SVG) image. >> >>
>> PNG vs SVG >> >> **PNG:**\ >> ![affects_versions.png](https://github.com/openjdk/guide/blob/be88a6debcb0dfb7f8fb0e8f3e95ff35950ca9c4/src/images/affects_versions.png?raw=true) >> >> **SVG:**\ >> ![affects_versions.svg](https://raw.githubusercontent.com/aivanov-jdk/dev-guide/bc65ea67251cc68360fc746a77200d8c93fd78b5/src/images/affects_versions.svg) >>
>> >> SVG is crisper, especially on High DPI monitors, its size is much smaller (1.04 KB vs 26.24 KB), it's easier to edit and the edit history is preserved. > > Alexey Ivanov has updated the pull request incrementally with three additional commits since the last revision: > > - Red cross under 11-wnf > - Dashed line to 12-na label > - End 12-na with T-like instead of arrow Yes actually the circle makes sense as it's consistent with 5. ------------- PR Comment: https://git.openjdk.org/guide/pull/147#issuecomment-2740853853 From jwilhelm at openjdk.org Thu Mar 20 15:35:40 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Thu, 20 Mar 2025 15:35:40 GMT Subject: Integrated: No localization in RDP2 In-Reply-To: References: Message-ID: On Fri, 14 Mar 2025 00:17:40 GMT, Jesper Wilhelmsson wrote: > Localization can't be expected for changes made in RDP2. > > @irisclark This change also contain your fixes from #145 that I apparently didn't commit before integrating. This pull request has now been integrated. Changeset: a0d2befb Author: Jesper Wilhelmsson URL: https://git.openjdk.org/guide/commit/a0d2befb5e818aacc157a4a12ac5e9a1b74ee719 Stats: 11 lines in 3 files changed: 6 ins; 0 del; 5 mod No localization in RDP2 Reviewed-by: iris, aivanov ------------- PR: https://git.openjdk.org/guide/pull/146 From jwilhelm at openjdk.org Thu Mar 20 15:45:00 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Thu, 20 Mar 2025 15:45:00 GMT Subject: RFR: Reminder to remove label [v2] In-Reply-To: References: Message-ID: <6-DQS-U0Dfecx_SdoaxTxkCicifmwuYGZSYfD1DKo40=.9cd60b84-c05a-4d5c-9642-46bcc8cd9660@github.com> > Reminder to remove label Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Can instead of should ------------- Changes: - all: https://git.openjdk.org/guide/pull/136/files - new: https://git.openjdk.org/guide/pull/136/files/a1e123af..be7262e6 Webrevs: - full: https://webrevs.openjdk.org/?repo=guide&pr=136&range=01 - incr: https://webrevs.openjdk.org/?repo=guide&pr=136&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/guide/pull/136.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/136/head:pull/136 PR: https://git.openjdk.org/guide/pull/136 From jwilhelm at openjdk.org Thu Mar 20 15:45:01 2025 From: jwilhelm at openjdk.org (Jesper Wilhelmsson) Date: Thu, 20 Mar 2025 15:45:01 GMT Subject: Integrated: Reminder to remove label In-Reply-To: References: Message-ID: On Tue, 22 Oct 2024 15:22:04 GMT, Jesper Wilhelmsson wrote: > Reminder to remove label This pull request has now been integrated. Changeset: 90778521 Author: Jesper Wilhelmsson URL: https://git.openjdk.org/guide/commit/907785214ce3129b5594e1b2b39cd9f4fad20f30 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Reminder to remove label Reviewed-by: iris, aivanov ------------- PR: https://git.openjdk.org/guide/pull/136 From duke at openjdk.org Thu Mar 20 16:45:32 2025 From: duke at openjdk.org (Roger Calnan) Date: Thu, 20 Mar 2025 16:45:32 GMT Subject: RFR: Follow-on update due to the introduction of caused-by links [v3] In-Reply-To: References: Message-ID: > Noted that the label regression_ID is now deprecated and a caused-by link should be used. Fixed a couple of typos Roger Calnan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge branch 'master' into causes-link-followon - typo - adjustments from feedback - small update to deprecated sentence - Noted that the label regression_ID is now deprecated and a caused-by link should be used. Fixed a couple of typos ------------- Changes: https://git.openjdk.org/guide/pull/143/files Webrev: https://webrevs.openjdk.org/?repo=guide&pr=143&range=02 Stats: 5 lines in 1 file changed: 0 ins; 1 del; 4 mod Patch: https://git.openjdk.org/guide/pull/143.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/143/head:pull/143 PR: https://git.openjdk.org/guide/pull/143 From duke at openjdk.org Thu Mar 20 16:45:32 2025 From: duke at openjdk.org (Roger Calnan) Date: Thu, 20 Mar 2025 16:45:32 GMT Subject: Integrated: Follow-on update due to the introduction of caused-by links In-Reply-To: References: Message-ID: On Wed, 26 Feb 2025 20:57:39 GMT, Roger Calnan wrote: > Noted that the label regression_ID is now deprecated and a caused-by link should be used. Fixed a couple of typos This pull request has now been integrated. Changeset: a7c63ab1 Author: roger_calnan Committer: Jesper Wilhelmsson URL: https://git.openjdk.org/guide/commit/a7c63ab114348ce25bbe3adb40fc13abb1ed067b Stats: 5 lines in 1 file changed: 0 ins; 1 del; 4 mod Follow-on update due to the introduction of caused-by links Reviewed-by: jwilhelm, aivanov ------------- PR: https://git.openjdk.org/guide/pull/143 From aivanov at openjdk.org Thu Mar 20 17:07:12 2025 From: aivanov at openjdk.org (Alexey Ivanov) Date: Thu, 20 Mar 2025 17:07:12 GMT Subject: RFR: Replace affects_versions.png with SVG [v3] In-Reply-To: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com> References: <2EVDtsXtXKolQJ6k6ef9gy64Su5EpyuV9bI73LGTAdw=.7d04b867-59f1-4f01-9687-42828fcda22a@github.com> Message-ID: > Replace `affects_versions.png` with Scalable Vector Graphics (SVG) image. > >
> PNG vs SVG > > **PNG:**\ > ![affects_versions.png](https://github.com/openjdk/guide/blob/be88a6debcb0dfb7f8fb0e8f3e95ff35950ca9c4/src/images/affects_versions.png?raw=true) > > **SVG:**\ > ![affects_versions.svg](https://raw.githubusercontent.com/aivanov-jdk/dev-guide/bc65ea67251cc68360fc746a77200d8c93fd78b5/src/images/affects_versions.svg) >
> > SVG is crisper, especially on High DPI monitors, its size is much smaller (1.04 KB vs 26.24 KB), it's easier to edit and the edit history is preserved. Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision: End 12-na with circle ------------- Changes: - all: https://git.openjdk.org/guide/pull/147/files - new: https://git.openjdk.org/guide/pull/147/files/3a13348b..c48bff06 Webrevs: - full: https://webrevs.openjdk.org/?repo=guide&pr=147&range=02 - incr: https://webrevs.openjdk.org/?repo=guide&pr=147&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/guide/pull/147.diff Fetch: git fetch https://git.openjdk.org/guide.git pull/147/head:pull/147 PR: https://git.openjdk.org/guide/pull/147