From jwilhelm at openjdk.org  Wed Oct  1 15:08:42 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 1 Oct 2025 15:08:42 GMT
Subject: RFR: Cleanups and fixes [v2]
In-Reply-To: <nG2fsPTLZ9IN9ryDwkDQVXx35KMfTdsJtqFKTU5R8q8=.a8ab8c27-8a4b-427a-bc4d-7598adf50723@github.com>
References: <nG2fsPTLZ9IN9ryDwkDQVXx35KMfTdsJtqFKTU5R8q8=.a8ab8c27-8a4b-427a-bc4d-7598adf50723@github.com>
Message-ID: <AlUOgC4QVFZiPxiQThIVO7LE8jULMex-rM0ktpAZ-Vg=.666daddf-ef05-4e6a-af4b-e64326e7fc5d@github.com>

> Various cleanups and fixes:
> * Removed the "ToDo" from the README - it's been there from the start and had some random things suggested for improvement at the time but it hasn't guided the work or what we have focused on in the guide. It also wasn't updated when changes were made so by now it was mainly outdated.
> * Removed the mention of LTS releases since this is not an OpenJDK concept.
> * Updated Sponsor links in the context of sponsoring a change, the links were referring to the description of sponsoring a Project.
> * Added a note on using N-pool values for FixVersion.
> * Cleaned up description of AffectsVersion.
> * Removed "Things to keep in mind when requesting an improvement" which is already covered in [Contributing to an OpenJDK Project](https://openjdk.org/guide/#contributing-to-an-openjdk-project)
> * Changed backout process to not use sub-tasks.
> * Fixed minor typos etc.

Jesper Wilhelmsson has updated the pull request incrementally with two additional commits since the last revision:

 - Comma
 - Rerun testing

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/159/files
  - new: https://git.openjdk.org/guide/pull/159/files/744a7da5..365df825

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=159&range=01
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=159&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/159.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/159/head:pull/159

PR: https://git.openjdk.org/guide/pull/159

From rriggs at openjdk.org  Wed Oct  1 15:14:56 2025
From: rriggs at openjdk.org (Roger Riggs)
Date: Wed, 1 Oct 2025 15:14:56 GMT
Subject: RFR: Cleanups and fixes [v2]
In-Reply-To: <AlUOgC4QVFZiPxiQThIVO7LE8jULMex-rM0ktpAZ-Vg=.666daddf-ef05-4e6a-af4b-e64326e7fc5d@github.com>
References: <nG2fsPTLZ9IN9ryDwkDQVXx35KMfTdsJtqFKTU5R8q8=.a8ab8c27-8a4b-427a-bc4d-7598adf50723@github.com>
 <AlUOgC4QVFZiPxiQThIVO7LE8jULMex-rM0ktpAZ-Vg=.666daddf-ef05-4e6a-af4b-e64326e7fc5d@github.com>
Message-ID: <y-4ONsRGP7nxbYCanikvGRz1BC0_SMLHIrED5QO9uS0=.fb28b1d7-cad7-4b07-9414-00d8cb19aa25@github.com>

On Wed, 1 Oct 2025 15:08:42 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Various cleanups and fixes:
>> * Removed the "ToDo" from the README - it's been there from the start and had some random things suggested for improvement at the time but it hasn't guided the work or what we have focused on in the guide. It also wasn't updated when changes were made so by now it was mainly outdated.
>> * Removed the mention of LTS releases since this is not an OpenJDK concept.
>> * Updated Sponsor links in the context of sponsoring a change, the links were referring to the description of sponsoring a Project.
>> * Added a note on using N-pool values for FixVersion.
>> * Cleaned up description of AffectsVersion.
>> * Removed "Things to keep in mind when requesting an improvement" which is already covered in [Contributing to an OpenJDK Project](https://openjdk.org/guide/#contributing-to-an-openjdk-project)
>> * Changed backout process to not use sub-tasks.
>> * Fixed minor typos etc.
>
> Jesper Wilhelmsson has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Comma
>  - Rerun testing

Marked as reviewed by rriggs (no project role).

-------------

PR Review: https://git.openjdk.org/guide/pull/159#pullrequestreview-3289736755

From jwilhelm at openjdk.org  Wed Oct  1 15:14:57 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 1 Oct 2025 15:14:57 GMT
Subject: RFR: Cleanups and fixes [v2]
In-Reply-To: <jhW_QEAbgz4tG6rPqxcNqjpMao5app_h_3AN9CpDDQc=.f3b5786a-1b06-4eaf-ad63-3a4f013568e7@github.com>
References: <nG2fsPTLZ9IN9ryDwkDQVXx35KMfTdsJtqFKTU5R8q8=.a8ab8c27-8a4b-427a-bc4d-7598adf50723@github.com>
 <jhW_QEAbgz4tG6rPqxcNqjpMao5app_h_3AN9CpDDQc=.f3b5786a-1b06-4eaf-ad63-3a4f013568e7@github.com>
Message-ID: <D88evL7-hfgHimP5w__gmUUQvCquPUIzBS-nebdZI9w=.17628ef5-0591-4402-981b-25d1b48c0c41@github.com>

On Tue, 30 Sep 2025 19:40:45 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Comma
>>  - Rerun testing
>
> src/guide/jbs-jdk-bug-system.md line 83:
> 
>> 81:     - Note that if it's reported against an update release then all we can say is that it's applicable to all the following update releases, not necessarily the next feature release as it may have been introduced in an update. Given this, it is always important to try and reproduce the issue in the corresponding feature release as well as mainline.
>> 82: 
>> 83: 1) If an issue is applicable to release N, then it can't be assumed that it is applicable to older releases less than N. It may be, but in general this is less important to know, as the majority of issues are only fixed in the latest feature release. If the issue is a crash or important in another way, then it becomes worthwhile to take the time to determine if it's relevant to earlier maintained releases.
> 
> Maybe say explicitly "earlier releases maintained by the jdk-updates project"?

I deliberately made this slightly vague since the releases maintained by the jdk-updates project isn't necessarily the same releases as various companies supports or the releases tagged as LTSes. Different readers will have different opinions on what releases are "maintained".

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/159#discussion_r2394960189

From jwilhelm at openjdk.org  Wed Oct  1 15:35:16 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 1 Oct 2025 15:35:16 GMT
Subject: RFR: Cleanups and fixes [v2]
In-Reply-To: <oTDV-r3FEcboHFFI-dM6o3nF44zLYGe_rgp5qe03thM=.2560f95d-6721-4e1d-9ef9-a692d7396e2c@github.com>
References: <nG2fsPTLZ9IN9ryDwkDQVXx35KMfTdsJtqFKTU5R8q8=.a8ab8c27-8a4b-427a-bc4d-7598adf50723@github.com>
 <jhW_QEAbgz4tG6rPqxcNqjpMao5app_h_3AN9CpDDQc=.f3b5786a-1b06-4eaf-ad63-3a4f013568e7@github.com>
 <oTDV-r3FEcboHFFI-dM6o3nF44zLYGe_rgp5qe03thM=.2560f95d-6721-4e1d-9ef9-a692d7396e2c@github.com>
Message-ID: <EgeGBSplcl_823h1wd7oQy-FMNNd2nJaPue6oKU9Olw=.77193ccf-0415-4997-bbd7-03893a6dbec5@github.com>

On Tue, 30 Sep 2025 21:59:30 GMT, Iris Clark <iris at openjdk.org> wrote:

>> src/guide/code-owners.md line 3:
>> 
>>> 1: # Code Owners
>>> 2: 
>>> 3: This list is intended to make it easier to identify which email list to include in code reviews when making changes in different areas. The list may also help when assigning bugs based on which code they are found in. Please note that some directories may have been created or removed between releases. The intention here is to include directories that exists in mainline and other releases (post JDK 9) commonly being updated.
>> 
>> Should we specify that "commonly being updated" means being updated by jdk-updates project?
>
> I think that "commonly being updated" refers to both feature and update releases, so I don't think a clarification needs to be provided.
> 
> You may want to consider this minor tweak to the sentence: "The intention is to include commonly updated directories that exist in mainline and other releases (post JDK 9)." ("intention here" -> "intention", "exists" -> "exist", relocate "commonly... " phrase).

I want the focus to be on commonly updated releases, not commonly updated directories.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/159#discussion_r2395031091

From iris at openjdk.org  Wed Oct  1 19:23:23 2025
From: iris at openjdk.org (Iris Clark)
Date: Wed, 1 Oct 2025 19:23:23 GMT
Subject: RFR: Cleanups and fixes [v2]
In-Reply-To: <EgeGBSplcl_823h1wd7oQy-FMNNd2nJaPue6oKU9Olw=.77193ccf-0415-4997-bbd7-03893a6dbec5@github.com>
References: <nG2fsPTLZ9IN9ryDwkDQVXx35KMfTdsJtqFKTU5R8q8=.a8ab8c27-8a4b-427a-bc4d-7598adf50723@github.com>
 <jhW_QEAbgz4tG6rPqxcNqjpMao5app_h_3AN9CpDDQc=.f3b5786a-1b06-4eaf-ad63-3a4f013568e7@github.com>
 <oTDV-r3FEcboHFFI-dM6o3nF44zLYGe_rgp5qe03thM=.2560f95d-6721-4e1d-9ef9-a692d7396e2c@github.com>
 <EgeGBSplcl_823h1wd7oQy-FMNNd2nJaPue6oKU9Olw=.77193ccf-0415-4997-bbd7-03893a6dbec5@github.com>
Message-ID: <eB8wqL_VUzJhrYmo6wXkGc_As3PExucqMGpICBFwGLI=.5da8e1a5-3702-4240-88b6-b10d5a71aeda@github.com>

On Wed, 1 Oct 2025 15:32:11 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> I think that "commonly being updated" refers to both feature and update releases, so I don't think a clarification needs to be provided.
>> 
>> You may want to consider this minor tweak to the sentence: "The intention is to include commonly updated directories that exist in mainline and other releases (post JDK 9)." ("intention here" -> "intention", "exists" -> "exist", relocate "commonly... " phrase).
>
> I want the focus to be on commonly updated releases, not commonly updated directories.

Ah, sorry about that. I revise my minor tweak to "The intention is to include directories that exist in mainline and other commonly updated releases (post JDK 9)."

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/159#discussion_r2395641765

From iris at openjdk.org  Wed Oct  1 19:23:25 2025
From: iris at openjdk.org (Iris Clark)
Date: Wed, 1 Oct 2025 19:23:25 GMT
Subject: RFR: Cleanups and fixes [v2]
In-Reply-To: <D88evL7-hfgHimP5w__gmUUQvCquPUIzBS-nebdZI9w=.17628ef5-0591-4402-981b-25d1b48c0c41@github.com>
References: <nG2fsPTLZ9IN9ryDwkDQVXx35KMfTdsJtqFKTU5R8q8=.a8ab8c27-8a4b-427a-bc4d-7598adf50723@github.com>
 <jhW_QEAbgz4tG6rPqxcNqjpMao5app_h_3AN9CpDDQc=.f3b5786a-1b06-4eaf-ad63-3a4f013568e7@github.com>
 <D88evL7-hfgHimP5w__gmUUQvCquPUIzBS-nebdZI9w=.17628ef5-0591-4402-981b-25d1b48c0c41@github.com>
Message-ID: <BsAWJZa2vfzgVNFiNO564S9HFQGy0NYzMZNlSeJ-li8=.dcee9dc1-7f39-40a5-a212-60263d738963@github.com>

On Wed, 1 Oct 2025 15:09:08 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> src/guide/jbs-jdk-bug-system.md line 83:
>> 
>>> 81:     - Note that if it's reported against an update release then all we can say is that it's applicable to all the following update releases, not necessarily the next feature release as it may have been introduced in an update. Given this, it is always important to try and reproduce the issue in the corresponding feature release as well as mainline.
>>> 82: 
>>> 83: 1) If an issue is applicable to release N, then it can't be assumed that it is applicable to older releases less than N. It may be, but in general this is less important to know, as the majority of issues are only fixed in the latest feature release. If the issue is a crash or important in another way, then it becomes worthwhile to take the time to determine if it's relevant to earlier maintained releases.
>> 
>> Maybe say explicitly "earlier releases maintained by the jdk-updates project"?
>
> I deliberately made this slightly vague since the releases maintained by the jdk-updates project isn't necessarily the same releases as various companies supports or the releases tagged as LTSes. Different readers will have different opinions on what releases are "maintained".

I agree with the intentional vagueness.  Also note that 8u is maintained by the JDK 8 Updates Project, not the JDK Updates Project.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/159#discussion_r2395635085

From jwilhelm at openjdk.org  Thu Oct  2 22:49:58 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 2 Oct 2025 22:49:58 GMT
Subject: RFR: Cleanups and fixes [v3]
In-Reply-To: <nG2fsPTLZ9IN9ryDwkDQVXx35KMfTdsJtqFKTU5R8q8=.a8ab8c27-8a4b-427a-bc4d-7598adf50723@github.com>
References: <nG2fsPTLZ9IN9ryDwkDQVXx35KMfTdsJtqFKTU5R8q8=.a8ab8c27-8a4b-427a-bc4d-7598adf50723@github.com>
Message-ID: <KPvOUqu3vx75kq_aLs-w0yCdN5olGN_wF8d53Hv2EBk=.8de064fa-b264-49f4-ac1f-fcee0d47f866@github.com>

> Various cleanups and fixes:
> * Removed the "ToDo" from the README - it's been there from the start and had some random things suggested for improvement at the time but it hasn't guided the work or what we have focused on in the guide. It also wasn't updated when changes were made so by now it was mainly outdated.
> * Removed the mention of LTS releases since this is not an OpenJDK concept.
> * Updated Sponsor links in the context of sponsoring a change, the links were referring to the description of sponsoring a Project.
> * Added a note on using N-pool values for FixVersion.
> * Cleaned up description of AffectsVersion.
> * Removed "Things to keep in mind when requesting an improvement" which is already covered in [Contributing to an OpenJDK Project](https://openjdk.org/guide/#contributing-to-an-openjdk-project)
> * Changed backout process to not use sub-tasks.
> * Fixed minor typos etc.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  Fixed the intention

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/159/files
  - new: https://git.openjdk.org/guide/pull/159/files/365df825..c5c039c1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=159&range=02
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=159&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/159.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/159/head:pull/159

PR: https://git.openjdk.org/guide/pull/159

From jwilhelm at openjdk.org  Thu Oct  2 22:49:59 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 2 Oct 2025 22:49:59 GMT
Subject: RFR: Cleanups and fixes [v3]
In-Reply-To: <eB8wqL_VUzJhrYmo6wXkGc_As3PExucqMGpICBFwGLI=.5da8e1a5-3702-4240-88b6-b10d5a71aeda@github.com>
References: <nG2fsPTLZ9IN9ryDwkDQVXx35KMfTdsJtqFKTU5R8q8=.a8ab8c27-8a4b-427a-bc4d-7598adf50723@github.com>
 <jhW_QEAbgz4tG6rPqxcNqjpMao5app_h_3AN9CpDDQc=.f3b5786a-1b06-4eaf-ad63-3a4f013568e7@github.com>
 <oTDV-r3FEcboHFFI-dM6o3nF44zLYGe_rgp5qe03thM=.2560f95d-6721-4e1d-9ef9-a692d7396e2c@github.com>
 <EgeGBSplcl_823h1wd7oQy-FMNNd2nJaPue6oKU9Olw=.77193ccf-0415-4997-bbd7-03893a6dbec5@github.com>
 <eB8wqL_VUzJhrYmo6wXkGc_As3PExucqMGpICBFwGLI=.5da8e1a5-3702-4240-88b6-b10d5a71aeda@github.com>
Message-ID: <uG_Ko3UHIoR_UjqbuQXig_38JAXPRmZztvsjPdBI3vE=.1044fa1a-8589-46b3-ba66-0160ece2e135@github.com>

On Wed, 1 Oct 2025 19:21:12 GMT, Iris Clark <iris at openjdk.org> wrote:

>> I want the focus to be on commonly updated releases, not commonly updated directories.
>
> Ah, sorry about that. I revise my minor tweak to "The intention is to include directories that exist in mainline and other commonly updated releases (post JDK 9)."

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/159#discussion_r2400296949

From jwilhelm at openjdk.org  Thu Oct  2 22:50:00 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 2 Oct 2025 22:50:00 GMT
Subject: Integrated: Cleanups and fixes
In-Reply-To: <nG2fsPTLZ9IN9ryDwkDQVXx35KMfTdsJtqFKTU5R8q8=.a8ab8c27-8a4b-427a-bc4d-7598adf50723@github.com>
References: <nG2fsPTLZ9IN9ryDwkDQVXx35KMfTdsJtqFKTU5R8q8=.a8ab8c27-8a4b-427a-bc4d-7598adf50723@github.com>
Message-ID: <_Z6Tz7jPVOzu0-Y3p_ZYOst4rZ_ZQPK-ighJTN7HE4w=.e84b397a-1dae-4032-954d-5a6de11df7ff@github.com>

On Tue, 30 Sep 2025 19:10:10 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Various cleanups and fixes:
> * Removed the "ToDo" from the README - it's been there from the start and had some random things suggested for improvement at the time but it hasn't guided the work or what we have focused on in the guide. It also wasn't updated when changes were made so by now it was mainly outdated.
> * Removed the mention of LTS releases since this is not an OpenJDK concept.
> * Updated Sponsor links in the context of sponsoring a change, the links were referring to the description of sponsoring a Project.
> * Added a note on using N-pool values for FixVersion.
> * Cleaned up description of AffectsVersion.
> * Removed "Things to keep in mind when requesting an improvement" which is already covered in [Contributing to an OpenJDK Project](https://openjdk.org/guide/#contributing-to-an-openjdk-project)
> * Changed backout process to not use sub-tasks.
> * Fixed minor typos etc.

This pull request has now been integrated.

Changeset: 0e977dfb
Author:    Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/0e977dfbc452e97b89f983d19c3fe02629441a28
Stats:     61 lines in 8 files changed: 5 ins; 30 del; 26 mod

Cleanups and fixes

Reviewed-by: rriggs, iris

-------------

PR: https://git.openjdk.org/guide/pull/159

From jwilhelm at openjdk.org  Thu Oct  9 21:20:16 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 9 Oct 2025 21:20:16 GMT
Subject: RFR: Fixed backing out a backport
Message-ID: <GyAbXJAQ3wFaxYWhZxU7cQoIV_WXT8LS3Froc9K9s_s=.6fd43d82-ee45-4376-85bb-38d79ae56638@github.com>

Backing out a change was updated to not use sub-tasks, but the similar case of backing out a backport was missed.

-------------

Commit messages:
 - Fixed word
 - Fixed backing out a backport

Changes: https://git.openjdk.org/guide/pull/160/files
  Webrev: https://webrevs.openjdk.org/?repo=guide&pr=160&range=00
  Stats: 23 lines in 2 files changed: 5 ins; 4 del; 14 mod
  Patch: https://git.openjdk.org/guide/pull/160.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/160/head:pull/160

PR: https://git.openjdk.org/guide/pull/160

From kcr at openjdk.org  Thu Oct  9 21:43:39 2025
From: kcr at openjdk.org (Kevin Rushforth)
Date: Thu, 9 Oct 2025 21:43:39 GMT
Subject: RFR: Fixed backing out a backport
In-Reply-To: <GyAbXJAQ3wFaxYWhZxU7cQoIV_WXT8LS3Froc9K9s_s=.6fd43d82-ee45-4376-85bb-38d79ae56638@github.com>
References: <GyAbXJAQ3wFaxYWhZxU7cQoIV_WXT8LS3Froc9K9s_s=.6fd43d82-ee45-4376-85bb-38d79ae56638@github.com>
Message-ID: <k3sxxEwj5EvU36HTx0SiaVvvIpFGRqrg7lr4nCbjqH0=.c8cff835-80d3-406c-bdd0-ee82cd24caf5@github.com>

On Thu, 9 Oct 2025 21:11:28 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Backing out a change was updated to not use sub-tasks, but the similar case of backing out a backport was missed.

You have the direction of the causes / caused-by links reversed.

src/guide/testing-the-jdk.md line 323:

> 321:      * Create a new issue of type [Bug]{.jbs-value}. This new issue will be the backout-issue **(B)**.
> 322:      * Use the same summary as **(O)** prefixed with `[BACKOUT]`.
> 323:      * Add a _causes_ link from **(B)** to **(O)**.

This should be a _caused-by_ link from (B) to (O), or conversely, a _causes_ link from (O) to (B). The direction is important.

These are the links we want to end up with:

* (B) is caused-by (O)
* (O) causes (B)

src/guide/testing-the-jdk.md line 327:

> 325:      * Use the investigation issue **(I)** for the backout. (Don't create a new **(B)**.)
> 326:      * Change summary of **(I)** to the same as **(O)** and prefix with `[BACKOUT]`.
> 327:      * Add a _causes_ link from **(I)** and **(O)**.

That should be "from...to" (not "...and")

Also, that should be: Add _caused-by_ link from (I) to (O), or conversely, a _causes_ link from (O) to (I)?

src/guide/testing-the-jdk.md line 399:

> 397:      * Create a new issue of type [Bug]{.jbs-value}. This new issue will be the backout-issue **(B)**.
> 398:      * Use the same summary as **(M)** prefixed with `[BACKOUT BACKPORT]`.
> 399:      * Add a _causes_ link from **(B)** to **(O)**.

_caused-by_ link from (B) to (O)

src/guide/testing-the-jdk.md line 403:

> 401:      * Use the investigation issue **(I)** for the backout. (Don't create a new **(B)**.)
> 402:      * Change summary of **(I)** to the same as **(M)** and prefix with `[BACKOUT BACKPORT]`.
> 403:      * Add a _causes_ link from **(I)** to **(O)**.

_caused-by_ link from (I) to (O)

-------------

PR Review: https://git.openjdk.org/guide/pull/160#pullrequestreview-3320715690
PR Review Comment: https://git.openjdk.org/guide/pull/160#discussion_r2418012883
PR Review Comment: https://git.openjdk.org/guide/pull/160#discussion_r2418015640
PR Review Comment: https://git.openjdk.org/guide/pull/160#discussion_r2418018651
PR Review Comment: https://git.openjdk.org/guide/pull/160#discussion_r2418019205

From jwilhelm at openjdk.org  Mon Oct 13 22:56:55 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Mon, 13 Oct 2025 22:56:55 GMT
Subject: RFR: Fixed backing out a backport [v2]
In-Reply-To: <GyAbXJAQ3wFaxYWhZxU7cQoIV_WXT8LS3Froc9K9s_s=.6fd43d82-ee45-4376-85bb-38d79ae56638@github.com>
References: <GyAbXJAQ3wFaxYWhZxU7cQoIV_WXT8LS3Froc9K9s_s=.6fd43d82-ee45-4376-85bb-38d79ae56638@github.com>
Message-ID: <QA1E-7QdrpZe-7fZJjjHAEBdn93RkMZg9F7BxjUFptU=.bfe37ddb-2ce9-4ccf-8f91-7fef1fd591e6@github.com>

> Backing out a change was updated to not use sub-tasks, but the similar case of backing out a backport was missed.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  O to I

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/160/files
  - new: https://git.openjdk.org/guide/pull/160/files/dedf9813..50ddd26c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=160&range=01
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=160&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/guide/pull/160.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/160/head:pull/160

PR: https://git.openjdk.org/guide/pull/160

From jwilhelm at openjdk.org  Mon Oct 13 22:57:00 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Mon, 13 Oct 2025 22:57:00 GMT
Subject: RFR: Fixed backing out a backport [v2]
In-Reply-To: <k3sxxEwj5EvU36HTx0SiaVvvIpFGRqrg7lr4nCbjqH0=.c8cff835-80d3-406c-bdd0-ee82cd24caf5@github.com>
References: <GyAbXJAQ3wFaxYWhZxU7cQoIV_WXT8LS3Froc9K9s_s=.6fd43d82-ee45-4376-85bb-38d79ae56638@github.com>
 <k3sxxEwj5EvU36HTx0SiaVvvIpFGRqrg7lr4nCbjqH0=.c8cff835-80d3-406c-bdd0-ee82cd24caf5@github.com>
Message-ID: <bE1WU39d_yO36wv_bmOClJ8AlWPdW-v1kDKuOfV9LJE=.9b9bce16-d2d4-43d7-b333-474bfffdcd97@github.com>

On Thu, 9 Oct 2025 21:35:58 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   O to I
>
> src/guide/testing-the-jdk.md line 323:
> 
>> 321:      * Create a new issue of type [Bug]{.jbs-value}. This new issue will be the backout-issue **(B)**.
>> 322:      * Use the same summary as **(O)** prefixed with `[BACKOUT]`.
>> 323:      * Add a _causes_ link from **(B)** to **(O)**.
> 
> This should be a _caused-by_ link from (B) to (O), or conversely, a _causes_ link from (O) to (B). The direction is important.
> 
> These are the links we want to end up with:
> 
> * (B) is caused-by (O)
> * (O) causes (B)

I knew that would happen. I had to change to a causes link in the mermaid picture since it refused to place the boxes in a decent way with the link in the other direction, and last minute I realized I had to change the text to match the picture. Fixed now.

> src/guide/testing-the-jdk.md line 327:
> 
>> 325:      * Use the investigation issue **(I)** for the backout. (Don't create a new **(B)**.)
>> 326:      * Change summary of **(I)** to the same as **(O)** and prefix with `[BACKOUT]`.
>> 327:      * Add a _causes_ link from **(I)** and **(O)**.
> 
> That should be "from...to" (not "...and")
> 
> Also, that should be: Add _caused-by_ link from (I) to (O), or conversely, a _causes_ link from (O) to (I)?

Fixed.

> src/guide/testing-the-jdk.md line 399:
> 
>> 397:      * Create a new issue of type [Bug]{.jbs-value}. This new issue will be the backout-issue **(B)**.
>> 398:      * Use the same summary as **(M)** prefixed with `[BACKOUT BACKPORT]`.
>> 399:      * Add a _causes_ link from **(B)** to **(O)**.
> 
> _caused-by_ link from (B) to (O)

Fixed.

> src/guide/testing-the-jdk.md line 403:
> 
>> 401:      * Use the investigation issue **(I)** for the backout. (Don't create a new **(B)**.)
>> 402:      * Change summary of **(I)** to the same as **(M)** and prefix with `[BACKOUT BACKPORT]`.
>> 403:      * Add a _causes_ link from **(I)** to **(O)**.
> 
> _caused-by_ link from (I) to (O)

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/160#discussion_r2427512505
PR Review Comment: https://git.openjdk.org/guide/pull/160#discussion_r2427513127
PR Review Comment: https://git.openjdk.org/guide/pull/160#discussion_r2427513563
PR Review Comment: https://git.openjdk.org/guide/pull/160#discussion_r2427513977

From kcr at openjdk.org  Mon Oct 13 23:23:39 2025
From: kcr at openjdk.org (Kevin Rushforth)
Date: Mon, 13 Oct 2025 23:23:39 GMT
Subject: RFR: Fixed backing out a backport [v2]
In-Reply-To: <QA1E-7QdrpZe-7fZJjjHAEBdn93RkMZg9F7BxjUFptU=.bfe37ddb-2ce9-4ccf-8f91-7fef1fd591e6@github.com>
References: <GyAbXJAQ3wFaxYWhZxU7cQoIV_WXT8LS3Froc9K9s_s=.6fd43d82-ee45-4376-85bb-38d79ae56638@github.com>
 <QA1E-7QdrpZe-7fZJjjHAEBdn93RkMZg9F7BxjUFptU=.bfe37ddb-2ce9-4ccf-8f91-7fef1fd591e6@github.com>
Message-ID: <4vunLsCFYAZG5HKxsrcnw9RUHNqJ1NG4SpTc4qWw5bk=.3846e9bc-fe0d-4448-8879-f2bc6cdbc273@github.com>

On Mon, 13 Oct 2025 22:56:55 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Backing out a change was updated to not use sub-tasks, but the similar case of backing out a backport was missed.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   O to I

Marked as reviewed by kcr (no project role).

-------------

PR Review: https://git.openjdk.org/guide/pull/160#pullrequestreview-3333363956

From iris at openjdk.org  Tue Oct 14 05:58:43 2025
From: iris at openjdk.org (Iris Clark)
Date: Tue, 14 Oct 2025 05:58:43 GMT
Subject: RFR: Fixed backing out a backport [v2]
In-Reply-To: <QA1E-7QdrpZe-7fZJjjHAEBdn93RkMZg9F7BxjUFptU=.bfe37ddb-2ce9-4ccf-8f91-7fef1fd591e6@github.com>
References: <GyAbXJAQ3wFaxYWhZxU7cQoIV_WXT8LS3Froc9K9s_s=.6fd43d82-ee45-4376-85bb-38d79ae56638@github.com>
 <QA1E-7QdrpZe-7fZJjjHAEBdn93RkMZg9F7BxjUFptU=.bfe37ddb-2ce9-4ccf-8f91-7fef1fd591e6@github.com>
Message-ID: <6NsTzLTmcR8fQHggdpkQnHig2MqE2gnTR1cvnnn7D-k=.2176967b-a311-44a2-b48b-0ab5da60989f@github.com>

On Mon, 13 Oct 2025 22:56:55 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Backing out a change was updated to not use sub-tasks, but the similar case of backing out a backport was missed.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   O to I

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/guide/pull/160#pullrequestreview-3334001208

From jwilhelm at openjdk.org  Tue Oct 14 11:13:20 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 14 Oct 2025 11:13:20 GMT
Subject: RFR: Fixed backing out a backport [v3]
In-Reply-To: <GyAbXJAQ3wFaxYWhZxU7cQoIV_WXT8LS3Froc9K9s_s=.6fd43d82-ee45-4376-85bb-38d79ae56638@github.com>
References: <GyAbXJAQ3wFaxYWhZxU7cQoIV_WXT8LS3Froc9K9s_s=.6fd43d82-ee45-4376-85bb-38d79ae56638@github.com>
Message-ID: <KXMAGWT3pcdt9kdcpnSh3xRIE3QK2sYD7Pkb14RdvEM=.0c8e8ca8-d5e7-4ffa-84e6-fed5d2954675@github.com>

> Backing out a change was updated to not use sub-tasks, but the similar case of backing out a backport was missed.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  Fix link

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/160/files
  - new: https://git.openjdk.org/guide/pull/160/files/50ddd26c..67decbdf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=160&range=02
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=160&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/160.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/160/head:pull/160

PR: https://git.openjdk.org/guide/pull/160

From jwilhelm at openjdk.org  Tue Oct 14 11:30:44 2025
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 14 Oct 2025 11:30:44 GMT
Subject: Integrated: Fixed backing out a backport
In-Reply-To: <GyAbXJAQ3wFaxYWhZxU7cQoIV_WXT8LS3Froc9K9s_s=.6fd43d82-ee45-4376-85bb-38d79ae56638@github.com>
References: <GyAbXJAQ3wFaxYWhZxU7cQoIV_WXT8LS3Froc9K9s_s=.6fd43d82-ee45-4376-85bb-38d79ae56638@github.com>
Message-ID: <X5aN-EYGHFH6Q9qKQJX9w_L5FkKqBEQiK21Z9DKxhjs=.a1d98236-005e-4f58-9363-3bd5ad819410@github.com>

On Thu, 9 Oct 2025 21:11:28 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Backing out a change was updated to not use sub-tasks, but the similar case of backing out a backport was missed.

This pull request has now been integrated.

Changeset: 29245b3e
Author:    Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/29245b3e881459abbb5eeedaeec26005bdde0d4c
Stats:     24 lines in 3 files changed: 5 ins; 4 del; 15 mod

Fixed backing out a backport

Reviewed-by: kcr, iris

-------------

PR: https://git.openjdk.org/guide/pull/160