RFR: Fixed backing out a backport [v2]
Jesper Wilhelmsson
jwilhelm at openjdk.org
Mon Oct 13 22:57:00 UTC 2025
On Thu, 9 Oct 2025 21:35:58 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> O to I
>
> src/guide/testing-the-jdk.md line 323:
>
>> 321: * Create a new issue of type [Bug]{.jbs-value}. This new issue will be the backout-issue **(B)**.
>> 322: * Use the same summary as **(O)** prefixed with `[BACKOUT]`.
>> 323: * Add a _causes_ link from **(B)** to **(O)**.
>
> This should be a _caused-by_ link from (B) to (O), or conversely, a _causes_ link from (O) to (B). The direction is important.
>
> These are the links we want to end up with:
>
> * (B) is caused-by (O)
> * (O) causes (B)
I knew that would happen. I had to change to a causes link in the mermaid picture since it refused to place the boxes in a decent way with the link in the other direction, and last minute I realized I had to change the text to match the picture. Fixed now.
> src/guide/testing-the-jdk.md line 327:
>
>> 325: * Use the investigation issue **(I)** for the backout. (Don't create a new **(B)**.)
>> 326: * Change summary of **(I)** to the same as **(O)** and prefix with `[BACKOUT]`.
>> 327: * Add a _causes_ link from **(I)** and **(O)**.
>
> That should be "from...to" (not "...and")
>
> Also, that should be: Add _caused-by_ link from (I) to (O), or conversely, a _causes_ link from (O) to (I)?
Fixed.
> src/guide/testing-the-jdk.md line 399:
>
>> 397: * Create a new issue of type [Bug]{.jbs-value}. This new issue will be the backout-issue **(B)**.
>> 398: * Use the same summary as **(M)** prefixed with `[BACKOUT BACKPORT]`.
>> 399: * Add a _causes_ link from **(B)** to **(O)**.
>
> _caused-by_ link from (B) to (O)
Fixed.
> src/guide/testing-the-jdk.md line 403:
>
>> 401: * Use the investigation issue **(I)** for the backout. (Don't create a new **(B)**.)
>> 402: * Change summary of **(I)** to the same as **(M)** and prefix with `[BACKOUT BACKPORT]`.
>> 403: * Add a _causes_ link from **(I)** to **(O)**.
>
> _caused-by_ link from (I) to (O)
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/160#discussion_r2427512505
PR Review Comment: https://git.openjdk.org/guide/pull/160#discussion_r2427513127
PR Review Comment: https://git.openjdk.org/guide/pull/160#discussion_r2427513563
PR Review Comment: https://git.openjdk.org/guide/pull/160#discussion_r2427513977
More information about the guide-dev
mailing list