RFR: Select component when filing issue [v3]
Alexey Ivanov
aivanov at openjdk.org
Tue Feb 3 21:13:47 UTC 2026
On Mon, 2 Feb 2026 23:44:25 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:
>> Added missing info about components when filing a JBS issue
>> Also clarified how to close a resolved issue through verification
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>
> See table
Changes requested by aivanov (no project role).
src/guide/jbs-jdk-bug-system.md line 286:
> 284: Once the work on an issue has been completed the issue's [Status]{.jbs-field} should be in a "completed" state. There are two "completed" states: [Resolved]{.jbs-value} and [Closed]{.jbs-value}. These are accompanied by a [Resolution]{.jbs-field} and a [Fix Version/s]{.jbs-value}. Which combination of [Status]{.jbs-field}, [Resolution]{.jbs-field}, and [Fix Version/s]{.jbs-value} you should use depends on how the issue is completed.
> 285:
> 286: When a change is integrated into a project repository, the corresponding JBS issue should be [Resolved]{.jbs-value} with the resolution [Fixed]{.jbs-value}. For the JDK Project, in almost all cases the bots will transition the issue to [Resolved]{.jbs-value}/[Fixed]{.jbs-value} automatically when the changeset is integrated. There are a few more cases where you want to indicate that a change has been integrated into a project repository that must also go through the [Resolved]{.jbs-value} state, but in most other cases where you close an issue manually, it should go directly to [Closed]{.jbs-value} with the appropriate resolution. See the table below for more details.
Suggestion:
When a change is integrated into a project repository, the corresponding JBS issue should be [Resolved]{.jbs-value} with the resolution [Fixed]{.jbs-value}. For the JDK Project, in almost all cases the bots will transition the issue to [Resolved]{.jbs-value}/[Fixed]{.jbs-value} automatically when the changeset is integrated. There are a few more cases where you want to indicate that a change has been integrated into a project repository that must also go through the [Resolved]{.jbs-value} state. In other cases where you close an issue manually, it should go directly to [Closed]{.jbs-value} with the appropriate resolution. See the table below for more details.
I suggest putting a full stop after “Resolved” and starting the following sentence with “in other cases…”. Essentially, there are two cases:
1. A changeset is integrated -> Resolved/Fixed;
2. Otherwise, Closed with an appropriate resolution.
Yes, I also think that “…to Closed with the appropriate resolution” should use the indefinite article, any other resolution but *Fixed*.
Is there a way to link to “the table below”?
src/guide/jbs-jdk-bug-system.md line 288:
> 286: When a change is integrated into a project repository, the corresponding JBS issue should be [Resolved]{.jbs-value} with the resolution [Fixed]{.jbs-value}. For the JDK Project, in almost all cases the bots will transition the issue to [Resolved]{.jbs-value}/[Fixed]{.jbs-value} automatically when the changeset is integrated. There are a few more cases where you want to indicate that a change has been integrated into a project repository that must also go through the [Resolved]{.jbs-value} state, but in most other cases where you close an issue manually, it should go directly to [Closed]{.jbs-value} with the appropriate resolution. See the table below for more details.
> 287:
> 288: An issue in [Resolved]{.jbs-value} state needs to go through [verification](#verifying-an-issue) to end up as [Closed]{.jbs-value}. If you accidentally end up in a [Resolved]{.jbs-value} state for a resolution that should only be [Closed]{.jbs-value}, use the "Verify" option in the state transition menu and select verification [None]{.jbs-value}.
Suggestion:
An issue in [Resolved]{.jbs-value} state needs to go through [verification](#verifying-an-issue) to end up as [Closed]{.jbs-value}. If you accidentally move an issue to the [Resolved]{.jbs-value} state for a resolution that should only be [Closed]{.jbs-value}, use the "Verify" option in the state transition menu and select verification [None]{.jbs-value}.
I feel that “you … end up in a Resolved state” is an awkward statement. *You* performed an action to **resolve** an issue rather than **close**. I proposed *“move”* instead because using “resolve” and “close” as the verbs here could be confusing.
Usually, references to UI commands, such as **Verify** in this case, are marked up with bold text. If this guide uses quotes instead, it's better to leave it like this for consistency.
-------------
PR Review: https://git.openjdk.org/guide/pull/169#pullrequestreview-3747581197
PR Review Comment: https://git.openjdk.org/guide/pull/169#discussion_r2760994588
PR Review Comment: https://git.openjdk.org/guide/pull/169#discussion_r2761020579
More information about the guide-dev
mailing list