RFR: Select component when filing issue [v3]

Alexey Ivanov aivanov at openjdk.org
Thu Feb 5 20:20:25 UTC 2026


On Thu, 5 Feb 2026 09:06:48 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> src/guide/jbs-jdk-bug-system.md line 286:
>> 
>>> 284: Once the work on an issue has been completed the issue's [Status]{.jbs-field} should be in a "completed" state. There are two "completed" states: [Resolved]{.jbs-value} and [Closed]{.jbs-value}. These are accompanied by a [Resolution]{.jbs-field} and a [Fix Version/s]{.jbs-value}. Which combination of [Status]{.jbs-field}, [Resolution]{.jbs-field}, and [Fix Version/s]{.jbs-value} you should use depends on how the issue is completed.
>>> 285: 
>>> 286: When a change is integrated into a project repository, the corresponding JBS issue should be [Resolved]{.jbs-value} with the resolution [Fixed]{.jbs-value}. For the JDK Project, in almost all cases the bots will transition the issue to [Resolved]{.jbs-value}/[Fixed]{.jbs-value} automatically when the changeset is integrated. There are a few more cases where you want to indicate that a change has been integrated into a project repository that must also go through the [Resolved]{.jbs-value} state, but in most other cases where you close an issue manually, it should go directly to [Closed]{.jbs-value} with the appropriate resolution. See the table below for more details.
>> 
>> Suggestion:
>> 
>> When a change is integrated into a project repository, the corresponding JBS issue should be [Resolved]{.jbs-value} with the resolution [Fixed]{.jbs-value}. For the JDK Project, in almost all cases the bots will transition the issue to [Resolved]{.jbs-value}/[Fixed]{.jbs-value} automatically when the changeset is integrated. There are a few more cases where you want to indicate that a change has been integrated into a project repository that must also go through the [Resolved]{.jbs-value} state. In other cases where you close an issue manually, it should go directly to [Closed]{.jbs-value} with the appropriate resolution. See the table below for more details.
>> 
>> 
>> I suggest putting a full stop after “Resolved” and starting the following sentence with “in other cases…”. Essentially, there are two cases:
>> 
>> 1. A changeset is integrated -> Resolved/Fixed;
>> 2. Otherwise, Closed with an appropriate resolution.
>> 
>> Yes, I also think that “…to Closed with the appropriate resolution” should use the *indefinite* article: any other resolution but *Fixed*.
>> 
>> Is there a way to link to “the table below”?
>
> There are other cases than fixed that go to resolved, like delivered and incomplete.

Okay. I think what I proposed still remains correct:

1. “There are *a few more cases* where you want to indicate that a change has been integrated into a project repository that must also go through the **Resolved** state.
2. “*In other cases* where you close an issue manually, it should go directly to **Closed** with the appropriate resolution. See the table below for more details.”

The first case captures the two other statuses which go via the **Resolved** state.

Other statuses that's left go directly to the *Closed* state. All of them fall into the category where a user *manually* changes the state.

Is my understanding correct? If yes, then *“in other cases”* contrasts with the former **Resolved**/**Fixed** that's handled by the Skara bot and “a few more cases” that go via **Resolved**, specifically **Delivered** and **Incomplete**.

As far as I can see, what's left aren't *“**most** other cases”* but rather *“~~most~~ other cases”*.

With the full stop, the two sentences are easier to read, in my opinion.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/169#discussion_r2770975665


More information about the guide-dev mailing list