From duke at openjdk.org  Fri Jan  9 13:25:47 2026
From: duke at openjdk.org (Roger Calnan)
Date: Fri, 9 Jan 2026 13:25:47 GMT
Subject: RFR: cover the documentation linking options in release notes [v4]
In-Reply-To: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com>
References: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com>
Message-ID: <5acY44Zi_HDx8D95Ng8wXurCYb26TqI4KQI9GGuvwbU=.46c7c056-62a4-4ce4-9034-7eb95264e408@github.com>

> added an explanation on the support of JavaDoc like links and the automatic linking of JBS IDs

Roger Calnan has updated the pull request incrementally with one additional commit since the last revision:

  additional notes

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/167/files
  - new: https://git.openjdk.org/guide/pull/167/files/c8597bd8..f2737a69

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=167&range=03
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=167&range=02-03

  Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/guide/pull/167.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/167/head:pull/167

PR: https://git.openjdk.org/guide/pull/167

From iris at openjdk.org  Mon Jan 12 17:48:23 2026
From: iris at openjdk.org (Iris Clark)
Date: Mon, 12 Jan 2026 17:48:23 GMT
Subject: RFR: cover the documentation linking options in release notes [v4]
In-Reply-To: <5acY44Zi_HDx8D95Ng8wXurCYb26TqI4KQI9GGuvwbU=.46c7c056-62a4-4ce4-9034-7eb95264e408@github.com>
References: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com>
 <5acY44Zi_HDx8D95Ng8wXurCYb26TqI4KQI9GGuvwbU=.46c7c056-62a4-4ce4-9034-7eb95264e408@github.com>
Message-ID: <f-mOuKxvH30vJ5jO1je_oURkku7LCqCtZ44NRzvbJb4=.61517d6b-73a0-4ebe-bcf2-ee0ea43791d1@github.com>

On Fri, 9 Jan 2026 13:25:47 GMT, Roger Calnan <duke at openjdk.org> wrote:

>> added an explanation on the support of JavaDoc like links and the automatic linking of JBS IDs
>
> Roger Calnan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   additional notes

Marked as reviewed by iris (Reviewer).

src/guide/release-notes.md line 86:

> 84:   * Links of the form `[NumberFormat.setStrict]`, `[NumberFormat.setStrict(boolean)]`, `[NumberFormat.setStrict(true)]`, `[ofFileChannel(FileChannel channel, long offset, long length)]` are supported with any of the separators `[.]`, `[#]` and `[::]`.
> 85:   * If a link cannot be found then the string will be rendered as if it had been enclosed in back-ticks and, in the EA release notes only, the string "(link not found)" will be added.
> 86:   * For notes of the type `rn-removed` if a link is not found then it will be looked for in the JavaDoc of the previous release family.

In the Guide's "RN Labels" section, you use "RN-Remove" as the name of the label.  Should the case match?  Also, suggest adding link to the Guides' definition of the label.

-------------

PR Review: https://git.openjdk.org/guide/pull/167#pullrequestreview-3651957577
PR Review Comment: https://git.openjdk.org/guide/pull/167#discussion_r2683270765

From jwilhelm at openjdk.org  Mon Jan 12 23:30:08 2026
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Mon, 12 Jan 2026 23:30:08 GMT
Subject: RFR: cover the documentation linking options in release notes [v4]
In-Reply-To: <eu1Hr9FksQq7z74F4bw0F3RIzeLpbuTgYeMc2ahAjCo=.48fce3f9-8304-4696-a4c0-42c3c5d9a4b6@github.com>
References: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com>
 <CJhZUyATO9HFzrbYj98XjGvOPvkPPdKnHxAFWinUljk=.3bde420e-3051-4a93-b2b6-f7664b7dc36f@github.com>
 <eu1Hr9FksQq7z74F4bw0F3RIzeLpbuTgYeMc2ahAjCo=.48fce3f9-8304-4696-a4c0-42c3c5d9a4b6@github.com>
Message-ID: <EO5_3ZlLXbTScl84CV29STWphOT0SrZRX1bcxjekrcQ=.1b3baf7d-b8bd-40f8-9339-4555b59d78cd@github.com>

On Thu, 18 Dec 2025 18:45:51 GMT, Roger Calnan <duke at openjdk.org> wrote:

>> src/guide/release-notes.md line 81:
>> 
>>> 79: 
>>> 80:   * the linking options defined in JavaDoc [MarkDown](https://openjdk.org/jeps/467#Links) are supported.
>>> 81:   * links to the JDK tools is supported. To differentiate between `[JarSigner]` the class, and `[jarsigner]` the tool, the tool reference should be in all lowercase.
>> 
>> I think it would be nice if "JDK tools" was a link to the tools page. I know it's version specific, but the JDK 25 page should be good enough for a few years :-)
>
> you mean [JDK tools] should be a link to the tools page?

Yes, in the sentence "links to the JDK tools is supported."

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/167#discussion_r2684225936

From jwilhelm at openjdk.org  Mon Jan 12 23:30:11 2026
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Mon, 12 Jan 2026 23:30:11 GMT
Subject: RFR: cover the documentation linking options in release notes [v4]
In-Reply-To: <f-mOuKxvH30vJ5jO1je_oURkku7LCqCtZ44NRzvbJb4=.61517d6b-73a0-4ebe-bcf2-ee0ea43791d1@github.com>
References: <_GdkmUGPtT-gHboZji92kZDpvuaQMMDu8DlExidSTaw=.ddb3682f-4f31-4b10-ab7e-520f8771c71a@github.com>
 <5acY44Zi_HDx8D95Ng8wXurCYb26TqI4KQI9GGuvwbU=.46c7c056-62a4-4ce4-9034-7eb95264e408@github.com>
 <f-mOuKxvH30vJ5jO1je_oURkku7LCqCtZ44NRzvbJb4=.61517d6b-73a0-4ebe-bcf2-ee0ea43791d1@github.com>
Message-ID: <H-eVJTEL_8rhH3GceYWovGZNchO6fHTLw2PlG4bnydk=.50333a79-b8f7-436f-90e1-35df5d31348c@github.com>

On Mon, 12 Jan 2026 17:44:32 GMT, Iris Clark <iris at openjdk.org> wrote:

>> Roger Calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   additional notes
>
> src/guide/release-notes.md line 86:
> 
>> 84:   * Links of the form `[NumberFormat.setStrict]`, `[NumberFormat.setStrict(boolean)]`, `[NumberFormat.setStrict(true)]`, `[ofFileChannel(FileChannel channel, long offset, long length)]` are supported with any of the separators `[.]`, `[#]` and `[::]`.
>> 85:   * If a link cannot be found then the string will be rendered as if it had been enclosed in back-ticks and, in the EA release notes only, the string "(link not found)" will be added.
>> 86:   * For notes of the type `rn-removed` if a link is not found then it will be looked for in the JavaDoc of the previous release family.
> 
> In the Guide's "RN Labels" section, you use "RN-Remove" as the name of the label.  Should the case match?  Also, suggest adding link to the Guides' definition of the label.

Good catch Iris! The case should match. Also it should be [RN-Remove]{.jbs-value}

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/167#discussion_r2684231827

From missa at openjdk.org  Wed Jan 21 23:15:40 2026
From: missa at openjdk.org (Mohamed Issa)
Date: Wed, 21 Jan 2026 23:15:40 GMT
Subject: RFR: Minor spelling correction in guide
Message-ID: <B5rEHR_RvSRjgIzWaDrYN8_IIqqoCU4CAV1JD61DLRU=.6fa64170-24de-4533-88f7-6b9f05d72792@github.com>

This changes fixes a typo in the **Reviewing and Sponsoring a Change** section of the guide.

-------------

Commit messages:
 - Correct spelling - Reviever to Reviewer

Changes: https://git.openjdk.org/guide/pull/168/files
  Webrev: https://webrevs.openjdk.org/?repo=guide&pr=168&range=00
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/168.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/168/head:pull/168

PR: https://git.openjdk.org/guide/pull/168

From jwilhelm at openjdk.org  Thu Jan 22 16:19:47 2026
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 22 Jan 2026 16:19:47 GMT
Subject: RFR: Minor spelling correction in guide
In-Reply-To: <B5rEHR_RvSRjgIzWaDrYN8_IIqqoCU4CAV1JD61DLRU=.6fa64170-24de-4533-88f7-6b9f05d72792@github.com>
References: <B5rEHR_RvSRjgIzWaDrYN8_IIqqoCU4CAV1JD61DLRU=.6fa64170-24de-4533-88f7-6b9f05d72792@github.com>
Message-ID: <tUIAbwv2wPae-aFAl3a9-tvJpMj8qvzpz1PHv80zU-M=.becc37d3-67ff-432b-bec0-bfd77bc01d0c@github.com>

On Wed, 21 Jan 2026 23:09:28 GMT, Mohamed Issa <missa at openjdk.org> wrote:

> This changes fixes a typo in the **Reviewing and Sponsoring a Change** section of the guide.

Marked as reviewed by jwilhelm (Lead).

Good catch!

-------------

PR Review: https://git.openjdk.org/guide/pull/168#pullrequestreview-3693319485
PR Comment: https://git.openjdk.org/guide/pull/168#issuecomment-3785289046

From iris at openjdk.org  Thu Jan 22 17:54:50 2026
From: iris at openjdk.org (Iris Clark)
Date: Thu, 22 Jan 2026 17:54:50 GMT
Subject: RFR: Minor spelling correction in guide
In-Reply-To: <B5rEHR_RvSRjgIzWaDrYN8_IIqqoCU4CAV1JD61DLRU=.6fa64170-24de-4533-88f7-6b9f05d72792@github.com>
References: <B5rEHR_RvSRjgIzWaDrYN8_IIqqoCU4CAV1JD61DLRU=.6fa64170-24de-4533-88f7-6b9f05d72792@github.com>
Message-ID: <8Ain9sD8zwl7WZvTtRHCnrDuyg4dUI-Aw5KSbr9vXSs=.800e928f-fb80-4d47-a8ee-6b2ff21c628a@github.com>

On Wed, 21 Jan 2026 23:09:28 GMT, Mohamed Issa <missa at openjdk.org> wrote:

> This changes fixes a typo in the **Reviewing and Sponsoring a Change** section of the guide.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/guide/pull/168#pullrequestreview-3693785166

From duke at openjdk.org  Thu Jan 22 18:23:07 2026
From: duke at openjdk.org (duke)
Date: Thu, 22 Jan 2026 18:23:07 GMT
Subject: RFR: Minor spelling correction in guide
In-Reply-To: <B5rEHR_RvSRjgIzWaDrYN8_IIqqoCU4CAV1JD61DLRU=.6fa64170-24de-4533-88f7-6b9f05d72792@github.com>
References: <B5rEHR_RvSRjgIzWaDrYN8_IIqqoCU4CAV1JD61DLRU=.6fa64170-24de-4533-88f7-6b9f05d72792@github.com>
Message-ID: <G51tvvYqpWLfXUcA2gt6p8cTn1ww3QunPd3tqAysLmU=.3f7f9c79-96e4-4a55-a4b5-ecd30947ed26@github.com>

On Wed, 21 Jan 2026 23:09:28 GMT, Mohamed Issa <missa at openjdk.org> wrote:

> This changes fixes a typo in the **Reviewing and Sponsoring a Change** section of the guide.

@missa-prime 
Your change (at version 2b5ed9176dbe734aab8c7d51f6a1f745330e7f36) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/guide/pull/168#issuecomment-3785978576