errata for Contributed-by

Mark Reinhold mr at sun.com
Thu Mar 6 10:57:15 PST 2008


> Date: Thu, 06 Mar 2008 10:18:36 -0800
> From: jonathan.gibbons at sun.com

> http://openjdk.java.net/guide/producingChangeset.html#create lists this
> example for a changeset message:
> 
> 1234567: NPE thrown on FileInputStream("")
> Summary: Rewrite precondition-checking code in io.c
> Reviewed-by: mr
> Contributed-by: Ben Bitdiddle <ben at bits.org>
> 
> In practice, it seems jcheck requires a real email address. At any
> rate, it gave me an unspecific "invalid contributor attribution" when I
> tried to follow the example.

Yes, jcheck requires a real RFC-822 e-mail address.

I suspect the address in the example got munged from <ben at bits.org>
to <ben at bits.org> when Iris removed '@' signs in order to make
spammers' lives (a little tiny bit) harder.

I'll make a note to try to beef up the jcheck diagnostic in this
case -- right now it's just a big regex.

- Mark



More information about the guide-discuss mailing list