From jesper.wilhelmsson at oracle.com Tue May 5 12:16:40 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 5 May 2020 14:16:40 +0200 Subject: JDK8: NaN JNI debug build In-Reply-To: <49c8108ee6bf46feae2fb51ec6e1d169@leidos.com> References: <49c8108ee6bf46feae2fb51ec6e1d169@leidos.com> Message-ID: <5F505C8F-9627-4894-AF34-02A2BE398242@oracle.com> Hi Darrell. The current developer's guide do have a section called "Repositories" that explains how to get the source code from our current mercurial repositories: http://openjdk.java.net/guide/repositories.html There is also a read-only copy of the JDK on Github: https://github.com/openjdk/jdk How to build is covered by the docs that come with the source code: https://github.com/openjdk/jdk/blob/master/doc/building.md /Jesper > On 9 Jul 2019, at 17:37, Reich, Darrell wrote: > > Is it possible to get the source code to java.exe runtime vm and recompile it with the ?stop on NaN? floating point option? The default is NaN & Inf and try to continue which never ends well but hides where the initial error occurred. > > What currently happens is our Intel Fortran for Windows DLLs inherit the setting from the process exe--we spend a lot of time debugging during testing rather than having it tell us where it hurts (divide by zero, etc). > > The Intel Fortran discussion forum is like ?Dear Abby? with frustrated maintenance programmers with ?Ask Dr Fortran? the moderator black belt. This is one of the FAQs. > > Developer?s Guide seems to leave out the where is the source code repo and how to compile from source specifics? I assume there is a git or svn site somewhere? > https://openjdk.java.net/guide/intro.html > > Rebuilding everything locally would be one way to do it?we?d be happy to let the build machine make a debug version of the JDK for testing JNI. Please add this suggestion to the list. > > Darrell > San Diego, California, USA > p.s. to make python run faster they recommend creating a library in Fortran and using f2py! To make gfortran faster, Intel has ported and optimized all the math libraries and claims to be 80% faster. Maybe the same can be done with the java codebase? Optimize the compiler to make the compiler and runtime work faster? -------------- next part -------------- An HTML attachment was scrubbed... URL: From martijnverburg at gmail.com Tue May 26 18:33:48 2020 From: martijnverburg at gmail.com (Martijn Verburg) Date: Tue, 26 May 2020 19:33:48 +0100 Subject: make fails on a sed call on Mac OS X Message-ID: Hi all, I just tried to build the guide and get: MININT-NSR6ILC:guide karianna$ make pandoc src/changePlanning.md --css guidestyle.css --strip-comments --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv -f UTF-8 -t ISO-8859-1 > build/changePlanning.html sed -i "" "/^ From jesper.wilhelmsson at oracle.com Tue May 26 18:50:25 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 26 May 2020 20:50:25 +0200 Subject: make fails on a sed call on Mac OS X In-Reply-To: References: Message-ID: <75A704C7-1460-4678-90CB-E964686B8ADE@oracle.com> Hi Martijn. I build on Mac (latest updates) and haven?t seen the issue. I?m not by the computer right now but can check what versions I have of sed etc later. /Jesper > 26 maj 2020 kl. 20:34 skrev Martijn Verburg : > > ? > Hi all, > > I just tried to build the guide and get: > > MININT-NSR6ILC:guide karianna$ make > pandoc src/changePlanning.md --css guidestyle.css --strip-comments --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv -f UTF-8 -t ISO-8859-1 > build/changePlanning.html > sed -i "" "/^ sed: can't read /^ make: *** [build/changePlanning.html] Error 2 > > Anyone else experience this before I start digging in? > > Cheers, > Martijn From jonathan.gibbons at oracle.com Tue May 26 19:37:46 2020 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 26 May 2020 12:37:46 -0700 Subject: make fails on a sed call on Mac OS X In-Reply-To: <75A704C7-1460-4678-90CB-E964686B8ADE@oracle.com> References: <75A704C7-1460-4678-90CB-E964686B8ADE@oracle.com> Message-ID: <3615fd0c-3cc8-da37-18aa-8bed520f7b25@oracle.com> Jesper, Martijn, This looks like the issue that for sed on Linux, the `-i` option does not take an argument, whereas for sed on Mac, the `-i` option does take an argument, which is the suffix for a backup file. This difference can cause the following options to be misinterpreted.? In this case, on Linux, the edit command will be "" and the first filename will be "/^? Hi Martijn. > > I build on Mac (latest updates) and haven?t seen the issue. > > I?m not by the computer right now but can check what versions I have of sed etc later. > /Jesper > >> 26 maj 2020 kl. 20:34 skrev Martijn Verburg : >> >> ? >> Hi all, >> >> I just tried to build the guide and get: >> >> MININT-NSR6ILC:guide karianna$ make >> pandoc src/changePlanning.md --css guidestyle.css --strip-comments --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv -f UTF-8 -t ISO-8859-1 > build/changePlanning.html >> sed -i "" "/^ > sed: can't read /^ > make: *** [build/changePlanning.html] Error 2 >> >> Anyone else experience this before I start digging in? >> >> Cheers, >> Martijn From martijnverburg at gmail.com Tue May 26 20:00:59 2020 From: martijnverburg at gmail.com (Martijn Verburg) Date: Tue, 26 May 2020 21:00:59 +0100 Subject: make fails on a sed call on Mac OS X In-Reply-To: <75A704C7-1460-4678-90CB-E964686B8ADE@oracle.com> References: <75A704C7-1460-4678-90CB-E964686B8ADE@oracle.com> Message-ID: Thanks, Jesper, For the curious I'm using GNU sed 4.8 from HomeBrew: MININT-NSR6ILC:guide karianna$ which sed /usr/local/opt/gnu-sed/libexec/gnubin/sed MININT-NSR6ILC:guide karianna$ sed --version sed (GNU sed) 4.8 Copyright (C) 2020 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later < https://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. When I swap to the default sed on Mac OS X I do not get the error Cheers, Martijn On Tue, 26 May 2020 at 19:52, Jesper Wilhelmsson < jesper.wilhelmsson at oracle.com> wrote: > Hi Martijn. > > I build on Mac (latest updates) and haven?t seen the issue. > > I?m not by the computer right now but can check what versions I have of > sed etc later. > /Jesper > > > 26 maj 2020 kl. 20:34 skrev Martijn Verburg : > > > > ? > > Hi all, > > > > I just tried to build the guide and get: > > > > MININT-NSR6ILC:guide karianna$ make > > pandoc src/changePlanning.md --css guidestyle.css --strip-comments > --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv > -f UTF-8 -t ISO-8859-1 > build/changePlanning.html > > sed -i "" "/^ > sed: can't read /^ > make: *** [build/changePlanning.html] Error 2 > > > > Anyone else experience this before I start digging in? > > > > Cheers, > > Martijn > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From jesper.wilhelmsson at oracle.com Tue May 26 20:43:11 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 26 May 2020 22:43:11 +0200 Subject: make fails on a sed call on Mac OS X In-Reply-To: References: <75A704C7-1460-4678-90CB-E964686B8ADE@oracle.com> Message-ID: <74CF775D-8889-4276-ABDC-B0172A4F1D08@oracle.com> My conclusion from Jon's answer is that we shouldn't use sed in the makefile. Would perl be a better option? I have sent a PR to replace sed with perl in the Makefile. /Jesper > On 26 May 2020, at 22:00, Martijn Verburg wrote: > > Thanks, Jesper, > > For the curious I'm using GNU sed 4.8 from HomeBrew: > > MININT-NSR6ILC:guide karianna$ which sed > /usr/local/opt/gnu-sed/libexec/gnubin/sed > > MININT-NSR6ILC:guide karianna$ sed --version > sed (GNU sed) 4.8 > Copyright (C) 2020 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later >. > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > > When I swap to the default sed on Mac OS X I do not get the error > > Cheers, > Martijn > > > On Tue, 26 May 2020 at 19:52, Jesper Wilhelmsson > wrote: > Hi Martijn. > > I build on Mac (latest updates) and haven?t seen the issue. > > I?m not by the computer right now but can check what versions I have of sed etc later. > /Jesper > > > 26 maj 2020 kl. 20:34 skrev Martijn Verburg >: > > > > ? > > Hi all, > > > > I just tried to build the guide and get: > > > > MININT-NSR6ILC:guide karianna$ make > > pandoc src/changePlanning.md --css guidestyle.css --strip-comments --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv -f UTF-8 -t ISO-8859-1 > build/changePlanning.html > > sed -i "" "/^ > sed: can't read /^ > make: *** [build/changePlanning.html] Error 2 > > > > Anyone else experience this before I start digging in? > > > > Cheers, > > Martijn > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: Message signed with OpenPGP URL: From martijnverburg at gmail.com Tue May 26 21:08:10 2020 From: martijnverburg at gmail.com (Martijn Verburg) Date: Tue, 26 May 2020 22:08:10 +0100 Subject: make fails on a sed call on Mac OS X In-Reply-To: <74CF775D-8889-4276-ABDC-B0172A4F1D08@oracle.com> References: <75A704C7-1460-4678-90CB-E964686B8ADE@oracle.com> <74CF775D-8889-4276-ABDC-B0172A4F1D08@oracle.com> Message-ID: Sounds good to me. Cheers, Martijn On Tue, 26 May 2020 at 21:43, Jesper Wilhelmsson < jesper.wilhelmsson at oracle.com> wrote: > My conclusion from Jon's answer is that we shouldn't use sed in the > makefile. Would perl be a better option? > I have sent a PR to replace sed with perl in the Makefile. > /Jesper > > On 26 May 2020, at 22:00, Martijn Verburg > wrote: > > Thanks, Jesper, > > For the curious I'm using GNU sed 4.8 from HomeBrew: > > MININT-NSR6ILC:guide karianna$ which sed > /usr/local/opt/gnu-sed/libexec/gnubin/sed > > MININT-NSR6ILC:guide karianna$ sed --version > sed (GNU sed) 4.8 > Copyright (C) 2020 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later < > https://gnu.org/licenses/gpl.html>. > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > > When I swap to the default sed on Mac OS X I do not get the error > > Cheers, > Martijn > > > On Tue, 26 May 2020 at 19:52, Jesper Wilhelmsson < > jesper.wilhelmsson at oracle.com> wrote: > >> Hi Martijn. >> >> I build on Mac (latest updates) and haven?t seen the issue. >> >> I?m not by the computer right now but can check what versions I have of >> sed etc later. >> /Jesper >> >> > 26 maj 2020 kl. 20:34 skrev Martijn Verburg : >> > >> > ? >> > Hi all, >> > >> > I just tried to build the guide and get: >> > >> > MININT-NSR6ILC:guide karianna$ make >> > pandoc src/changePlanning.md --css guidestyle.css --strip-comments >> --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv >> -f UTF-8 -t ISO-8859-1 > build/changePlanning.html >> > sed -i "" "/^ > > sed: can't read /^ > > make: *** [build/changePlanning.html] Error 2 >> > >> > Anyone else experience this before I start digging in? >> > >> > Cheers, >> > Martijn >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From martijnverburg at gmail.com Wed May 27 13:43:16 2020 From: martijnverburg at gmail.com (Martijn Verburg) Date: Wed, 27 May 2020 14:43:16 +0100 Subject: Small PR to add a .gitignore Message-ID: Hi all, I noticed the build/ directory was a generated artifact so I've raised https://github.com/openjdk/guide/pull/11 Cheers, Martijn -------------- next part -------------- An HTML attachment was scrubbed... URL: From jesper.wilhelmsson at oracle.com Wed May 27 14:40:44 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Wed, 27 May 2020 16:40:44 +0200 Subject: Small PR to add a .gitignore In-Reply-To: References: Message-ID: <358D9A15-7CD9-4E07-BAF8-D8AA5CEB19B5@oracle.com> Thanks! Looks good. The RFR thread and all other bot action around the integration will get going once your OCA is recognized by the bot. /Jesper > On 27 May 2020, at 15:43, Martijn Verburg wrote: > > Hi all, > > I noticed the build/ directory was a generated artifact so I've raised https://github.com/openjdk/guide/pull/11 > > Cheers, > Martijn -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: Message signed with OpenPGP URL: