make fails on a sed call on Mac OS X

[Martijn Verburg]

Sounds good to me.
Cheers,
Martijn


On Tue, 26 May 2020 at 21:43, Jesper Wilhelmsson <
jesper.wilhelmsson at oracle.com> wrote:

> My conclusion from Jon's answer is that we shouldn't use sed in the
> makefile.  Would perl be a better option?
> I have sent a PR to replace sed with perl in the Makefile.
> /Jesper
>
> On 26 May 2020, at 22:00, Martijn Verburg <martijnverburg at gmail.com>
> wrote:
>
> Thanks, Jesper,
>
> For the curious I'm using GNU sed 4.8 from HomeBrew:
>
> MININT-NSR6ILC:guide karianna$ which sed
> /usr/local/opt/gnu-sed/libexec/gnubin/sed
>
> MININT-NSR6ILC:guide karianna$ sed --version
> sed (GNU sed) 4.8
> Copyright (C) 2020 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <
> https://gnu.org/licenses/gpl.html>.
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
>
> When I swap to the default sed on Mac OS X I do not get the error
>
> Cheers,
> Martijn
>
>
> On Tue, 26 May 2020 at 19:52, Jesper Wilhelmsson <
> jesper.wilhelmsson at oracle.com> wrote:
>
>> Hi Martijn.
>>
>> I build on Mac (latest updates) and haven’t seen the issue.
>>
>> I’m not by the computer right now but can check what versions I have of
>> sed etc later.
>> /Jesper
>>
>> > 26 maj 2020 kl. 20:34 skrev Martijn Verburg <martijnverburg at gmail.com>:
>> >
>> > 
>> > Hi all,
>> >
>> > I just tried to build the guide and get:
>> >
>> > MININT-NSR6ILC:guide karianna$ make
>> > pandoc src/changePlanning.md --css guidestyle.css --strip-comments
>> --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv
>> -f UTF-8 -t ISO-8859-1 > build/changePlanning.html
>> > sed -i "" "/^  <meta charset=/d" build/changePlanning.html
>> > sed: can't read /^  <meta charset=/d: No such file or directory
>> > make: *** [build/changePlanning.html] Error 2
>> >
>> > Anyone else experience this before I start digging in?
>> >
>> > Cheers,
>> > Martijn
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/guide-discuss/attachments/20200526/c34cbc66/attachment.htm>