From dalibor.topic at oracle.com Wed Aug 8 05:03:30 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Wed, 08 Aug 2012 14:03:30 +0200 Subject: small patch for contact address Message-ID: <50225592.6090705@oracle.com> The attached patch updates the contact address in the two license headers to match the template in jdk sources. $ make test [snip] -- All tests passed cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From dalibor.topic at oracle.com Wed Aug 8 05:16:56 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Wed, 08 Aug 2012 14:16:56 +0200 Subject: check suggestion Message-ID: <502258B8.4060607@oracle.com> I think that it would be nice if jcheck could optionally reject changesets which contain a "PROPRIETARY/CONFIDENTIAL" string, as it may indicate code that's not suitable for inclusion in OpenJDK. Optionally, because such changesets could be suitable for other repositories. It seems like the place to add such a check would be c_02_files, right? cheers, dalibor topic -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From dalibor.topic at oracle.com Wed Aug 8 07:52:57 2012 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Wed, 08 Aug 2012 16:52:57 +0200 Subject: small patch for contact address In-Reply-To: <50225592.6090705@oracle.com> References: <50225592.6090705@oracle.com> Message-ID: <50227D49.9040607@oracle.com> On 8/8/12 2:03 PM, Dalibor Topic wrote: > The attached patch updates the contact address in the two license headers to > match the template in jdk sources. 'attached' at http://cr.openjdk.java.net/~robilad/jcheck.patch . Ahem. -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From mark.reinhold at oracle.com Wed Aug 8 08:46:09 2012 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 08 Aug 2012 15:46:09 +0000 Subject: hg: code-tools/jcheck: Updated contact address Message-ID: <20120808154610.08F564741C@hg.openjdk.java.net> Changeset: c7407e995446 Author: robilad Date: 2012-08-08 13:50 +0200 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/c7407e995446 Updated contact address ! jcheck.py ! jcheck_test.py From mark.reinhold at oracle.com Wed Aug 8 08:46:18 2012 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 08 Aug 2012 08:46:18 -0700 Subject: small patch for contact address In-Reply-To: dalibor.topic@oracle.com; Wed, 08 Aug 2012 16:52:57 +0200; <50227D49.9040607@oracle.com> Message-ID: <20120808154618.94A1E7BA@eggemoggin.niobe.net> 2012/8/8 7:52 -0700, dalibor.topic at oracle.com: > On 8/8/12 2:03 PM, Dalibor Topic wrote: >> The attached patch updates the contact address in the two license headers to >> match the template in jdk sources. > > 'attached' at http://cr.openjdk.java.net/~robilad/jcheck.patch . Ahem. Thanks! Patch applied and pushed. - Mark From mark.reinhold at oracle.com Wed Aug 8 08:51:50 2012 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 08 Aug 2012 08:51:50 -0700 Subject: check suggestion In-Reply-To: dalibor.topic@oracle.com; Wed, 08 Aug 2012 14:16:56 +0200; <502258B8.4060607@oracle.com> Message-ID: <20120808155150.A7ACA7BA@eggemoggin.niobe.net> 2012/8/8 5:16 -0700, dalibor.topic at oracle.com: > I think that it would be nice if jcheck could optionally reject changesets which > contain a "PROPRIETARY/CONFIDENTIAL" string, as it may indicate code that's not > suitable for inclusion in OpenJDK. Optionally, because such changesets could be > suitable for other repositories. > > It seems like the place to add such a check would be c_02_files, right? Yes, that'd be the right place. The check could be enabled in the .jcheck/conf file. Leaving it off by default would be the least disruptive. - Mark