From mark.reinhold at oracle.com Mon Jun 11 14:47:43 2012 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Mon, 11 Jun 2012 21:47:43 +0000 Subject: hg: code-tools/jcheck: Makefile cleanup and parameterization Message-ID: <20120611214743.E4EA947878@hg.openjdk.java.net> Changeset: 0573aed4e7cc Author: mr Date: 2012-06-11 14:47 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/0573aed4e7cc Makefile cleanup and parameterization ! Makefile From mark.reinhold at oracle.com Mon Jun 11 15:21:48 2012 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Mon, 11 Jun 2012 22:21:48 +0000 Subject: hg: code-tools/jcheck/dist: jcheck 68178a13a1df 2012-06-11 12:13:43 -0700 Message-ID: <20120611222148.8C3564787F@hg.openjdk.java.net> Changeset: 323d87c57a52 Author: mr Date: 2012-06-11 15:17 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/323d87c57a52 jcheck 68178a13a1df 2012-06-11 12:13:43 -0700 + jcheck.py From mark.reinhold at oracle.com Mon Jun 11 15:24:42 2012 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Mon, 11 Jun 2012 22:24:42 +0000 Subject: hg: code-tools/jcheck: Fix publication date/time logic Message-ID: <20120611222442.EEFB147880@hg.openjdk.java.net> Changeset: 8578b68543e5 Author: mr Date: 2012-06-11 15:19 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/8578b68543e5 Fix publication date/time logic ! Makefile From john.coomes at oracle.com Fri Jun 15 15:24:26 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 15 Jun 2012 22:24:26 +0000 Subject: hg: code-tools/jcheck: Blacklist jdk7u/jdk7u5/jdk b06f6d9a6c32 (bad fix) Message-ID: <20120615222427.0C37E4796F@hg.openjdk.java.net> Changeset: 58a6c5df1556 Author: jcoomes Date: 2012-06-15 15:14 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/58a6c5df1556 Blacklist jdk7u/jdk7u5/jdk b06f6d9a6c32 (bad fix) ! jcheck.py From john.coomes at oracle.com Fri Jun 15 15:24:32 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 15 Jun 2012 22:24:32 +0000 Subject: hg: code-tools/jcheck/dist: jcheck 58a6c5df1556 2012-06-15 15:14:41 -0700 Message-ID: <20120615222432.57A6947970@hg.openjdk.java.net> Changeset: dc96603f95be Author: jcoomes Date: 2012-06-15 15:14 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/dc96603f95be jcheck 58a6c5df1556 2012-06-15 15:14:41 -0700 ! jcheck.py From John.Coomes at oracle.com Mon Jun 18 12:10:58 2012 From: John.Coomes at oracle.com (John Coomes) Date: Mon, 18 Jun 2012 12:10:58 -0700 Subject: jcheck review request - fix dist target commit date Message-ID: <20447.32066.137136.231583@oracle.com> Simple change to the Makefile to correct a typo: http://cr.openjdk.java.net/~jcoomes/tools/jcheck/dist-commit-date -John From iris.clark at oracle.com Mon Jun 18 12:23:03 2012 From: iris.clark at oracle.com (Iris Clark) Date: Mon, 18 Jun 2012 12:23:03 -0700 (PDT) Subject: jcheck review request - fix dist target commit date In-Reply-To: <20447.32066.137136.231583@oracle.com> References: <20447.32066.137136.231583@oracle.com> Message-ID: <8fb126d7-8359-48c9-be9c-d586af023678@default> Hi, John. Looks good to me. iris -----Original Message----- From: John Coomes Sent: Monday, June 18, 2012 12:11 PM To: hg-tools-dev at openjdk.java.net Subject: jcheck review request - fix dist target commit date Simple change to the Makefile to correct a typo: http://cr.openjdk.java.net/~jcoomes/tools/jcheck/dist-commit-date -John From mark.reinhold at oracle.com Mon Jun 18 12:30:49 2012 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Mon, 18 Jun 2012 12:30:49 -0700 Subject: jcheck review request - fix dist target commit date In-Reply-To: john.coomes@oracle.com; Mon, 18 Jun 2012 12:10:58 PDT; <20447.32066.137136.231583@oracle.com> Message-ID: <20120618193049.A0DB89DB@eggemoggin.niobe.net> 2012/6/18 12:10 -0700, john.coomes at oracle.com: > Simple change to the Makefile to correct a typo: > > http://cr.openjdk.java.net/~jcoomes/tools/jcheck/dist-commit-date Oops -- good catch. - Mark From John.Coomes at oracle.com Mon Jun 18 17:32:16 2012 From: John.Coomes at oracle.com (John Coomes) Date: Mon, 18 Jun 2012 17:32:16 -0700 Subject: jcheck review request - fix dist target commit date In-Reply-To: <20120618193049.A0DB89DB@eggemoggin.niobe.net> References: <20447.32066.137136.231583@oracle.com> <20120618193049.A0DB89DB@eggemoggin.niobe.net> Message-ID: <20447.51344.155717.561022@oracle.com> mark.reinhold at oracle.com (mark.reinhold at oracle.com) wrote: > 2012/6/18 12:10 -0700, john.coomes at oracle.com: > > Simple change to the Makefile to correct a typo: > > > > http://cr.openjdk.java.net/~jcoomes/tools/jcheck/dist-commit-date > > Oops -- good catch. Thanks Mark and Iris. -John From john.coomes at oracle.com Mon Jun 18 17:40:18 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 19 Jun 2012 00:40:18 +0000 Subject: hg: code-tools/jcheck: Fix dist target commit date Message-ID: <20120619004018.B0076479D3@hg.openjdk.java.net> Changeset: 5f292bb1e354 Author: jcoomes Date: 2012-06-15 21:15 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/5f292bb1e354 Fix dist target commit date ! Makefile From mike.duigou at oracle.com Fri Jun 29 16:02:56 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Fri, 29 Jun 2012 16:02:56 -0700 Subject: JCheck issue: Handling of capitals in email addresses Message-ID: <76E144ED-63E8-453D-BD4D-806C0DF9C7A3@oracle.com> A committer was having trouble pushing a fix with the following contributed by line: Contributed-by: zhouyx at linux.vnet.ibm.com, Ulf.Zibis at gmx.de, david.holmes at oracle.com The problem is that "Ulf.Zibis" is capitalized which current JCheck fails to correctly recognize as a valid (though unusual) email address. Per RFC 2821: > The local-part of a mailbox MUST BE treated as case sensitive. Therefore, SMTP implementations MUST take care to preserve the case of mailbox local-parts. Mailbox domains are not case sensitive. In particular, for some hosts the user "smith" is different from the user "Smith". However, exploiting the case sensitivity of mailbox local-parts impedes interoperability and is discouraged. Changing from: base_addr_pat = "[a-z0-9._%+-]+@[a-z0-9.-]+\.[a-z]{2,4}" to: base_addr_pat = "[a-zA-Z0-9._%+-]+@[a-z0-9.-]+\.[a-z]{2,4}" corrected the problem. Mike