From mark.reinhold at oracle.com Fri Nov 9 12:32:15 2012 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Fri, 09 Nov 2012 20:32:15 +0000 Subject: hg: code-tools/jcheck: Blacklist changesets with INTJDK bug numbers Message-ID: <20121109203215.6D2E9478B7@hg.openjdk.java.net> Changeset: d5969b9b580e Author: mr Date: 2012-11-09 12:29 -0800 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/d5969b9b580e Blacklist changesets with INTJDK bug numbers ! jcheck.py From mark.reinhold at oracle.com Fri Nov 9 12:32:44 2012 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Fri, 09 Nov 2012 20:32:44 +0000 Subject: hg: code-tools/jcheck/dist: jcheck d5969b9b580e 2012-11-09 12:29:26 -0800 Message-ID: <20121109203244.3CE64478B8@hg.openjdk.java.net> Changeset: 50ee4a31d689 Author: mr Date: 2012-11-09 12:29 -0800 URL: http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/50ee4a31d689 jcheck d5969b9b580e 2012-11-09 12:29:26 -0800 ! jcheck.py From John.Coomes at oracle.com Wed Nov 28 15:54:32 2012 From: John.Coomes at oracle.com (John Coomes) Date: Wed, 28 Nov 2012 15:54:32 -0800 Subject: jcheck review request - blacklist updates Message-ID: <20662.42040.323776.395143@oracle.com> Please review a simple change to add some cset hashes to the blacklist. http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20121128/ -John From weijun.wang at oracle.com Wed Nov 28 16:21:34 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 29 Nov 2012 08:21:34 +0800 Subject: jcheck review request - blacklist updates In-Reply-To: <20662.42040.323776.395143@oracle.com> References: <20662.42040.323776.395143@oracle.com> Message-ID: <50B6AA8E.2000009@oracle.com> I'm not quite comfortable with: - '9eb97a2b3274edff83a362f76bbadb866a97a89b' + '9eb97a2b3274edff83a362f76bbadb866a97a89b', In Java, a comma after the last array element is allowable. Hopefully you can also do this in python. Thanks Max On 11/29/2012 07:54 AM, John Coomes wrote: > Please review a simple change to add some cset hashes to the > blacklist. > > http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20121128/ > > -John > From iris.clark at oracle.com Wed Nov 28 16:44:22 2012 From: iris.clark at oracle.com (Iris Clark) Date: Wed, 28 Nov 2012 16:44:22 -0800 (PST) Subject: jcheck review request - blacklist updates In-Reply-To: <20662.42040.323776.395143@oracle.com> References: <20662.42040.323776.395143@oracle.com> Message-ID: <466eb777-fd05-48a8-9e3e-dc4236924dea@default> Looks reasonable to me. iris -----Original Message----- From: John Coomes Sent: Wednesday, November 28, 2012 3:55 PM To: hg-tools-dev at openjdk.java.net Subject: jcheck review request - blacklist updates Please review a simple change to add some cset hashes to the blacklist. http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20121128/ -John From John.Coomes at oracle.com Wed Nov 28 18:06:51 2012 From: John.Coomes at oracle.com (John Coomes) Date: Wed, 28 Nov 2012 18:06:51 -0800 Subject: jcheck review request - blacklist updates In-Reply-To: <50B6AA8E.2000009@oracle.com> References: <20662.42040.323776.395143@oracle.com> <50B6AA8E.2000009@oracle.com> Message-ID: <20662.49979.243791.979737@oracle.com> Weijun Wang (weijun.wang at oracle.com) wrote: > I'm not quite comfortable with: > > - '9eb97a2b3274edff83a362f76bbadb866a97a89b' > + '9eb97a2b3274edff83a362f76bbadb866a97a89b', Thanks for looking. The above is only the first bit of the diff hunk; the whole thing is: - '9eb97a2b3274edff83a362f76bbadb866a97a89b' + '9eb97a2b3274edff83a362f76bbadb866a97a89b', + # jdk7u11-dev/jaxp bad fix for 7192390 + '1642814c94fd0206f8b4f460cc77fa6fc099731a', + # jdk7u11-dev/jdk bad fix for 7192390 + '90eb0407ca69dc572d20490f17239b183bb616b6', + # jdk7u11-dev/jdk/test/closed bad fix for 7192390 + '512af24c6909ef2c766c3a5217c719545de68bf7', + # jdk7u11-dev/jdk redone rmi fix + 'fd6ce0200a7f519380e6863930e92f9182030fa0', + # jdk7u11-dev/jdk/test/closed redone rmi fix + '770d9cf0e1dc97f7aaa3fdfbb430b27a40b1a3a9' ] There's no trailing comma. > In Java, a comma after the last array element is allowable. Hopefully > you can also do this in python. python doesn't allow it. -John > On 11/29/2012 07:54 AM, John Coomes wrote: > > Please review a simple change to add some cset hashes to the > > blacklist. > > > > http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20121128/ > > > > -John > > From John.Coomes at oracle.com Wed Nov 28 18:07:13 2012 From: John.Coomes at oracle.com (John Coomes) Date: Wed, 28 Nov 2012 18:07:13 -0800 Subject: jcheck review request - blacklist updates In-Reply-To: <466eb777-fd05-48a8-9e3e-dc4236924dea@default> References: <20662.42040.323776.395143@oracle.com> <466eb777-fd05-48a8-9e3e-dc4236924dea@default> Message-ID: <20662.50001.419173.453093@oracle.com> Iris Clark (iris.clark at oracle.com) wrote: > Looks reasonable to me. Thanks Iris. -John > -----Original Message----- > From: John Coomes > Sent: Wednesday, November 28, 2012 3:55 PM > To: hg-tools-dev at openjdk.java.net > Subject: jcheck review request - blacklist updates > > Please review a simple change to add some cset hashes to the blacklist. > > http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20121128/ > > -John From weijun.wang at oracle.com Wed Nov 28 18:21:27 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 29 Nov 2012 10:21:27 +0800 Subject: jcheck review request - blacklist updates In-Reply-To: <20662.49979.243791.979737@oracle.com> References: <20662.42040.323776.395143@oracle.com> <50B6AA8E.2000009@oracle.com> <20662.49979.243791.979737@oracle.com> Message-ID: <50B6C6A7.70104@oracle.com> On 11/29/2012 10:06 AM, John Coomes wrote: > Weijun Wang (weijun.wang at oracle.com) wrote: >> I'm not quite comfortable with: >> >> - '9eb97a2b3274edff83a362f76bbadb866a97a89b' >> + '9eb97a2b3274edff83a362f76bbadb866a97a89b', > > Thanks for looking. The above is only the first bit of the diff hunk; > the whole thing is: > > - '9eb97a2b3274edff83a362f76bbadb866a97a89b' > + '9eb97a2b3274edff83a362f76bbadb866a97a89b', > + # jdk7u11-dev/jaxp bad fix for 7192390 > + '1642814c94fd0206f8b4f460cc77fa6fc099731a', > + # jdk7u11-dev/jdk bad fix for 7192390 > + '90eb0407ca69dc572d20490f17239b183bb616b6', > + # jdk7u11-dev/jdk/test/closed bad fix for 7192390 > + '512af24c6909ef2c766c3a5217c719545de68bf7', > + # jdk7u11-dev/jdk redone rmi fix > + 'fd6ce0200a7f519380e6863930e92f9182030fa0', > + # jdk7u11-dev/jdk/test/closed redone rmi fix > + '770d9cf0e1dc97f7aaa3fdfbb430b27a40b1a3a9' > ] > > There's no trailing comma. > >> In Java, a comma after the last array element is allowable. Hopefully >> you can also do this in python. > > python doesn't allow it. Maybe my python is too new? $ python --version Python 2.7.3 $ python -c 'print [1,2,3]' [1, 2, 3] $ python -c 'print [1,2,3,]' [1, 2, 3] If we were able to add a trailing comma, then any future diff would only include the real new lines. -Max > > -John > >> On 11/29/2012 07:54 AM, John Coomes wrote: >>> Please review a simple change to add some cset hashes to the >>> blacklist. >>> >>> http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20121128/ >>> >>> -John >>> From John.Coomes at oracle.com Thu Nov 29 09:57:40 2012 From: John.Coomes at oracle.com (John Coomes) Date: Thu, 29 Nov 2012 09:57:40 -0800 Subject: jcheck review request - blacklist updates In-Reply-To: <50B6C6A7.70104@oracle.com> References: <20662.42040.323776.395143@oracle.com> <50B6AA8E.2000009@oracle.com> <20662.49979.243791.979737@oracle.com> <50B6C6A7.70104@oracle.com> Message-ID: <20663.41492.85222.449996@oracle.com> Weijun Wang (weijun.wang at oracle.com) wrote: > > On 11/29/2012 10:06 AM, John Coomes wrote: > > Weijun Wang (weijun.wang at oracle.com) wrote: > >> I'm not quite comfortable with: > >> > >> - '9eb97a2b3274edff83a362f76bbadb866a97a89b' > >> + '9eb97a2b3274edff83a362f76bbadb866a97a89b', > > > > Thanks for looking. The above is only the first bit of the diff hunk; > > the whole thing is: > > > > - '9eb97a2b3274edff83a362f76bbadb866a97a89b' > > + '9eb97a2b3274edff83a362f76bbadb866a97a89b', > > ... > > + '770d9cf0e1dc97f7aaa3fdfbb430b27a40b1a3a9' > > ] > > > > There's no trailing comma. > > > >> In Java, a comma after the last array element is allowable. Hopefully > >> you can also do this in python. > > > > python doesn't allow it. > > Maybe my python is too new? > > $ python --version > Python 2.7.3 > $ python -c 'print [1,2,3]' > [1, 2, 3] > $ python -c 'print [1,2,3,]' > [1, 2, 3] I was wrong; it's allowed. Yesterday I tried a quick experiment and it was rejected; apparently I tried the wrong thing. > If we were able to add a trailing comma, then any future diff would only > include the real new lines. Now I understand your original comment. I'll add the trailing comma. -John > >> On 11/29/2012 07:54 AM, John Coomes wrote: > >>> Please review a simple change to add some cset hashes to the > >>> blacklist. > >>> > >>> http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20121128/ > >>> > >>> -John > >>> From john.coomes at oracle.com Thu Nov 29 10:18:40 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 29 Nov 2012 18:18:40 +0000 Subject: hg: code-tools/jcheck: Blacklist bad fix for 7192390 and related csets Message-ID: <20121129181840.C06D647BE0@hg.openjdk.java.net> Changeset: 5dcea98b4350 Author: jcoomes Date: 2012-11-29 10:11 -0800 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/5dcea98b4350 Blacklist bad fix for 7192390 and related csets ! jcheck.py From john.coomes at oracle.com Thu Nov 29 10:18:44 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 29 Nov 2012 18:18:44 +0000 Subject: hg: code-tools/jcheck/dist: jcheck 5dcea98b4350 2012-11-29 10:11:59 -0800 Message-ID: <20121129181844.685AC47BE1@hg.openjdk.java.net> Changeset: 84fd2e86c4c9 Author: jcoomes Date: 2012-11-29 10:11 -0800 URL: http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/84fd2e86c4c9 jcheck 5dcea98b4350 2012-11-29 10:11:59 -0800 ! jcheck.py