jcheck review request - blacklist updates

John Coomes John.Coomes at oracle.com
Wed Nov 28 18:06:51 PST 2012


Weijun Wang (weijun.wang at oracle.com) wrote:
> I'm not quite comfortable with:
> 
> -    '9eb97a2b3274edff83a362f76bbadb866a97a89b'
> +    '9eb97a2b3274edff83a362f76bbadb866a97a89b',

Thanks for looking.  The above is only the first bit of the diff hunk;
the whole thing is:

-    '9eb97a2b3274edff83a362f76bbadb866a97a89b'
+    '9eb97a2b3274edff83a362f76bbadb866a97a89b',
+    # jdk7u11-dev/jaxp bad fix for 7192390
+    '1642814c94fd0206f8b4f460cc77fa6fc099731a',
+    # jdk7u11-dev/jdk bad fix for 7192390
+    '90eb0407ca69dc572d20490f17239b183bb616b6',
+    # jdk7u11-dev/jdk/test/closed bad fix for 7192390
+    '512af24c6909ef2c766c3a5217c719545de68bf7',
+    # jdk7u11-dev/jdk redone rmi fix
+    'fd6ce0200a7f519380e6863930e92f9182030fa0',
+    # jdk7u11-dev/jdk/test/closed redone rmi fix
+    '770d9cf0e1dc97f7aaa3fdfbb430b27a40b1a3a9'
     ]

There's no trailing comma.

> In Java, a comma after the last array element is allowable. Hopefully 
> you can also do this in python.

python doesn't allow it.

-John

> On 11/29/2012 07:54 AM, John Coomes wrote:
> > Please review a simple change to add some cset hashes to the
> > blacklist.
> >
> > http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20121128/
> >
> > -John
> >


More information about the hg-tools-dev mailing list