jcheck review request - blacklist updates

[John Coomes]

Weijun Wang (weijun.wang at oracle.com) wrote:
> 
> On 11/29/2012 10:06 AM, John Coomes wrote:
> > Weijun Wang (weijun.wang at oracle.com) wrote:
> >> I'm not quite comfortable with:
> >>
> >> -    '9eb97a2b3274edff83a362f76bbadb866a97a89b'
> >> +    '9eb97a2b3274edff83a362f76bbadb866a97a89b',
> >
> > Thanks for looking.  The above is only the first bit of the diff hunk;
> > the whole thing is:
> >
> > -    '9eb97a2b3274edff83a362f76bbadb866a97a89b'
> > +    '9eb97a2b3274edff83a362f76bbadb866a97a89b',
> > ...
> > +    '770d9cf0e1dc97f7aaa3fdfbb430b27a40b1a3a9'
> >       ]
> >
> > There's no trailing comma.
> >
> >> In Java, a comma after the last array element is allowable. Hopefully
> >> you can also do this in python.
> >
> > python doesn't allow it.
> 
> Maybe my python is too new?
> 
> $ python --version
> Python 2.7.3
> $ python -c 'print [1,2,3]'
> [1, 2, 3]
> $ python -c 'print [1,2,3,]'
> [1, 2, 3]

I was wrong; it's allowed.  Yesterday I tried a quick experiment and
it was rejected; apparently I tried the wrong thing.

> If we were able to add a trailing comma, then any future diff would only 
> include the real new lines.

Now I understand your original comment.  I'll add the trailing comma.

-John

> >> On 11/29/2012 07:54 AM, John Coomes wrote:
> >>> Please review a simple change to add some cset hashes to the
> >>> blacklist.
> >>>
> >>> http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20121128/
> >>>
> >>> -John
> >>>