[PATCH] jcheck: allow bug id line to be ignored

[Omair Majid]

Hi Mark,

On 04/08/2013 06:19 PM, mark.reinhold at oracle.com wrote:
> Please add a case or two to the unit tests to cover this new option.
> The tests for configuration options are at the end of runtests.sh.

Thanks for pointing me to the right place to add tests. I had two
questions about tests in jcheck that I couldn't find answers to:

1. What's the difference between 'make test' and 'make tests'? Should I
be running both all the time or prefer one over the other?

2. Looking at runtests.sh, some tests set up jcheck:

259 hg add -R z z/.jcheck/conf
260 cat >z/.hg/hgrc <<___
261 [extensions]
262 jcheck = $(pwd)/jcheck.py
263 [hooks]
264 pretxncommit.jcheck=python:jcheck.hook
265 ___

While others dont:

208 # Lax bugids
209 echo "-- $r lax bug ids"
210 rm -rf z
211 hg init z
212 mkdir z/.jcheck
213 cat >z/.jcheck/conf <<___
214 project=jdk7
215 comments=lax
216 bugids=lax
217 ___
218 hg add -R z z/.jcheck/conf
219
220 if HGUSER=$setup_author hg ci -R z -m '1234: Silly bugid'; then
true; else fail; fi
221 r=$(expr $r + 1)

Is it expected that jcheck will be hooked into the global ~/.hgrc file?
(Is that a good expectation for unit tests?)

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681