From weijun.wang at oracle.com Wed Jun 19 07:53:27 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 19 Jun 2013 22:53:27 +0800 Subject: Attributions (was Re: Final RFR 4837946: Faster multiplication and exponentiation of large integers) In-Reply-To: <51C1AB02.7060209@oracle.com> References: <418FEE3B-9DFF-43E0-ADCB-916D40BAA06A@oracle.com> <51C1AB02.7060209@oracle.com> Message-ID: <51C1C5E7.9090605@oracle.com> On 6/19/2013 8:58 PM, Alan Bateman wrote: > > One question on the attribution (so that we have it right). In the > Contributed-by line then you have Alan Eliasen listed but the @author > tags have been extended to list Tim Buktu in addition to Alan. Is the > patch from both Alan and Tim? I ask because I don't see Tim on the OCA > list. Is it possible for jcheck to check non- at oracle.com Contributed-by names against OCA? Thanks Max > > -Alan > From mark.reinhold at oracle.com Mon Jun 24 14:06:10 2013 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Mon, 24 Jun 2013 14:06:10 -0700 Subject: RFR (XS): jcheck: Enforce lower-case author names Message-ID: <20130624140610.204764@eggemoggin.niobe.net> It turns out that jcheck never enforced lower-case author names, and the db.ojn server incorrectly accepts mixed-case names. I'll fix that on the server, but it makes sense to enforce it locally as well in jcheck. I ran this revised jcheck over the current JDK 8 and JDK 7 Updates forests, found two changesets with capital letters in the author name, and added the hashes of those changesets to the whitelist in the patch below. Thanks, - Mark diff --git a/jcheck.py b/jcheck.py --- a/jcheck.py +++ b/jcheck.py @@ -100,8 +100,11 @@ # Author validation author_cache = { } ## Should really cache more permanently +author_re = re.compile("[a-z]+") def validate_author(an, pn): + if not author_re.match(an): + return False if author_cache.has_key(an): return True u = ("http://db.openjdk.java.net/people/%s/projects/%s" @@ -252,7 +255,9 @@ 'd77434402021cebc4c25b452db18bbfd2d7ccda1', # jdk6/jdk6/jdk bad comment '931e5f39e365a0d550d79148ff87a7f9e864d2e1', # hotspot dup bug id 7147064 'd8abc90163a4b58db407a60cba331ab21c9977e7', # hotspot dup bug id 7147064 - '45849c62c298aa8426c9e67599e4e35793d8db13' # pubs executable files + '45849c62c298aa8426c9e67599e4e35793d8db13', # pubs executable files + '9b5c596a2920af10bde905d5fdece110204ebdaa', # all-caps author name + '1785f8335f4dd2a6a2c47e348bb588c9e7fcd374' # all-caps author name ] # Bad changesets that should never be allowed in diff --git a/runtests.sh b/runtests.sh --- a/runtests.sh +++ b/runtests.sh @@ -332,6 +332,13 @@ if [ $? -eq 0 ]; then fail; fi r=$(expr $r + 1) +echo "-- $r lower-case author names" +touch z/foo2 +hg add -R z z/foo2 +if $HG ci -R z -u Robilad -m '1111112: Foo! +Reviewed-by: duke' -d '0 0'; then fail; fi +r=$(expr $r + 1) + # Summary if [ $failures -gt 0 ]; then From John.Coomes at oracle.com Thu Jun 27 13:28:17 2013 From: John.Coomes at oracle.com (John Coomes) Date: Thu, 27 Jun 2013 13:28:17 -0700 Subject: jcheck review request (xs) - blacklist update Message-ID: <20940.41057.468123.400509@oracle.com> A minor addition to the jcheck blacklist: http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20130627/ -John From iris.clark at oracle.com Thu Jun 27 14:13:07 2013 From: iris.clark at oracle.com (Iris Clark) Date: Thu, 27 Jun 2013 14:13:07 -0700 (PDT) Subject: jcheck review request (xs) - blacklist update In-Reply-To: <20940.41057.468123.400509@oracle.com> References: <20940.41057.468123.400509@oracle.com> Message-ID: <48a68ef2-8f0d-4386-98d7-b33ba782f144@default> Looks fine to me. Thanks, iris -----Original Message----- From: John Coomes Sent: Thursday, June 27, 2013 1:28 PM To: hg-tools-dev at openjdk.java.net Subject: jcheck review request (xs) - blacklist update A minor addition to the jcheck blacklist: http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20130627/ -John From John.Coomes at oracle.com Thu Jun 27 15:57:59 2013 From: John.Coomes at oracle.com (John Coomes) Date: Thu, 27 Jun 2013 15:57:59 -0700 Subject: jcheck review request (xs) - blacklist update In-Reply-To: <48a68ef2-8f0d-4386-98d7-b33ba782f144@default> References: <20940.41057.468123.400509@oracle.com> <48a68ef2-8f0d-4386-98d7-b33ba782f144@default> Message-ID: <20940.50039.119297.299386@oracle.com> Iris Clark (iris.clark at oracle.com) wrote: > Looks fine to me. Thanks! -John > -----Original Message----- > From: John Coomes > Sent: Thursday, June 27, 2013 1:28 PM > To: hg-tools-dev at openjdk.java.net > Subject: jcheck review request (xs) - blacklist update > > A minor addition to the jcheck blacklist: > > http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20130627/ > > -John From john.coomes at oracle.com Thu Jun 27 16:09:27 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 27 Jun 2013 23:09:27 +0000 Subject: hg: code-tools/jcheck/dist: jcheck 7e5310b8201f 2013-06-27 12:13:29 -0700 Message-ID: <20130627230927.E41F8485EB@hg.openjdk.java.net> Changeset: c82b052254c2 Author: jcoomes Date: 2013-06-27 12:13 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/c82b052254c2 jcheck 7e5310b8201f 2013-06-27 12:13:29 -0700 ! jcheck.py From john.coomes at oracle.com Thu Jun 27 16:09:24 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 27 Jun 2013 23:09:24 +0000 Subject: hg: code-tools/jcheck: Blacklist mistaken pushes to jdk7u40 Message-ID: <20130627230924.7451C485E9@hg.openjdk.java.net> Changeset: 7e5310b8201f Author: jcoomes Date: 2013-06-27 12:13 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/7e5310b8201f Blacklist mistaken pushes to jdk7u40 ! jcheck.py From iris.clark at oracle.com Fri Jun 28 13:04:00 2013 From: iris.clark at oracle.com (Iris Clark) Date: Fri, 28 Jun 2013 13:04:00 -0700 (PDT) Subject: RFR (XS): jcheck: Enforce lower-case author names In-Reply-To: <20130624140610.204764@eggemoggin.niobe.net> References: <20130624140610.204764@eggemoggin.niobe.net> Message-ID: <1a98a294-5d4c-4328-b142-d11d574e9948@default> Hi, Mark. Looks like I forgot to reply. I think this looks fine. iris -----Original Message----- From: Mark Reinhold Sent: Monday, June 24, 2013 2:06 PM To: hg-tools-dev at openjdk.java.net Subject: RFR (XS): jcheck: Enforce lower-case author names It turns out that jcheck never enforced lower-case author names, and the db.ojn server incorrectly accepts mixed-case names. I'll fix that on the server, but it makes sense to enforce it locally as well in jcheck. I ran this revised jcheck over the current JDK 8 and JDK 7 Updates forests, found two changesets with capital letters in the author name, and added the hashes of those changesets to the whitelist in the patch below. Thanks, - Mark diff --git a/jcheck.py b/jcheck.py --- a/jcheck.py +++ b/jcheck.py @@ -100,8 +100,11 @@ # Author validation author_cache = { } ## Should really cache more permanently +author_re = re.compile("[a-z]+") def validate_author(an, pn): + if not author_re.match(an): + return False if author_cache.has_key(an): return True u = ("http://db.openjdk.java.net/people/%s/projects/%s" @@ -252,7 +255,9 @@ 'd77434402021cebc4c25b452db18bbfd2d7ccda1', # jdk6/jdk6/jdk bad comment '931e5f39e365a0d550d79148ff87a7f9e864d2e1', # hotspot dup bug id 7147064 'd8abc90163a4b58db407a60cba331ab21c9977e7', # hotspot dup bug id 7147064 - '45849c62c298aa8426c9e67599e4e35793d8db13' # pubs executable files + '45849c62c298aa8426c9e67599e4e35793d8db13', # pubs executable files + '9b5c596a2920af10bde905d5fdece110204ebdaa', # all-caps author name + '1785f8335f4dd2a6a2c47e348bb588c9e7fcd374' # all-caps author name ] # Bad changesets that should never be allowed in diff --git a/runtests.sh b/runtests.sh --- a/runtests.sh +++ b/runtests.sh @@ -332,6 +332,13 @@ if [ $? -eq 0 ]; then fail; fi r=$(expr $r + 1) +echo "-- $r lower-case author names" +touch z/foo2 +hg add -R z z/foo2 +if $HG ci -R z -u Robilad -m '1111112: Foo! +Reviewed-by: duke' -d '0 0'; then fail; fi r=$(expr $r + 1) + # Summary if [ $failures -gt 0 ]; then From weijun.wang at oracle.com Sat Jun 29 01:59:15 2013 From: weijun.wang at oracle.com (Wang Weijun) Date: Sat, 29 Jun 2013 16:59:15 +0800 Subject: RFR (XS): jcheck: Enforce lower-case author names In-Reply-To: <1a98a294-5d4c-4328-b142-d11d574e9948@default> References: <20130624140610.204764@eggemoggin.niobe.net> <1a98a294-5d4c-4328-b142-d11d574e9948@default> Message-ID: <1BB852A0-8AFD-4D4E-AA41-CD8A8F41A342@oracle.com> Does this mean no digit is allowed in openjdk author names? --Max ?? Jun 29, 2013??4:04 AM??Iris Clark ?????? > Hi, Mark. > > Looks like I forgot to reply. > > I think this looks fine. > > iris > > -----Original Message----- > From: Mark Reinhold > Sent: Monday, June 24, 2013 2:06 PM > To: hg-tools-dev at openjdk.java.net > Subject: RFR (XS): jcheck: Enforce lower-case author names > > It turns out that jcheck never enforced lower-case author names, and the db.ojn server incorrectly accepts mixed-case names. I'll fix that on the server, but it makes sense to enforce it locally as well in jcheck. > > I ran this revised jcheck over the current JDK 8 and JDK 7 Updates forests, found two changesets with capital letters in the author name, and added the hashes of those changesets to the whitelist in the patch below. > > Thanks, > - Mark > > > diff --git a/jcheck.py b/jcheck.py > --- a/jcheck.py > +++ b/jcheck.py > @@ -100,8 +100,11 @@ > # Author validation > > author_cache = { } ## Should really cache more permanently > +author_re = re.compile("[a-z]+") > > def validate_author(an, pn): > + if not author_re.match(an): > + return False > if author_cache.has_key(an): > return True > u = ("http://db.openjdk.java.net/people/%s/projects/%s" > @@ -252,7 +255,9 @@ > 'd77434402021cebc4c25b452db18bbfd2d7ccda1', # jdk6/jdk6/jdk bad comment > '931e5f39e365a0d550d79148ff87a7f9e864d2e1', # hotspot dup bug id 7147064 > 'd8abc90163a4b58db407a60cba331ab21c9977e7', # hotspot dup bug id 7147064 > - '45849c62c298aa8426c9e67599e4e35793d8db13' # pubs executable files > + '45849c62c298aa8426c9e67599e4e35793d8db13', # pubs executable files > + '9b5c596a2920af10bde905d5fdece110204ebdaa', # all-caps author name > + '1785f8335f4dd2a6a2c47e348bb588c9e7fcd374' # all-caps author name > ] > > # Bad changesets that should never be allowed in diff --git a/runtests.sh b/runtests.sh > --- a/runtests.sh > +++ b/runtests.sh > @@ -332,6 +332,13 @@ > if [ $? -eq 0 ]; then fail; fi > r=$(expr $r + 1) > > +echo "-- $r lower-case author names" > +touch z/foo2 > +hg add -R z z/foo2 > +if $HG ci -R z -u Robilad -m '1111112: Foo! > +Reviewed-by: duke' -d '0 0'; then fail; fi r=$(expr $r + 1) > + > # Summary > > if [ $failures -gt 0 ]; then