From John.Coomes at oracle.com  Fri Mar 15 14:40:33 2013
From: John.Coomes at oracle.com (John Coomes)
Date: Fri, 15 Mar 2013 14:40:33 -0700
Subject: jcheck review request (xs) - blacklist update 20130315
Message-ID: <20803.38225.51886.33277@oracle.com>

Please review a minor addition to the jcheck blacklist:

http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20130315/

-John

From mark.reinhold at oracle.com  Fri Mar 15 15:05:02 2013
From: mark.reinhold at oracle.com (mark.reinhold at oracle.com)
Date: Fri, 15 Mar 2013 15:05:02 -0700
Subject: jcheck review request (xs) - blacklist update 20130315
In-Reply-To: <20803.38225.51886.33277@oracle.com>
References: <20803.38225.51886.33277@oracle.com>
Message-ID: <20130315150502.410003@eggemoggin.niobe.net>

2013/3/15 7:40 -0700, john.coomes at oracle.com:
> Please review a minor addition to the jcheck blacklist:
> 
> http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20130315/

Looks good.

- Mark

From john.coomes at oracle.com  Fri Mar 15 15:43:10 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 15 Mar 2013 22:43:10 +0000
Subject: hg: code-tools/jcheck/dist: jcheck 22c10600b6e9 2013-03-15 12:53:48
	-0700
Message-ID: <20130315224310.3D1A4481A9@hg.openjdk.java.net>

Changeset: 3c7d5a83a15a
Author:    jcoomes
Date:      2013-03-15 12:53 -0700
URL:       http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/3c7d5a83a15a

jcheck 22c10600b6e9 2013-03-15 12:53:48 -0700

! jcheck.py


From john.coomes at oracle.com  Fri Mar 15 15:43:06 2013
From: john.coomes at oracle.com (john.coomes at oracle.com)
Date: Fri, 15 Mar 2013 22:43:06 +0000
Subject: hg: code-tools/jcheck: Blacklist hsx/hotspot-emb/hotspot 29ab68ef5bb6
	(wrong bugid)
Message-ID: <20130315224306.10F47481A8@hg.openjdk.java.net>

Changeset: 22c10600b6e9
Author:    jcoomes
Date:      2013-03-15 12:53 -0700
URL:       http://hg.openjdk.java.net/code-tools/jcheck/rev/22c10600b6e9

Blacklist hsx/hotspot-emb/hotspot 29ab68ef5bb6 (wrong bugid)

! jcheck.py


From omajid at redhat.com  Thu Mar 21 11:54:57 2013
From: omajid at redhat.com (Omair Majid)
Date: Thu, 21 Mar 2013 14:54:57 -0400
Subject: [PATCH] jcheck: bug ids are strings, but validate as numbers
Message-ID: <514B5781.8080408@redhat.com>

Hi,

The attached patch makes jcheck treat bug ids as strings. Bug ids in new
commits are still validated to be integers, but the existing bug ids in
the repo are not.

This patch is needed for my next patch, but stands alone.

Thanks,
Omair
-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681

From omajid at redhat.com  Thu Mar 21 12:02:02 2013
From: omajid at redhat.com (Omair Majid)
Date: Thu, 21 Mar 2013 15:02:02 -0400
Subject: [PATCH] jcheck: bug ids are strings, but validate as numbers
In-Reply-To: <514B5781.8080408@redhat.com>
References: <514B5781.8080408@redhat.com>
Message-ID: <514B592A.9040209@redhat.com>

On 03/21/2013 02:54 PM, Omair Majid wrote:
> Hi,
> 
> The attached patch makes jcheck treat bug ids as strings. Bug ids in new
> commits are still validated to be integers, but the existing bug ids in
> the repo are not.
> 
> This patch is needed for my next patch, but stands alone.
> 

Looks like the mailing list removes attachments. Here's a webrev:

http://cr.openjdk.java.net/~omajid/webrevs/jcheck-bug-ids-strings/00/

Thanks,
Omair
-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681

From omajid at redhat.com  Thu Mar 21 12:07:24 2013
From: omajid at redhat.com (Omair Majid)
Date: Thu, 21 Mar 2013 15:07:24 -0400
Subject: [PATCH] jcheck: allow bug id line to be ignored
Message-ID: <514B5A6C.9050708@redhat.com>

Hi,

The following webrev adds a new configure option "ignore" for bugids. If
it is set, then jcheck does not validate the bug summary line at all.

http://cr.openjdk.java.net/~omajid/webrevs/jcheck-ignore-bug-line/00/

This is needed over at the JDK6 project so we can push commits with
Oracle's bug ids (backports from 7 and 8) as well as bugs with
"OPENJDK6-XXXX" bug ids. The thread with the suggestion is available at:

http://mail.openjdk.java.net/pipermail/jdk6-dev/2013-March/002922.html

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681