[PATCH] jcheck: allow bug id line to be ignored

mark.reinhold at oracle.com mark.reinhold at oracle.com
Tue May 7 17:20:15 PDT 2013


2013/5/7 9:58 -0700, omajid at redhat.com:
> On 05/07/2013 04:33 PM, mark.reinhold at oracle.com wrote:
>> 2013/4/30 6:43 -0700, omajid at redhat.com:
>>> On 04/08/2013 06:53 PM, mark.reinhold at oracle.com wrote:
>> On line 143, I'd make the regex a bit more precise, something like:
>> 
>> bug_ident = re.compile("(([A-Z][A-Z0-9]+-)?[0-9]+):")
> 
> I went with your suggestion, but do you know of any others who might be
> interested in (or affected by) this regex change?

No, not offhand.  So far jcheck has only been used in repos with purely
numeric bugids.

>> The new unit tests look fine.
> 
> Thanks for the comments.
> 
> New webrev:
> http://cr.openjdk.java.net/~omajid/webrevs/jcheck-ignore-bug-line/02/

Looks good.  Shall I push that patch for you, or do you want to qfinish
it and send me an hg bundle?  (If the latter, please hg qref -u omajid
to get the committer name set properly.)

- Mark


More information about the hg-tools-dev mailing list