hg: code-tools/jcheck: Don't collect non-numeric bugids
mark.reinhold at oracle.com
mark.reinhold at oracle.com
Thu May 9 15:06:52 PDT 2013
2013/5/9 7:50 -0700, omajid at redhat.com:
> On 05/09/2013 05:23 PM, mark.reinhold at oracle.com wrote:
>> Changeset: c45a917ff927
>> Author: mr
>> Date: 2013-05-09 14:17 -0700
>> URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/c45a917ff927
>>
>> Don't collect non-numeric bugids
>>
>> ! jcheck.py
>> ! runtests.sh
>
> I guess I made a mistake in my patch? Hope I didn't break anything.
Neither of us considered the case of a repo with JIRA-style bugids in
which bugids are not ignored, and just such a repo turned up today.
> I am a little confused about this change in the patch, though:
>
>> -if HGUSER=$setup_author hg ci -R z -m "6-2: test separate bugids
>> -Reviewed-by: $pass_author"; then fail; else true; fi
>> +echo "-- $r ignore bug ids 4"
>> +rm -rf z
>> +hg init z
>
> Doesn't that prevent test 3 from running?
Duh, my mistake. I'll fix that; thanks for noticing it.
- Mark
More information about the hg-tools-dev
mailing list