From John.Coomes at oracle.com Tue Oct 8 06:36:19 2013 From: John.Coomes at oracle.com (John Coomes) Date: Tue, 8 Oct 2013 06:36:19 -0700 Subject: review request - jcheck whitelist + blacklist additions In-Reply-To: <93b1886c-b60c-4a10-b119-a4f16d36ded1@default> References: <21052.61651.988594.735478@oracle.com> <93b1886c-b60c-4a10-b119-a4f16d36ded1@default> Message-ID: <21076.2643.415502.471884@oracle.com> Iris Clark (iris.clark at oracle.com) wrote: > For the blacklist change... Do you expect to use the same bugid used for all three releases? Hi Iris, The same bugid was used in the blacklisted changesets in all 3 releases, but the cset hashes were different, so the hash for each one had to be included in the patch. Does that answer your question? > Other than that, they're both fine. Thanks for looking at it. -John > -----Original Message----- > From: John Coomes > Sent: Friday, September 20, 2013 6:05 PM > To: hg-tools-dev at openjdk.java.net > Subject: review request - jcheck whitelist + blacklist additions > > Two small jcheck changes. > > The first whitelists a changeset with an invalid bugid line (has the "JDK-" prefix): > > http://cr.openjdk.java.net/~jcoomes/tools/jcheck/whitelist-20130701/ > > The second blacklists a bad fix that was made in three different > releases: > > http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20130920/ > > -John From John.Coomes at oracle.com Tue Oct 8 21:16:00 2013 From: John.Coomes at oracle.com (John Coomes) Date: Tue, 8 Oct 2013 21:16:00 -0700 Subject: jcheck review request - fix comment checking Message-ID: <21076.55424.133702.917013@oracle.com> I'd appreciate reviews of the following change to fix a bug in jcheck comment checking: http://cr.openjdk.java.net/~jcoomes/tools/jcheck/enforce-reviewed-by/ -John From mark.reinhold at oracle.com Thu Oct 10 10:49:22 2013 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 10 Oct 2013 10:49:22 -0700 Subject: jcheck review request - fix comment checking In-Reply-To: <21078.28943.644236.979801@oracle.com> References: <21076.55424.133702.917013@oracle.com>, <21078.28943.644236.979801@oracle.com> Message-ID: <20131010104922.985160@eggemoggin.niobe.net> (adding hg-tools-dev) 2013/10/9 19:19 -0700, john.coomes at oracle.com: > John Coomes (John.Coomes at oracle.com) wrote: >> I'd appreciate reviews of the following change to fix a bug in jcheck >> comment checking: >> >> http://cr.openjdk.java.net/~jcoomes/tools/jcheck/enforce-reviewed-by/ > > Just FYI, I've installed this on the servers and in > /java/jdk/lib/hgext. > > I'd like to push, but feel more comfortable with a review first :-). Well, that one's embarrassing. Your fix looks good. Did you check whether any existing changesets fail the new jcheck? If so then they'll need to be whitelisted. - Mark From John.Coomes at oracle.com Sat Oct 12 21:30:50 2013 From: John.Coomes at oracle.com (John Coomes) Date: Sat, 12 Oct 2013 21:30:50 -0700 Subject: jcheck review request - fix comment checking In-Reply-To: <20131010104922.985160@eggemoggin.niobe.net> References: <21076.55424.133702.917013@oracle.com> <21078.28943.644236.979801@oracle.com> <20131010104922.985160@eggemoggin.niobe.net> Message-ID: <21082.8698.617874.824804@oracle.com> mark.reinhold at oracle.com (mark.reinhold at oracle.com) wrote: > (adding hg-tools-dev) > > 2013/10/9 19:19 -0700, john.coomes at oracle.com: > > John Coomes (John.Coomes at oracle.com) wrote: > >> I'd appreciate reviews of the following change to fix a bug in jcheck > >> comment checking: > >> > >> http://cr.openjdk.java.net/~jcoomes/tools/jcheck/enforce-reviewed-by/ > > > > Just FYI, I've installed this on the servers and in > > /java/jdk/lib/hgext. > > > > I'd like to push, but feel more comfortable with a review first :-). > > Well, that one's embarrassing. Your fix looks good. Thanks. > Did you check whether any existing changesets fail the new jcheck? > If so then they'll need to be whitelisted. I checked all jdk8/jdk8 repos, and there were no complaints about Reviewers. Didn't check jdk7u/jdk7u, but this has been in use on the servers for a few days. -John From john.coomes at oracle.com Sat Oct 12 22:34:42 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sun, 13 Oct 2013 05:34:42 +0000 Subject: hg: code-tools/jcheck: 5 new changesets Message-ID: <20131013053442.ECE9962FF2@hg.openjdk.java.net> Changeset: ad3c51050fdd Author: jcoomes Date: 2013-07-01 18:53 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/ad3c51050fdd Whitelist pubs changeset with an invalid bugid line ! jcheck.py Changeset: 3fb6194f4aab Author: jcoomes Date: 2013-09-13 02:37 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/3fb6194f4aab Blacklist hsx/hotspot-gc/hotspot 9561e0a8a2d6 (wrong bugid) ! jcheck.py Changeset: 57fe3c196c14 Author: jcoomes Date: 2013-09-19 14:42 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/57fe3c196c14 Blacklist jdk8/ds/install 835ef04a36e5 (dup bugid) ! jcheck.py Changeset: 15fb870a6eae Author: jcoomes Date: 2013-09-20 17:17 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/15fb870a6eae Blacklist bad fix for 8025034 in 5.0u55, 6u65, 7u45 ! jcheck.py Changeset: 4d32511949b8 Author: jcoomes Date: 2013-10-10 02:09 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/4d32511949b8 A missing Reviewer line is not always detected If both a bugid and Summary line were present, jcheck would accept comments that were missing the Reviewer line. The fix is to increment the grammar index only when a line will actually be processed. ! jcheck.py ! mktests.sh From john.coomes at oracle.com Sat Oct 12 22:35:00 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sun, 13 Oct 2013 05:35:00 +0000 Subject: hg: code-tools/jcheck/dist: 5 new changesets Message-ID: <20131013053500.F0CBE62FF3@hg.openjdk.java.net> Changeset: 821a29196f01 Author: jcoomes Date: 2013-07-01 18:53 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/821a29196f01 jcheck ad3c51050fdd 2013-07-01 18:53:48 -0700 ! jcheck.py Changeset: cdb10efeb227 Author: jcoomes Date: 2013-09-13 02:37 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/cdb10efeb227 jcheck 3fb6194f4aab 2013-09-13 02:37:14 -0700 ! jcheck.py Changeset: 91d6466ed34d Author: jcoomes Date: 2013-09-19 14:42 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/91d6466ed34d jcheck 57fe3c196c14 2013-09-19 14:42:03 -0700 ! jcheck.py Changeset: e8701c07c631 Author: jcoomes Date: 2013-09-20 17:17 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/e8701c07c631 jcheck 15fb870a6eae 2013-09-20 17:17:44 -0700 ! jcheck.py Changeset: fb09e371e9de Author: jcoomes Date: 2013-10-10 02:09 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/fb09e371e9de jcheck 4d32511949b8 2013-10-10 02:09:31 -0700 ! jcheck.py From John.Coomes at oracle.com Tue Oct 15 15:07:26 2013 From: John.Coomes at oracle.com (John Coomes) Date: Tue, 15 Oct 2013 15:07:26 -0700 Subject: jcheck review request - whitelist changeset w/no Reviewed-by line Message-ID: <21085.48286.220964.815855@oracle.com> Please review this small addition to the whitelist. The recent fix to comment checking [1] caused jcheck to reject a changeset which was previously accepted. http://cr.openjdk.java.net/~jcoomes/tools/jcheck/whitelist-20131015/ -John [1] http://hg.openjdk.java.net/code-tools/jcheck/rev/4d32511949b8 From weijun.wang at oracle.com Tue Oct 15 16:08:55 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 16 Oct 2013 07:08:55 +0800 Subject: jcheck review request - whitelist changeset w/no Reviewed-by line In-Reply-To: <21085.48286.220964.815855@oracle.com> References: <21085.48286.220964.815855@oracle.com> Message-ID: <525DCB07.9040305@oracle.com> How about still keep on a single line? You can abbreviate long words. --Max On 10/16/13 6:07 AM, John Coomes wrote: > Please review this small addition to the whitelist. The recent fix to > comment checking [1] caused jcheck to reject a changeset which was > previously accepted. > > http://cr.openjdk.java.net/~jcoomes/tools/jcheck/whitelist-20131015/ > > -John > > [1] http://hg.openjdk.java.net/code-tools/jcheck/rev/4d32511949b8 > From John.Coomes at oracle.com Wed Oct 16 10:42:53 2013 From: John.Coomes at oracle.com (John Coomes) Date: Wed, 16 Oct 2013 10:42:53 -0700 Subject: jcheck review request - whitelist changeset w/no Reviewed-by line In-Reply-To: <525DCB07.9040305@oracle.com> References: <21085.48286.220964.815855@oracle.com> <525DCB07.9040305@oracle.com> Message-ID: <21086.53277.322249.620476@oracle.com> Weijun Wang (weijun.wang at oracle.com) wrote: > How about still keep on a single line? You can abbreviate long words. Hi Weijun, Thanks for taking a look. I like being concise, but this: '8407fef5685f32ed42b79c5d5f13f6c8007171ac', # hotspot/test/closed no rb line doesn't seem very helpful, and neither did the other one-line variants I tried. Any objections beyond the comment? -John > On 10/16/13 6:07 AM, John Coomes wrote: > > Please review this small addition to the whitelist. The recent fix to > > comment checking [1] caused jcheck to reject a changeset which was > > previously accepted. > > > > http://cr.openjdk.java.net/~jcoomes/tools/jcheck/whitelist-20131015/ > > > > -John > > > > [1] http://hg.openjdk.java.net/code-tools/jcheck/rev/4d32511949b8 > > From weijun.wang at oracle.com Wed Oct 16 17:16:11 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 17 Oct 2013 08:16:11 +0800 Subject: jcheck review request - whitelist changeset w/no Reviewed-by line In-Reply-To: <21086.53277.322249.620476@oracle.com> References: <21085.48286.220964.815855@oracle.com> <525DCB07.9040305@oracle.com> <21086.53277.322249.620476@oracle.com> Message-ID: <525F2C4B.505@oracle.com> On 10/17/13 1:42 AM, John Coomes wrote: > Weijun Wang (weijun.wang at oracle.com) wrote: >> How about still keep on a single line? You can abbreviate long words. > > Hi Weijun, > > Thanks for taking a look. I like being concise, but this: > > '8407fef5685f32ed42b79c5d5f13f6c8007171ac', # hotspot/test/closed no rb line > > doesn't seem very helpful, and neither did the other one-line variants > I tried. Any objections beyond the comment? No. Thanks Max > > -John > >> On 10/16/13 6:07 AM, John Coomes wrote: >>> Please review this small addition to the whitelist. The recent fix to >>> comment checking [1] caused jcheck to reject a changeset which was >>> previously accepted. >>> >>> http://cr.openjdk.java.net/~jcoomes/tools/jcheck/whitelist-20131015/ >>> >>> -John >>> >>> [1] http://hg.openjdk.java.net/code-tools/jcheck/rev/4d32511949b8 >>> From john.coomes at oracle.com Thu Oct 24 14:41:02 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 24 Oct 2013 21:41:02 +0000 Subject: hg: code-tools/jcheck/dist: jcheck 3125d498f453 2013-10-15 15:01:39 -0700 Message-ID: <20131024214103.0B4E162706@hg.openjdk.java.net> Changeset: a6db312860ef Author: jcoomes Date: 2013-10-15 15:01 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/a6db312860ef jcheck 3125d498f453 2013-10-15 15:01:39 -0700 ! jcheck.py From john.coomes at oracle.com Thu Oct 24 14:37:32 2013 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 24 Oct 2013 21:37:32 +0000 Subject: hg: code-tools/jcheck: Whitelist hotspot/test/closed 8407fef5685f (no Reviewed-by line) Message-ID: <20131024213732.8DD7462704@hg.openjdk.java.net> Changeset: 3125d498f453 Author: jcoomes Date: 2013-10-15 15:01 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/3125d498f453 Whitelist hotspot/test/closed 8407fef5685f (no Reviewed-by line) ! jcheck.py