jcheck review request - fix comment checking
mark.reinhold at oracle.com
mark.reinhold at oracle.com
Thu Oct 10 10:49:22 PDT 2013
(adding hg-tools-dev)
2013/10/9 19:19 -0700, john.coomes at oracle.com:
> John Coomes (John.Coomes at oracle.com) wrote:
>> I'd appreciate reviews of the following change to fix a bug in jcheck
>> comment checking:
>>
>> http://cr.openjdk.java.net/~jcoomes/tools/jcheck/enforce-reviewed-by/
>
> Just FYI, I've installed this on the servers and in
> /java/jdk/lib/hgext.
>
> I'd like to push, but feel more comfortable with a review first :-).
Well, that one's embarrassing. Your fix looks good.
Did you check whether any existing changesets fail the new jcheck?
If so then they'll need to be whitelisted.
- Mark
More information about the hg-tools-dev
mailing list