jcheck review request - whitelist changeset w/no Reviewed-by line
Weijun Wang
weijun.wang at oracle.com
Wed Oct 16 17:16:11 PDT 2013
On 10/17/13 1:42 AM, John Coomes wrote:
> Weijun Wang (weijun.wang at oracle.com) wrote:
>> How about still keep on a single line? You can abbreviate long words.
>
> Hi Weijun,
>
> Thanks for taking a look. I like being concise, but this:
>
> '8407fef5685f32ed42b79c5d5f13f6c8007171ac', # hotspot/test/closed no rb line
>
> doesn't seem very helpful, and neither did the other one-line variants
> I tried. Any objections beyond the comment?
No.
Thanks
Max
>
> -John
>
>> On 10/16/13 6:07 AM, John Coomes wrote:
>>> Please review this small addition to the whitelist. The recent fix to
>>> comment checking [1] caused jcheck to reject a changeset which was
>>> previously accepted.
>>>
>>> http://cr.openjdk.java.net/~jcoomes/tools/jcheck/whitelist-20131015/
>>>
>>> -John
>>>
>>> [1] http://hg.openjdk.java.net/code-tools/jcheck/rev/4d32511949b8
>>>
More information about the hg-tools-dev
mailing list