From david.holmes at oracle.com Thu Apr 3 12:14:43 2014 From: david.holmes at oracle.com (David Holmes) Date: Thu, 03 Apr 2014 22:14:43 +1000 Subject: sub-tree configuration ? Message-ID: <533D50B3.1050800@oracle.com> If I tclone a complete forest all the tree subcommands work as expected from the top-level repo. But if I cd into a repo that is itself a "tree" the trees extension doesn't recognize it unless I use tconfig to define that sub-tree. Is there a way to automate this so that the subtrees don't need to be manually configured? Thanks, David From alejandro.murillo at oracle.com Fri Apr 4 18:22:00 2014 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 04 Apr 2014 12:22:00 -0600 Subject: sub-tree configuration ? In-Reply-To: <533D50B3.1050800@oracle.com> References: <533D50B3.1050800@oracle.com> Message-ID: <533EF848.3060409@oracle.com> On 4/3/2014 6:14 AM, David Holmes wrote: > If I tclone a complete forest all the tree subcommands work as > expected from the top-level repo. > > But if I cd into a repo that is itself a "tree" the trees extension > doesn't recognize it unless I use tconfig to define that sub-tree. What I do, as recommended by John Coomes, is to have local copies of the master repos I usually clone. Then I configure those so that they have the tree conf in the "sub-trees" (hotpot and jdk). So when cloning, I tclone from the local master repo (that already has the proper conf in the sub-trees), instead of tcloning from the http master, so the clone will also have that info in the subtree. caveat: you need to make sure your local repos are synched with the master before cloning them. Note that this indicates, that, if the http master repos would have the tree info for the sub-trees, then it would also solve that problem when tcloning from those, but I suspect that info is not there, because that would be closed info in the open repo hth Alejandro > > Is there a way to automate this so that the subtrees don't need to be > manually configured? > > Thanks, > David -- Alejandro From david.holmes at oracle.com Mon Apr 7 01:01:32 2014 From: david.holmes at oracle.com (David Holmes) Date: Mon, 07 Apr 2014 11:01:32 +1000 Subject: sub-tree configuration ? In-Reply-To: <533EF848.3060409@oracle.com> References: <533D50B3.1050800@oracle.com> <533EF848.3060409@oracle.com> Message-ID: <5341F8EC.20908@oracle.com> On 5/04/2014 4:22 AM, Alejandro E Murillo wrote: > > On 4/3/2014 6:14 AM, David Holmes wrote: >> If I tclone a complete forest all the tree subcommands work as >> expected from the top-level repo. >> >> But if I cd into a repo that is itself a "tree" the trees extension >> doesn't recognize it unless I use tconfig to define that sub-tree. > What I do, as recommended by John Coomes, is to have local copies of the > master repos > I usually clone. Then I configure those so that they have the tree conf > in the "sub-trees" > (hotpot and jdk). So when cloning, I tclone from the local master repo > (that already has > the proper conf in the sub-trees), instead of tcloning from the http > master, so the clone will also have that info in the subtree. Sure, but it is this initial step that I'd like to see automated. :) If tclone can generate the config for the top-level, it could probably generate the config for sub-trees too. Cheers, David > caveat: you need to make sure your local repos are synched with the > master before cloning them. > > Note that this indicates, that, if the http master repos would have the > tree info for the sub-trees, then it > would also solve that problem when tcloning from those, but I suspect > that info is not there, because > that would be closed info in the open repo > > hth > Alejandro >> >> Is there a way to automate this so that the subtrees don't need to be >> manually configured? >> >> Thanks, >> David > From John.Coomes at oracle.com Mon Apr 7 21:02:01 2014 From: John.Coomes at oracle.com (John Coomes) Date: Mon, 7 Apr 2014 14:02:01 -0700 Subject: jcheck review request - blacklist update Message-ID: <21315.4681.608152.571164@mykonos.us.oracle.com> I'd appreciate a review of this small addition to the jcheck blacklist: http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20140407/ -John From John.Coomes at oracle.com Mon Apr 7 22:36:48 2014 From: John.Coomes at oracle.com (John Coomes) Date: Mon, 7 Apr 2014 15:36:48 -0700 Subject: sub-tree configuration ? In-Reply-To: <5341F8EC.20908@oracle.com> References: <533D50B3.1050800@oracle.com> <533EF848.3060409@oracle.com> <5341F8EC.20908@oracle.com> Message-ID: <21315.10368.583546.979402@mykonos.us.oracle.com> David Holmes (david.holmes at oracle.com) wrote: > On 5/04/2014 4:22 AM, Alejandro E Murillo wrote: > > > > On 4/3/2014 6:14 AM, David Holmes wrote: > >> If I tclone a complete forest all the tree subcommands work as > >> expected from the top-level repo. > >> > >> But if I cd into a repo that is itself a "tree" the trees extension > >> doesn't recognize it unless I use tconfig to define that sub-tree. > > What I do, as recommended by John Coomes, is to have local copies of the > > master repos > > I usually clone. Then I configure those so that they have the tree conf > > in the "sub-trees" > > (hotpot and jdk). So when cloning, I tclone from the local master repo > > (that already has > > the proper conf in the sub-trees), instead of tcloning from the http > > master, so the clone will also have that info in the subtree. > > Sure, but it is this initial step that I'd like to see automated. :) If > tclone can generate the config for the top-level, it could probably > generate the config for sub-trees too. If the top-most repo already has the desired subtrees configured (e.g., after a tclone), use tconfig with the --depth option: $ hg tconfig --set --depth That will take the existing configured subtrees and rewrite the configuration depth-most (i.e., each subtree is defined in the nearest enclosing repo). FWIW, I regularly use this. If the top-most repo does not have the desired subtrees configured (e.g., after using getsource.sh), add the --walk option to the above to walk the filesystem and discover subtrees: $ hg tconfig --set --depth --walk There are still a few changes necessary on the server for the configuration to be written depth-most during a tclone. But once those are done, tclone will do what you (and I) want, and the separate "tconfig --set --depth" step will be unnecessary. -John > > caveat: you need to make sure your local repos are synched with the > > master before cloning them. > > > > Note that this indicates, that, if the http master repos would have the > > tree info for the sub-trees, then it > > would also solve that problem when tcloning from those, but I suspect > > that info is not there, because > > that would be closed info in the open repo > > > > hth > > Alejandro > >> > >> Is there a way to automate this so that the subtrees don't need to be > >> manually configured? > >> > >> Thanks, > >> David > > -- John Coomes Oracle, MS USCA22-3?? john.coomes at oracle.com 4220 Network Circle 408-276-7048 Santa Clara, CA 95054-1778 *** Support GreenPeace and we'll all breathe easier. *** From iris.clark at oracle.com Wed Apr 9 00:59:19 2014 From: iris.clark at oracle.com (Iris Clark) Date: Tue, 8 Apr 2014 17:59:19 -0700 (PDT) Subject: jcheck review request - blacklist update In-Reply-To: <21315.4681.608152.571164@mykonos.us.oracle.com> References: <21315.4681.608152.571164@mykonos.us.oracle.com> Message-ID: Hi, John. This looks fine to me. Thanks, iris -----Original Message----- From: John Coomes Sent: Monday, April 07, 2014 2:02 PM To: hg-tools-dev at openjdk.java.net Subject: jcheck review request - blacklist update I'd appreciate a review of this small addition to the jcheck blacklist: http://cr.openjdk.java.net/~jcoomes/tools/jcheck/blacklist-20140407/ -John From john.coomes at oracle.com Tue Apr 15 23:24:45 2014 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 15 Apr 2014 23:24:45 +0000 Subject: hg: code-tools/jcheck: Blacklist jdk/src/closed a19596796430, jdk/test/closed d2308c9714c9 Message-ID: <201404152324.s3FNOkmG018661@aojmv0008> Changeset: c48f53c04127 Author: jcoomes Date: 2014-04-07 12:27 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/rev/c48f53c04127 Blacklist jdk/src/closed a19596796430, jdk/test/closed d2308c9714c9 ! jcheck.py From john.coomes at oracle.com Tue Apr 15 23:24:48 2014 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 15 Apr 2014 23:24:48 +0000 Subject: hg: code-tools/jcheck/dist: jcheck c48f53c04127 2014-04-07 12:27:10 -0700 Message-ID: <201404152324.s3FNOmZP018740@aojmv0008> Changeset: 556c4803f324 Author: jcoomes Date: 2014-04-07 12:27 -0700 URL: http://hg.openjdk.java.net/code-tools/jcheck/dist/rev/556c4803f324 jcheck c48f53c04127 2014-04-07 12:27:10 -0700 ! jcheck.py