jcheck review request - pushkey hook
mark.reinhold at oracle.com
mark.reinhold at oracle.com
Tue Mar 11 20:24:00 UTC 2014
2014/3/11 2:31 -0700, john.coomes at oracle.com:
> mark.reinhold at oracle.com (mark.reinhold at oracle.com) wrote:
>> Why does this belong in jcheck, rather than in a separate hook?
>
> I think that before long we'll want a more flexible policy, and for
> that we could tap into the existing jcheck conf mechanism (e.g., allow
> pushkeys when jcheck tags=lax, or maybe use a separate pushkeys=lax
> config item). We may also want to check pushkeys like we currently
> check tags. Finally, I think we should allow projects/repos that
> aren't using jcheck to manage pushkeys as they choose.
Okay, fair enough.
It'd be helpful to have a comment in jcheck.py to indicate that
prepushkey is an entry point that may be invoked externally, lest
it disappear in some future refactoring.
- Mark
More information about the hg-tools-dev
mailing list