RFR(XS): 7901298: jcheck should check that every file ends with exactly one newline

[Chris Hegarty]

On 29 Apr 2015, at 22:49, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:

> Any takers for this one?

I’ve taken this change for a test drive, and it seems to handle just fine. A nice addition ( not a capital Reviewer on the Code Tools Project ).

But… what will happen when jcheck is run over exiting changesets that add or modify files to have no newline, or more than one newline?
  hg jcheck --rev 0:tip

Is this an issue?   

-Chris.

> -- Jon
> 
> 
> -------- Forwarded Message --------
> Subject: 	RFR(XS): 7901298: jcheck should check that every file ends with exactly one newline
> Date: 	Fri, 13 Feb 2015 12:01:15 +0100
> From: 	Volker Simonis <volker.simonis at gmail.com>
> To: 	code-tools-dev <code-tools-dev at openjdk.java.net>
> 
> 
> 
> Hi,
> 
> could somebody please review and sponsor the following small change
> which adds a test for exactly one newline at the and of a file to
> check:
> 
> http://cr.openjdk.java.net/~simonis/webrevs/2015/7901298/
> https://bugs.openjdk.java.net/browse/CODETOOLS-7901298
> 
> Thank you and best regards,
> Volker
> 
> 
>