RFR(XS): 7901298: jcheck should check that every file ends with exactly one newline

[Iris Clark]

Hi, Jon.

I'm not an expert on jcheck.

It appears that the changeset adds a requirement to the default jcheck behavior.  I suspect that the expectation is that this check will be enabled for the jdk9 forest since it was motivated by a faulty changeset in the jdk9 hotspot repository [0].

Do all of the changesets (-r 0:tip) in all existing forests where jcheck is enabled pass with this change?  On push to a server, the entire repository is checked for compliance to jcheck, not just the pushed changesets.  Given the hotspot history, I suspect that this eliminates any jdk9 hotspot forest (including branches of jdk9 such as those for existing Projects and the future jdk9u and jdk10 forests).  jcheck could also not be enabled in any repository where the faulty changeset was propagated (jdk8u?) or coincidentally contains another changeset which does not adhere to the new whitespace requirements.

Minimally, the addition of this check would need to be controlled by an option.  If the goal is to apply the check to the jdk9 forest, a more sophisticated solution is needed.

Mark, as the original jcheck author, may have additional insight.

Thanks,
iris

[0] http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-February/017138.html

-----Original Message-----
From: Jonathan Gibbons 
Sent: Wednesday, April 29, 2015 2:49 PM
To: hg-tools-dev at openjdk.java.net
Subject: Fwd: RFR(XS): 7901298: jcheck should check that every file ends with exactly one newline

Any takers for this one?

-- Jon


-------- Forwarded Message --------
Subject: 	RFR(XS): 7901298: jcheck should check that every file ends 
with exactly one newline
Date: 	Fri, 13 Feb 2015 12:01:15 +0100
From: 	Volker Simonis <volker.simonis at gmail.com>
To: 	code-tools-dev <code-tools-dev at openjdk.java.net>



Hi,

could somebody please review and sponsor the following small change which adds a test for exactly one newline at the and of a file to
check:

http://cr.openjdk.java.net/~simonis/webrevs/2015/7901298/
https://bugs.openjdk.java.net/browse/CODETOOLS-7901298

Thank you and best regards,
Volker